feat(jellyfish-api-core): Add index based pagination support to listaccounthistory RPC
#1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
apps/whale-api
area/apps
area/packages
kind/feature
|
Code Climate has analyzed commit eddd153 and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 91.33% // Head: 92.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
==========================================
+ Coverage 91.33% 92.98% +1.65%
==========================================
Files 363 363
Lines 10764 10765 +1
Branches 1370 1370
==========================================
+ Hits 9831 10010 +179
+ Misses 896 727 -169
+ Partials 37 28 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Docker build preview for jellyfish/apps is ready! Built with commit 4f7ad70
You can also get an immutable image with the commit hash
|
helloscoopa
requested review from
fuxingloh,
canonbrother,
ivan-zynesis,
kodemon and
eli-lim
as code owners
helloscoopa
changed the base branch from
main
to
dilshan/add-more-filter-options-to-accounthistorycount
helloscoopa
changed the base branch from
dilshan/add-more-filter-options-to-accounthistorycount
to
main
Signed-off-by: Dilshan Madushanka <[email protected]>
infinia-yzl
reviewed
Jan 3, 2023
packages/jellyfish-api-core/__tests__/category/account/listAccountHistory.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/account/listAccountHistory.test.ts
Show resolved
Hide resolved
…ountHistory.test.ts Co-authored-by: Isaac Yong <[email protected]> Signed-off-by: Dilshan Madushanka <[email protected]>
infinia-yzl
previously approved these changes
Jan 4, 2023
marktanrj
previously approved these changes
Jan 4, 2023
Signed-off-by: Dilshan Madushanka <[email protected]>
helloscoopa
requested review from
thedoublejay,
kyleleow and
pierregee
as code owners
Signed-off-by: Dilshan Madushanka <[email protected]>
helloscoopa
dismissed stale reviews from imkven, marktanrj, and infinia-yzl
via
04a044d
delphk
approved these changes
Jan 19, 2023
fuxingloh
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Requirement: Upcoming consortium transaction history page on defiscan.live requires a way to paginate the list of transactions among consortium members.
Issue: Currently we only have
blockHeightanddepthbased pagination/cursor which we're unable to use to address the requirement as it only cursor through blocks but not transactions., More info here.Solution:
Huge thanks to @shohamc1 for supporting me on defich/ain side, refer defich/ain PR