Merge upstream main to prod #4922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#27635) **Description:** Bumps the receiver to beta stability for logs **Link to tracking Issue:** <Issue number if applicable> Closes open-telemetry#21503
….uber.org/multierr (open-telemetry#27857) **Description:** use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> open-telemetry#25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
cc @open-telemetry/java-contrib-approvers
**Description:** The linter runs are taking longer and longer as more components and dependencies are added, it's preferable to simply run on each individual component. **Link to tracking Issue:** Related: open-telemetry#27850
This PR adds a debug log to give visibility into the exact outcome of file matching configuration. It also removes some fragile logging expectations from batching tests. I believe the meaningful part of the tests remain intact.
…open-telemetry#27484) **Description:** Create a new extension for JSON. This will be used in pulsarreceiver/kafkareceiver to populate the log record's map from the raw body. **Link to tracking Issue:** [6272](https://github.com/open-telemetry/opentelemetry-collector/issues/6272) --------- Co-authored-by: Dmitrii Anoshin <[email protected]>
**Description:** Support ignore span attribute value in span comparisons for ptracetest. **Link to tracking Issue:** open-telemetry#27689
…sts (open-telemetry#27848) The lifecycle test passes readonly data to processors claimed as not mutable to catch invalid behavior. Similar to open-telemetry#27825, but for processors tests.
…y#27869) The website docs.signalfx.com has been decommissioned and no longer resolves. Changing all doc links to the new doc website or removing them.
…eout (open-telemetry#27815) **Description:** The dimension client timeout is currently hardcoded to 10 seconds, this PR makes the timeout configurable. Signed-off-by: Dani Louca <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
…flexible (open-telemetry#27683) **Description:** Make export of resources and scopes more flexible **Link to tracking Issue:** open-telemetry#27651 , open-telemetry#27649 **Testing:** Unit tests **Documentation:** <Describe the documentation added.> **Note:**: This PR is on top of this PR - https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/27663/files - since it's introducing some helper functions and it's fixing NPE. Fixes open-telemetry#27651 Fixes open-telemetry#27649 --------- Signed-off-by: Paschalis Tsilias <[email protected]> Signed-off-by: Christian Kruse <[email protected]> Co-authored-by: Paschalis Tsilias <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Dmitrii Anoshin <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]> Co-authored-by: hovavza <[email protected]> Co-authored-by: Daniel Jaglowski <[email protected]> Co-authored-by: Brandon Johnson <[email protected]> Co-authored-by: Miel Donkers <[email protected]> Co-authored-by: bryan-aguilar <[email protected]> Co-authored-by: sakulali <[email protected]> Co-authored-by: Christian Kruse <[email protected]> Co-authored-by: gord02 <[email protected]> Co-authored-by: bagmeg <[email protected]> Co-authored-by: Yang Song <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Curtis Robert <[email protected]> Co-authored-by: VihasMakwana <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
**Description:** Copying reader with empty FlushState will cause a nil pointer dereference.
…emetry#27878) **Description:** Move `cmd/telemetrygen` integration tests to separate module, to avoid local replaces. Follow up to open-telemetry#26668. **Link to tracking Issue:** Fixes open-telemetry#27855
…nfigs (open-telemetry#25888) **Description:** Fixes open-telemetry#5001 When that issue was filed, we dropped unknown-typed metrics. Now that we convert them to gauges, users may want to use metric_relabel_configs to rename metrics, even if they lose metadata. In the future, we have other enhancements planned to better-support unknown-typed metrics. Change the error to a warning. It is still likely not a best practice to use relabel configs for this purpose, but for users copy-pasting prometheus configs, it is best not to fail if we can help it.
…ry#27884) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Same idea as open-telemetry#27865, remove generated code from being linted. The linter is taking longer and longer to run as more components and dependencies are added. This change is to remove unnecessary modules from being linted, which will help reduce runtime and resources required. **Link to tracking Issue:** <Issue number if applicable> Related open-telemetry#27850
Some changes were made to the CODEOWNERS file without editing the metadata.yaml files first.
…org/multierr (open-telemetry#27888) **Description:** use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> open-telemetry#25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
open-telemetry#27288) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** open-telemetry#27282 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Dominik Rosiek <[email protected]> Signed-off-by: Raphael Silva <[email protected]> Signed-off-by: Alex Boten <[email protected]> Signed-off-by: Pavol Loffay <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Raj Nishtala <[email protected]> Co-authored-by: Dominik Rosiek <[email protected]> Co-authored-by: Povilas Versockas <[email protected]> Co-authored-by: Priyanshu Raj <[email protected]> Co-authored-by: sakulali <[email protected]> Co-authored-by: Raphael Philipe Mendes da Silva <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Yotam loewenbach <[email protected]> Co-authored-by: Alex Boten <[email protected]> Co-authored-by: bryan-aguilar <[email protected]> Co-authored-by: Daniel Jaglowski <[email protected]> Co-authored-by: Jina Jain <[email protected]> Co-authored-by: Yang Song <[email protected]> Co-authored-by: Dmitrii Anoshin <[email protected]> Co-authored-by: Curtis Robert <[email protected]> Co-authored-by: Abhishek Saharn <[email protected]> Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Ziqi Zhao <[email protected]> Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Faith Chikwekwe <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> Co-authored-by: Daniel Kuiper <[email protected]> Co-authored-by: Carlos Castro <[email protected]> Co-authored-by: Christian <[email protected]> Co-authored-by: ArchangelSDY <[email protected]> Co-authored-by: Pavol Loffay <[email protected]> Co-authored-by: Paulo Janotti <[email protected]> Co-authored-by: Nathan Burke <[email protected]> Co-authored-by: VihasMakwana <[email protected]> Co-authored-by: shalper2 <[email protected]> Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Martin Majlis <[email protected]> Co-authored-by: hovavza <[email protected]>
**Description:** Test for open-telemetry/opentelemetry-collector/pull/8723
…try#28206) This PR just streamlines some test code.
Follows: open-telemetry#28206 This PR fixes a setup problem with a particular test and further enhances it to make it more robust. The problem was that it restarts a single operator, which is not strictly supported behavior. Instead, a new operator should be created from the same config. The test involves moving a file and then validating that a log written to the original file location is read correctly. This enhances the test to also validate that additional logs written to the original (moved) file will be read as well.
Signed-off-by: Alex Boten <[email protected]>
…pen-telemetry#27877) Introduce zipkin encoding extension. For more context, see open-telemetry#27564
**Description:** Fixes an issue with the grammar where named parameters had to have a space after the `=`. **Link to tracking Issue:** Closes open-telemetry#27638 **Testing:** Added a new unit test
…-telemetry#28294) Follows open-telemetry#28228 This normalizes calls to `Start` and `Stop` across the test suite. In some cases, `poll` is called directly in order to trigger behavior independently of timing. However, we should _either_ use `poll` directly, or use both `Start` and `Stop` exactly once. In the future, I expect `poll` will be exported and tested directly as part of an internal package.
…metry#28451) Follows open-telemetry#28419 This discards the separate "roller" and implements the same functionality directly in `fileconsumer.Manager`. The motivation for this is to move towards a system of managing files where each file is managed by only one list at a time. This PR retains two overlapping slices of readers (`previousPollFiles` and `knownFiles`), but the functionality does not change. open-telemetry#27823 should get us the rest of the way there.
The following commands were run to prepare this release: - make chlog-update VERSION=v0.88.0 - sed -i.bak s/0.87.0/0.88.0/g versions.yaml - make multimod-prerelease - make multimod-sync
…0.88.x Merge release/v0.88.x branch into main
…28569) `fileconsumer.Manager.poll` leaves files open so that the next poll cycle can use them. In tests, the direct use of this function should be accompanied by explicit action to clean up the files.
…ry#28572) Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp from 1.19.1 to 1.20.0 in /exporter/datadogexporter Bump github.com/IBM/sarama from 1.41.2 to 1.41.3 in /exporter/kafkaexporter Bump github.com/IBM/sarama from 1.41.2 to 1.41.3 in /receiver/kafkareceiver Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.1 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.1 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.1 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.1 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.1 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.2 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.2 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.2 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.2 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.2 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.2 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.2 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.2 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.2 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.2 in /internal/metadataproviders Bump github.com/aws/aws-sdk-go from 1.45.26 to 1.46.2 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go-v2/service/kinesis from 1.19.2 to 1.20.0 in /exporter/awskinesisexporter Bump github.com/fsnotify/fsnotify from 1.6.0 to 1.7.0 in /exporter/prometheusremotewriteexporter Bump github.com/golangci/golangci-lint from 1.54.1 to 1.55.0 in /internal/tools Bump github.com/klauspost/compress from 1.17.1 to 1.17.2 in /exporter/fileexporter Bump github.com/klauspost/compress from 1.17.1 to 1.17.2 in /exporter/sapmexporter Bump github.com/prometheus/common from 0.44.0 to 0.45.0 in /exporter/prometheusexporter Bump github.com/prometheus/common from 0.44.0 to 0.45.0 in /testbed Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.767 to 1.0.772 in /exporter/tencentcloudlogserviceexporter Bump github.com/wavefronthq/wavefront-sdk-go from 0.14.0 to 0.15.0 in /exporter/tanzuobservabilityexporter Bump go.opentelemetry.io/collector/component from 0.87.1-0.20231023033326-37116a25be8d to 0.88.0 in /receiver/awsxrayreceiver Bump go.opentelemetry.io/collector/processor from 0.87.1-0.20231023033326-37116a25be8d to 0.88.0 in /processor/logstransformprocessor Bump google.golang.org/api from 0.147.0 to 0.148.0 in /exporter/f5cloudexporter Bump google.golang.org/api from 0.147.0 to 0.148.0 in /receiver/googlecloudpubsubreceiver Bump google.golang.org/api from 0.147.0 to 0.148.0 in /receiver/googlecloudspannerreceiver Bump google.golang.org/grpc from 1.58.3 to 1.59.0 in /examples/demo/client Bump k8s.io/api from 0.28.2 to 0.28.3 in /extension/observer/k8sobserver Bump k8s.io/api from 0.28.2 to 0.28.3 in /internal/aws/k8s Bump k8s.io/api from 0.28.2 to 0.28.3 in /internal/metadataproviders Bump k8s.io/api from 0.28.2 to 0.28.3 in /processor/k8sattributesprocessor Bump k8s.io/apimachinery from 0.28.2 to 0.28.3 in /exporter/datadogexporter Bump k8s.io/apimachinery from 0.28.2 to 0.28.3 in /extension/observer/k8sobserver Bump k8s.io/apimachinery from 0.28.2 to 0.28.3 in /internal/aws/k8s Bump k8s.io/apimachinery from 0.28.2 to 0.28.3 in /internal/k8sconfig Bump k8s.io/apimachinery from 0.28.2 to 0.28.3 in /internal/metadataproviders Bump k8s.io/apimachinery from 0.28.2 to 0.28.3 in /receiver/kubeletstatsreceiver Bump k8s.io/client-go from 0.28.2 to 0.28.3 in /extension/observer/k8sobserver Bump k8s.io/client-go from 0.28.2 to 0.28.3 in /internal/aws/k8s Bump k8s.io/client-go from 0.28.2 to 0.28.3 in /internal/k8sconfig Bump k8s.io/client-go from 0.28.2 to 0.28.3 in /internal/kubelet Bump k8s.io/client-go from 0.28.2 to 0.28.3 in /internal/metadataproviders Bump k8s.io/client-go from 0.28.2 to 0.28.3 in /processor/k8sattributesprocessor Bump sigs.k8s.io/controller-runtime from 0.16.2 to 0.16.3 in /exporter/loadbalancingexporter --------- Signed-off-by: Alex Boten <[email protected]> Co-authored-by: Alex Boten <[email protected]>
…ry#28611) Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp from 1.19.1 to 1.20.0 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.46.2 to 1.46.3 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.46.2 to 1.46.3 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.46.2 to 1.46.3 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.46.2 to 1.46.3 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.46.2 to 1.46.3 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.46.2 to 1.46.3 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.46.2 to 1.46.3 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.46.2 to 1.46.3 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.46.2 to 1.46.3 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.46.2 to 1.46.3 in /internal/metadataproviders Bump github.com/aws/aws-sdk-go from 1.46.2 to 1.46.3 in /receiver/awsxrayreceiver Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.767 to 1.0.772 in /exporter/tencentcloudlogserviceexporter Bump go.opentelemetry.io/collector/component from 0.87.1-0.20231023033326-37116a25be8d to 0.88.0 in /receiver/awsxrayreceiver Bump k8s.io/apimachinery from 0.28.2 to 0.28.3 in /receiver/kubeletstatsreceiver
…e formats (open-telemetry#25096) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Adding a Translator to convert from Azure Resource Log format (for now) to OTel. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#18210 **Testing:** <Describe what testing was performed and which tests were added.> Performed manual validation testing between Event Hubs and OTel and added unit tests to cover new use case to allow multiple resources to be included in a batch. Existing tests moved to new package. **Documentation:** <Describe the documentation added.> None was necessary as this format is already supported by the Event Hub Receiver.
**Description:** Fix flakiness in the `TestGettingTrackingData/Timeout_waiting_for_response` test. The root cause of the issue is that the `client` and `server` are connected to same pipe and if the server attempts to read after the client is closed it reports error EOF and the test code expects no error from the read operation. The issue is not specific to Windows. The fix was to give control to each test case of the read and write functions so this type of synchronization issue can be properly handled while keeping the test code coverage. **Link to tracking Issue:** Fix open-telemetry#25188 **Testing:** Multiple local runs with various cpu settings. **Documentation:** N/A Co-authored-by: Alex Boten <[email protected]>
This PR enhances the internal `trie` struct (which is not yet in use anywhere in the codebase) such that a node may contain any value. The motivation for this is that I believe we may soon be able to migrate `knownFiles` and `previousPollFiles` to tries, which will prove out the functionality of the trie and also should improve efficiency of the package overall.
…28580) Although the persister is generally expected, we can easily protect against cases where it is not provided and save some work as well. This becomes more important with open-telemetry#27823 which interacts with the persister during the Stop function.
…er.org/multierr (open-telemetry#27908) **Description:** <Describe what has changed.> use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** <Issue number if applicable> open-telemetry#25121 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
**Description:** Add a new traces config `trace_buffer` that specifies the number of Datadog Agent TracerPayloads to buffer before dropping. **Link to tracking Issue:** Fixes open-telemetry#28577 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
mulitmod -> multimod Signed-off-by: Alex Boten <[email protected]>
We see a lot of issues opened that are related to collector usability. As shared in open-telemetry#27546, documentation can often be added to help clear up confusion, or provide relevant information. We can use the `documentation` label for this going forward. Resolves open-telemetry#27456 --------- Co-authored-by: bryan-aguilar <[email protected]>
It looks like this change was missed in a couple of releases. Signed-off-by: Alex Boten <[email protected]>
…mplete the transition to container.cpu.utilization (open-telemetry#27795) **Description:** <Describe what has changed.> Following up open-telemetry#24183, this PR removes the deprecated `container.cpu.percent` metric as explained in README's [deprecation section](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/dockerstatsreceiver#transition-to-cpu-utilization-metric-name-aligned-with-opentelemetry-specification). **Link to tracking Issue:** open-telemetry#21807 **Testing:** <Describe what testing was performed and which tests were added.> ``` ❯ go test -race -timeout 300s -parallel 4 --tags="" ./... -count 1 ok github.com/open-telemetry/opentelemetry-collector-contrib/receiver/dockerstatsreceiver 1.480s ok github.com/open-telemetry/opentelemetry-collector-contrib/receiver/dockerstatsreceiver/internal/metadata 1.525s ``` **Documentation:** the documentation has been updated using `mdatagen` --------- Co-authored-by: Pablo Baeyens <[email protected]>
**Description:** <Describe what has changed.> Add an integration tests to datadog exporter that: 1. Use the mock server in datadog exporter testutil as the backend 2. Starts a collector with otlp receiver, datadog connector, tail sampling processor, datadog exporter. Have datadog exporter send data to the mock server 3. Generate and send 10 spans to collector, 5 of which are expected to be sampled by tail sampling processor 4. Verify the mock server receives 5 traces (sampled) + APM stats on all 10 traces pre-sampled **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
…telemetry#27889) **Description:** Since each `tailSamplingSpanProcessor`'s instance is not concurrently called by the ticker worker (it's a 1-to-1 relationship) we can safely reuse a slice for the tag mutators used in `makeDecision`. Additionally the tag mutators themselves were causing a lot of allocations and since they are static, we created constants for them preventing allocations on each execution of `makeDecision`. This improved the `makeDecision` benchmark by ~31%. ``` benchstat old.txt new.txt name old time/op new time/op delta Sampling-10 51.8µs ± 1% 35.7µs ± 1% -30.94% (p=0.008 n=5+5) ``` **Testing:** Unit tests unchanged; added a benchmark **Documentation:** Perf improvement so no documentation changes needed. This was all based on production profiling data at Polar Signals running the collector. Here is a snapshot of the original profiling data we started with: https://pprof.me/52a7fab/ Judging by the production profiling data, a 31% improvement on the `makeDecision` codepath, should translate roughly into a 6% baseline CPU improvement our production deployment of the opentelemetry collector. The profiling data after improving: https://pprof.me/58c0e84/ This improvement was done as part of the Let's Profile Livestream where we optimize popular open-source projects live: https://www.youtube.com/watch?v=vkMQRjiNTHM --------- Co-authored-by: Jiekun <[email protected]>
…7446) Fixes open-telemetry#21045 Signed-off-by: Juraci Paixão Kröhling <[email protected]> --------- Signed-off-by: Juraci Paixão Kröhling <[email protected]>
…#28623) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The Documentation surrounding Azure Event Hub Metric creation is out-of-date or not accurate. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#28622 **Testing:** <Describe what testing was performed and which tests were added.> No code was modified, only documentation. **Documentation:** <Describe the documentation added.> Updated the README.md in reciever/azureeventhub to be more accurate and improved the Metric mapping table to be consistent with the Log section.
…lemetry#28634) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Allow the Consumer Group to be set in the Configuration. **Link to tracking Issue:** <Issue number if applicable> [open-telemetry#28633] **Testing:** <Describe what testing was performed and which tests were added.> Locally tested and verified. No unit testing added. **Documentation:** <Describe the documentation added.> New configuration option added to README.
open-telemetry#28637) Fixed a typo in README.md, in the example: **Before:** traces/in: receivers: [_**oltp**_] exporters: [routing] **After:** traces/in: receivers: [_**otlp**_] exporters: [routing]
songy23
requested review from
mx-psi,
gbbr,
dineshg13,
liustanley and
mackjmr
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.