[chore][pkg/stanza] Allow trie to store a value #28592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Oct 25, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
This PR enhances the internal `trie` struct (which is not yet in use anywhere in the codebase) such that a node may contain any value. The motivation for this is that I believe we may soon be able to migrate `knownFiles` and `previousPollFiles` to tries, which will prove out the functionality of the trie and also should improve efficiency of the package overall.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
This PR enhances the internal `trie` struct (which is not yet in use anywhere in the codebase) such that a node may contain any value. The motivation for this is that I believe we may soon be able to migrate `knownFiles` and `previousPollFiles` to tries, which will prove out the functionality of the trie and also should improve efficiency of the package overall.
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
This PR enhances the internal `trie` struct (which is not yet in use anywhere in the codebase) such that a node may contain any value. The motivation for this is that I believe we may soon be able to migrate `knownFiles` and `previousPollFiles` to tries, which will prove out the functionality of the trie and also should improve efficiency of the package overall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the internal
triestruct (which is not yet in use anywhere in the codebase) such that a node may contain any value.The motivation for this is that I believe we may soon be able to migrate
knownFilesandpreviousPollFilesto tries, which will prove out the functionality of the trie and also should improve efficiency of the package overall.