Add jmx_url to config spec #6230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreYang
commented
Apr 2, 2020
| @@ -10,6 +10,11 @@ | |||
| value: | |||
| type: integer | |||
|
|
|||
| - name: jmx_url | |||
| description: JMX URL to connect to. Can be used instead of host/port configs. | |||
| value: | |||
There was a problem hiding this comment.
Shall we mark this as hidden: true since it's not needed for most integrations ?
There was a problem hiding this comment.
Is still a valid alternative, right?
There was a problem hiding this comment.
@hithwen Yes, for Jboss Wildfly, because it uses another protocol.
There was a problem hiding this comment.
But I'm hiding it by default because most of the integrations only need host/port.
Codecov Report
|
4 tasks
FlorianVeaux
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add jmx_url to config spec
Default to 'hidden' since most integrations use host/port and don't need jmx_url.
Motivation
Will be used for #6225
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached