-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jmx_url to config spec #6230
Conversation
@@ -10,6 +10,11 @@ | |||
value: | |||
type: integer | |||
|
|||
- name: jmx_url | |||
description: JMX URL to connect to. Can be used instead of host/port configs. | |||
value: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we mark this as hidden: true
since it's not needed for most integrations ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is still a valid alternative, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hithwen Yes, for Jboss Wildfly, because it uses another protocol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I'm hiding it by default because most of the integrations only need host/port.
Codecov Report
|
What does this PR do?
Add jmx_url to config spec
Default to 'hidden' since most integrations use host/port and don't need jmx_url.
Motivation
Will be used for #6225
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached