Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jmx_url to config spec #6230

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Add jmx_url to config spec #6230

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04cfe45
Add jmx_url to config spec
AlexandreYang Apr 1, 2020
761283a
revert jboss spec
AlexandreYang Apr 2, 2020
b890222
mark as hidden
AlexandreYang Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/jmx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
value:
type: integer

- name: jmx_url
description: JMX URL to connect to. Can be used instead of host/port configs.
hidden: true
value:
Copy link
Member Author

@AlexandreYang AlexandreYang Apr 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we mark this as hidden: true since it's not needed for most integrations ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is still a valid alternative, right?

Copy link
Member Author

@AlexandreYang AlexandreYang Apr 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hithwen Yes, for Jboss Wildfly, because it uses another protocol.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'm hiding it by default because most of the integrations only need host/port.

type: string

- name: user
description: User to use when connecting to JMX.
value:
Expand Down