-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix service check name and add config spec #6225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreYang
commented
Apr 1, 2020
Codecov Report
|
This was referenced Apr 2, 2020
AlexandreYang
force-pushed
the
alex/jboss_fix_service_check
branch
from
April 2, 2020 11:04
f2aee69
to
0844973
Compare
4 tasks
AlexandreYang
force-pushed
the
alex/jboss_fix_service_check
branch
2 times, most recently
from
April 2, 2020 12:40
c67e1c0
to
c22c0e0
Compare
AlexandreYang
force-pushed
the
alex/jboss_fix_service_check
branch
from
April 2, 2020 13:10
86767cf
to
125c2ed
Compare
AlexandreYang
changed the title
Fix service check name
Fix service check name and add config spec
Apr 2, 2020
AlexandreYang
commented
Apr 2, 2020
AlexandreYang
added
changelog/Added
and removed
changelog/no-changelog
changelog/Fixed
labels
Apr 2, 2020
ofek
approved these changes
Apr 2, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on:
What does this PR do?
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached