Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service check name and add config spec #6225

Merged
merged 7 commits into from
Apr 2, 2020
Merged

Fix service check name and add config spec #6225

merged 7 commits into from
Apr 2, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Apr 1, 2020 •
edited
Loading

Depend on:

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Apr 2, 2020 •
edited
Loading

Codecov Report

Merging #6225 into master will decrease coverage by 41.06%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
jboss_wildfly/tests/test_check.py 30.00% <0.00%> (-7.50%) ⬇️
...hecks_base/datadog_checks/base/utils/containers.py
dns_check/tests/test_dns_check.py
ibm_mq/datadog_checks/ibm_mq/__init__.py
aspdotnet/datadog_checks/aspdotnet/__init__.py
gearmand/datadog_checks/gearmand/__about__.py
mapr/datadog_checks/mapr/__about__.py
http_check/datadog_checks/http_check/config.py
mapreduce/tests/test_mapreduce_integration_e2e.py
presto/datadog_checks/presto/__init__.py
... and 827 more

This was referenced Apr 2, 2020
Merged
Merged
@AlexandreYang AlexandreYang mentioned this pull request Apr 2, 2020
Closed
4 tasks
@AlexandreYang AlexandreYang force-pushed the alex/jboss_fix_service_check branch 2 times, most recently from c67e1c0 to c22c0e0 Compare April 2, 2020 12:40
@AlexandreYang AlexandreYang marked this pull request as ready for review April 2, 2020 13:58
@AlexandreYang AlexandreYang requested review from a team as code owners April 2, 2020 13:58
@AlexandreYang AlexandreYang changed the title Fix service check name Fix service check name and add config spec Apr 2, 2020
@AlexandreYang AlexandreYang merged commit 73b3130 into master Apr 2, 2020
@AlexandreYang AlexandreYang deleted the alex/jboss_fix_service_check branch April 2, 2020 15:14
@ChristineTChen ChristineTChen mentioned this pull request Oct 16, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
documentation integration/jboss_wildfly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandreYang @ofek