Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metric validation #5581

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Fix metric validation #5581

merged 2 commits into from
Jan 29, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jan 29, 2020

@ofek ofek requested a review from a team as a code owner January 29, 2020 01:51
@ofek ofek mentioned this pull request Jan 29, 2020
Merged
6 tasks
@codecov
Copy link

codecov bot commented Jan 29, 2020 •
edited
Loading

Codecov Report

Merging #5581 into master will decrease coverage by 3.26%.
The diff coverage is n/a.

Impacted Files Coverage Δ
vertica/tests/metrics.py
oracle/tests/test_oracle.py
twistlock/datadog_checks/twistlock/twistlock.py
linkerd/datadog_checks/linkerd/linkerd.py
istio/tests/test_e2e.py
gitlab_runner/tests/test_integration.py
btrfs/tests/test_btrfs.py
...nmetrics/datadog_checks/openmetrics/openmetrics.py
linkerd/datadog_checks/linkerd/metrics.py
datadog_checks_base/tests/test_warnings_util.py
... and 820 more

@ofek ofek requested a review from a team as a code owner January 29, 2020 04:44
AlexandreYang
AlexandreYang reviewed Jan 29, 2020
View reviewed changes
datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/metadata.py
@@ -17,7 +17,7 @@

ALL_HEADERS = REQUIRED_HEADERS | OPTIONAL_HEADERS

VALID_METRIC_TYPE = {'count', 'counter', 'distribution', 'gauge', 'rate'}
VALID_METRIC_TYPE = {'count', 'gauge', 'rate'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ofek ofek merged commit bddb78e into master Jan 29, 2020
@ofek ofek deleted the ofek-patch-1 branch January 29, 2020 14:26
AlexandreYang pushed a commit that referenced this pull request Jan 30, 2020
@ofek @AlexandreYang
Fix metric validation (#5581)
7e5ed44 
* Fix metric validation

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreYang AlexandreYang AlexandreYang approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/crio integration/datadog_checks_dev integration/gitlab_runner integration/gitlab integration/kube_metrics_server integration/kube_scheduler integration/kubernetes_state integration/nginx_ingress_controller
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofek @AlexandreYang