Fix metric validation (#5581)

* Fix metric validation

* fix

crio/metadata.csv

@@ -1,5 +1,5 @@
 metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name
-crio.operations.count,counter,,,,Counter of CRI-O operations ,0,cri-o,ops count
+crio.operations.count,count,,,,Counter of CRI-O operations ,0,cri-o,ops count
 crio.operations.latency.sum,gauge,,microsecond,,Sum of CRI-O operations latency,0,cri-o,ops time sum
 crio.operations.latency.count,gauge,,,,Count of CRI-O operations latency,0,cri-o,ops time count
 crio.operations.latency.quantile,gauge,,,,Quantiles of CRI-O operations latency,0,cri-o,ops time quantile

datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/metadata.py

@@ -17,7 +17,7 @@
 
 ALL_HEADERS = REQUIRED_HEADERS | OPTIONAL_HEADERS
 
-VALID_METRIC_TYPE = {'count', 'counter', 'distribution', 'gauge', 'rate'}
+VALID_METRIC_TYPE = {'count', 'gauge', 'rate'}
 
 VALID_ORIENTATION = {'0', '1', '-1'}
 

gitlab_runner/metadata.csv

@@ -4,7 +4,7 @@ gitlab_runner.ci_docker_machines_provider_machine_creation_duration_seconds_sum,
 gitlab_runner.ci_docker_machines_provider_machine_creation_duration_seconds_count,gauge,,request,second,Count of Docker machine creation time. Applies to GitLab Runner < 1.11.0,0,gitlab_runner,count docker machine creation time
 gitlab_runner.ci_docker_machines_provider_machine_states,gauge,,request,second,The current number of machines per state in this provider. Applies to GitLab Runner < 1.11.0,0,gitlab_runner,total docker machines per state
 gitlab_runner.ci_runner_builds,gauge,,,,The current number of running builds. Applies to GitLab Runner < 1.11.0,0,gitlab_runner,current running builds
-gitlab_runner.ci_runner_errors,counter,,request,second,The number of caught errors. Applies to GitLab Runner < 1.11.0,0,gitlab_runner,errors
+gitlab_runner.ci_runner_errors,count,,request,second,The number of caught errors. Applies to GitLab Runner < 1.11.0,0,gitlab_runner,errors
 gitlab_runner.ci_runner_version_info,gauge,,request,,A metric with a constant '1' value labeled by different build stats fields. Applies to GitLab Runner < 1.11.0,0,gitlab_runner,version info
 gitlab_runner.ci_ssh_docker_machines_provider_machine_creation_duration_seconds_bucket,gauge,,request,second,Histogram of SSH Docker machine creation time. Applies to GitLab Runner < 1.11.0,0,gitlab_runner,ssh docker machine creation time
 gitlab_runner.ci_ssh_docker_machines_provider_machine_creation_duration_seconds_sum,gauge,,request,second,Sum of SSH Docker machine creation time. Applies to GitLab Runner < 1.11.0,0,gitlab_runner,sum ssh docker machine creation time
@@ -13,26 +13,26 @@ gitlab_runner.ci_ssh_docker_machines_provider_machine_states,gauge,,request,seco
 gitlab_runner.gitlab_runner_autoscaling_machine_creation_duration_seconds,gauge,,request,second,Histogram of Docker machine creation time. Applies to GitLab Runner 1.11.0+,0,gitlab_runner,docker machine creation time
 gitlab_runner.gitlab_runner_autoscaling_machine_states,gauge,,request,second,The current number of machines per state in this provider. Applies to GitLab Runner 1.11.0+,0,gitlab_runner,total docker machines per state
 gitlab_runner.gitlab_runner_jobs,gauge,,,,The current number of running builds. Applies to GitLab Runner 1.11.0+,0,gitlab_runner,current running builds
-gitlab_runner.gitlab_runner_errors_total,counter,,request,second,The number of caught errors. Applies to GitLab Runner 1.11.0+,0,gitlab_runner,errors
+gitlab_runner.gitlab_runner_errors_total,count,,request,second,The number of caught errors. Applies to GitLab Runner 1.11.0+,0,gitlab_runner,errors
 gitlab_runner.gitlab_runner_version_info,gauge,,request,,A metric with a constant '1' value labeled by different build stats fields. Applies to GitLab Runner 1.11.0+,0,gitlab_runner,version info
 gitlab_runner.go_gc_duration_seconds,gauge,,request,second,A summary of the GC invocation durations,0,gitlab_runner,gc duration
 gitlab_runner.go_gc_duration_seconds_sum,gauge,,request,second,Sum of the GC invocation durations,0,gitlab_runner,sum gc duration
 gitlab_runner.go_gc_duration_seconds_count,gauge,,request,second,Count of the GC invocation durations,0,gitlab_runner,count gc duration
 gitlab_runner.go_goroutines,gauge,,request,second,Number of goroutines that currently exist,0,gitlab_runner,goroutines
 gitlab_runner.go_memstats_alloc_bytes,gauge,,byte,,Number of bytes allocated and still in use,0,gitlab_runner,bytes allocated in use
-gitlab_runner.go_memstats_alloc_bytes_total,counter,,byte,,Total number of bytes allocated,0,gitlab_runner,bytes allocated
+gitlab_runner.go_memstats_alloc_bytes_total,count,,byte,,Total number of bytes allocated,0,gitlab_runner,bytes allocated
 gitlab_runner.go_memstats_buck_hash_sys_bytes,gauge,,byte,,Number of bytes used by the profiling bucket hash table,0,gitlab_runner,bytes profiling bucket
-gitlab_runner.go_memstats_frees_total,counter,,request,,Total number of frees,0,gitlab_runner,number of frees
+gitlab_runner.go_memstats_frees_total,count,,request,,Total number of frees,0,gitlab_runner,number of frees
 gitlab_runner.go_memstats_gc_sys_bytes,gauge,,byte,,Number of bytes used for garbage collection system metadata,0,gitlab_runner,bytes garbage collection
 gitlab_runner.go_memstats_heap_alloc_bytes,gauge,,byte,,Number of heap bytes allocated and still in use,0,gitlab_runner,heap bytes allocated and in use
 gitlab_runner.go_memstats_heap_idle_bytes,gauge,,byte,,Number of heap bytes waiting to be used,0,gitlab_runner,heap bytes unused
 gitlab_runner.go_memstats_heap_inuse_bytes,gauge,,byte,,Number of heap bytes that are in use,0,gitlab_runner,heap bytes in use
 gitlab_runner.go_memstats_heap_objects,gauge,,request,,Number of allocated objects,0,gitlab_runner,allocated objects
-gitlab_runner.go_memstats_heap_released_bytes_total,counter,,byte,,Total number of heap bytes released to OS,0,gitlab_runner,heap bytes released
+gitlab_runner.go_memstats_heap_released_bytes_total,count,,byte,,Total number of heap bytes released to OS,0,gitlab_runner,heap bytes released
 gitlab_runner.go_memstats_heap_sys_bytes,gauge,,byte,,Number of heap bytes obtained from system,0,gitlab_runner,heap bytes obtained
 gitlab_runner.go_memstats_last_gc_time_seconds,gauge,,request,,Number of seconds since 1970 of last garbage collection,0,gitlab_runner,epoch since last gc
-gitlab_runner.go_memstats_lookups_total,counter,,request,,Total number of pointer lookups,0,gitlab_runner,pointer lookups
-gitlab_runner.go_memstats_mallocs_total,counter,,request,,Total number of mallocs,0,gitlab_runner,number of mallocs
+gitlab_runner.go_memstats_lookups_total,count,,request,,Total number of pointer lookups,0,gitlab_runner,pointer lookups
+gitlab_runner.go_memstats_mallocs_total,count,,request,,Total number of mallocs,0,gitlab_runner,number of mallocs
 gitlab_runner.go_memstats_mcache_inuse_bytes,gauge,,byte,,Number of bytes in use by mcache structures,0,gitlab_runner,mcache bytes used
 gitlab_runner.go_memstats_mcache_sys_bytes,gauge,,byte,,Number of bytes used for mcache structures obtained from system,0,gitlab_runner,mcache bytes from sys
 gitlab_runner.go_memstats_mspan_inuse_bytes,gauge,,byte,,Number of bytes in use by mspan structures,0,gitlab_runner,mspan bytes used
@@ -42,7 +42,7 @@ gitlab_runner.go_memstats_other_sys_bytes,gauge,,byte,,Number of bytes used for
 gitlab_runner.go_memstats_stack_inuse_bytes,gauge,,byte,,Number of bytes in use by the stack allocator,0,gitlab_runner,bytes stack allocator
 gitlab_runner.go_memstats_stack_sys_bytes,gauge,,byte,,Number of bytes obtained from system for stack allocator,0,gitlab_runner,bytes stack allocator from sys
 gitlab_runner.go_memstats_sys_bytes,gauge,,byte,,Number of bytes obtained by system. Sum of all system allocations,0,gitlab_runner,sum system allocations
-gitlab_runner.process_cpu_seconds_total,counter,,request,second,Total user and system CPU time spent in seconds,0,gitlab_runner,user and system cpu time
+gitlab_runner.process_cpu_seconds_total,count,,request,second,Total user and system CPU time spent in seconds,0,gitlab_runner,user and system cpu time
 gitlab_runner.process_max_fds,gauge,,request,,Maximum number of open file descriptors,0,gitlab_runner,max fds
 gitlab_runner.process_open_fds,gauge,,request,,Number of open file descriptors,0,gitlab_runner,open fds
 gitlab_runner.process_resident_memory_bytes,gauge,,byte,,Resident memory size in bytes,0,gitlab_runner,rss bytes

kube_metrics_server/metadata.csv

@@ -1,17 +1,17 @@
 metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name
-kube_metrics_server.authenticated_user.requests,counter,,,,"Counter of authenticated requests broken out by username",0,kube_metrics_server,authenticated_user.requests
+kube_metrics_server.authenticated_user.requests,count,,,,"Counter of authenticated requests broken out by username",0,kube_metrics_server,authenticated_user.requests
 kube_metrics_server.go.gc_duration_seconds.quantile,gauge,,,,"GC invocation durations quantiles",0,kube_metrics_server,go.gc_duration_seconds.quantile
 kube_metrics_server.go.gc_duration_seconds.sum,gauge,,,,"GC invocation durations sum",0,kube_metrics_server,go.gc_duration_seconds.sum
 kube_metrics_server.go.gc_duration_seconds.count,gauge,,,,"Number of the GC invocation",0,kube_metrics_server,go.gc_duration_seconds.count
 kube_metrics_server.go.goroutines,gauge,,,,"Number of goroutines that currently exist",0,kube_metrics_server,go.goroutines
 kube_metrics_server.kubelet_summary_request_duration.count,gauge,,,,"Number of Kubelet summary request",0,kube_metrics_server,kubelet_summary_request_duration.count
 kube_metrics_server.kubelet_summary_request_duration.sum,gauge,,,second,"The Kubelet summary request latencies sum",0,kube_metrics_server,kubelet_summary_request_duration.sum
-kube_metrics_server.kubelet_summary_scrapes_total,counter,,,,"Total number of attempted Summary API scrapes done by Metrics Server",0,kube_metrics_server,kubelet_summary_scrapes_total
+kube_metrics_server.kubelet_summary_scrapes_total,count,,,,"Total number of attempted Summary API scrapes done by Metrics Server",0,kube_metrics_server,kubelet_summary_scrapes_total
 kube_metrics_server.manager_tick_duration.count,gauge,,,,"The total time spent collecting and storing metrics",0,kube_metrics_server,manager_tick_duration.count
 kube_metrics_server.manager_tick_duration.sum,gauge,,,second,"The total time spent collecting and storing metrics",0,kube_metrics_server,manager_tick_duration.sum
 kube_metrics_server.scraper_duration.count,gauge,,,,"Time spent scraping sources",0,kube_metrics_server,scraper_duration.count
 kube_metrics_server.scraper_duration.sum,gauge,,,second,"Time spent scraping sources",0,kube_metrics_server,scraper_duration.sum
 kube_metrics_server.scraper_last_time,gauge,,,second,"Last time metrics-server performed a scrape since unix epoch",0,kube_metrics_server,scraper_last_time
-kube_metrics_server.process.cpu_seconds_total,counter,,,second,"Total user and system CPU time spent",0,kube_metrics_server,process.cpu_seconds_total
+kube_metrics_server.process.cpu_seconds_total,count,,,second,"Total user and system CPU time spent",0,kube_metrics_server,process.cpu_seconds_total
 kube_metrics_server.process.max_fds,gauge,,,,"Maximum number of open file descriptors",0,kube_metrics_server,process.max_fds
 kube_metrics_server.process.open_fds,gauge,,,,"Number of open file descriptors",0,kube_metrics_server,process.open_fds

kube_scheduler/metadata.csv

@@ -12,7 +12,7 @@ kube_scheduler.goroutines,gauge,,,,"Number of goroutines that currently exist",0
 kube_scheduler.max_fds,gauge,,,,Maximum allowed open file descriptors,0,kube_scheduler,max_fds
 kube_scheduler.open_fds,gauge,,,,Number of open file descriptors,0,kube_scheduler,open_fds
 kube_scheduler.pod_preemption.victims,gauge,,,,"Number of selected pods during the latest preemption round",0,kube_scheduler,pod_preemption.victims
-kube_scheduler.pod_preemption.attempts,counter,,,,"Number of preemption attempts in the cluster till now",0,kube_scheduler,pod_preemption.attempts
+kube_scheduler.pod_preemption.attempts,count,,,,"Number of preemption attempts in the cluster till now",0,kube_scheduler,pod_preemption.attempts
 kube_scheduler.schedule_attempts,gauge,,,,"Number of attempts to schedule pods, by the result. 'unschedulable' means a pod could not be scheduled, while 'error' means an internal scheduler problem.",0,kube_scheduler,schedule_attempts
 kube_scheduler.scheduling.algorithm_duration.count,gauge,,,,"Number of scheduling algorithm latency",0,kube_scheduler,scheduling.algorithm_duration.count
 kube_scheduler.scheduling.algorithm_duration.sum,gauge,,,second,"Total scheduling algorithm latency",0,kube_scheduler,scheduling.algorithm_duration.sum

kubernetes_state/metadata.csv

@@ -27,8 +27,8 @@ kubernetes_state.deployment.rollingupdate.max_unavailable,gauge,,,,Maximum numbe
 kubernetes_state.endpoint.address_available,gauge,,,,Number of addresses available in endpoint,0,kubernetes,k8s_state.endpoint.address_avail
 kubernetes_state.endpoint.address_not_ready,gauge,,,,Number of addresses not ready in endpoint,-1,kubernetes,k8s_state.endpoint.address_not_ready
 kubernetes_state.endpoint.created,gauge,,,,Unix creation timestamp,0,kubernetes,k8s_state.endpoint.creation_time
-kubernetes_state.job.status.failed,counter,,,,Observed number of failed pods in a job,0,kubernetes,k8s_state.job.failed
-kubernetes_state.job.status.succeeded,counter,,,,Observed number of succeeded pods in a job,0,kubernetes,k8s_state.job.succeeded
+kubernetes_state.job.status.failed,count,,,,Observed number of failed pods in a job,0,kubernetes,k8s_state.job.failed
+kubernetes_state.job.status.succeeded,count,,,,Observed number of succeeded pods in a job,0,kubernetes,k8s_state.job.succeeded
 kubernetes_state.limitrange.cpu.min,gauge,,,,Minimum CPU request for this type,0,kubernetes,k8s_state.cpu.min
 kubernetes_state.limitrange.cpu.max,gauge,,,,Maximum CPU limit for this type,0,kubernetes,k8s_state.cpu.max
 kubernetes_state.limitrange.cpu.default,gauge,,,,Default CPU limit if not specified,0,kubernetes,k8s_state.cpu.default
@@ -39,7 +39,7 @@ kubernetes_state.limitrange.memory.max,gauge,,,,Maximum memory limit for this ty
 kubernetes_state.limitrange.memory.default,gauge,,,,Default memory limit if not specified,0,kubernetes,k8s_state.mem.default
 kubernetes_state.limitrange.memory.default_request,gauge,,,,Default memory request if not specified,0,kubernetes,k8s_state.mem.default_request
 kubernetes_state.limitrange.memory.max_limit_request_ratio,gauge,,,,Maximum memory limit / request ratio,0,kubernetes,k8s_state.mem.max_ratio
-kubernetes_state.node.count,counter,60,node,,The number of nodes,0,kubernetes,k8s_state.node.count
+kubernetes_state.node.count,count,60,node,,The number of nodes,0,kubernetes,k8s_state.node.count
 kubernetes_state.node.cpu_capacity,gauge,,cpu,,The total CPU resources of the node,0,kubernetes,k8s_state.node.cpu_capacity
 kubernetes_state.node.memory_capacity,gauge,,byte,,The total memory resources of the node,0,kubernetes,k8s_state.node.memory_capacity
 kubernetes_state.node.pods_capacity,gauge,,,,The total pod resources of the node,0,kubernetes,k8s_state.node.pods_capacity
@@ -100,11 +100,11 @@ kubernetes_state.statefulset.replicas_current,gauge,,,,The number of current rep
 kubernetes_state.statefulset.replicas_ready,gauge,,,,The number of ready replicas per StatefulSet,0,kubernetes,k8s_state.statefulset.replicas_ready
 kubernetes_state.statefulset.replicas_updated,gauge,,,,The number of updated replicas per StatefulSet,0,kubernetes,k8s_state.statefulset.replicas_updated
 kubernetes_state.telemetry.payload.size,gauge,,byte,,The message size received from kube-state-metrics,0,kubernetes,k8s_state.telemetry.payload.size
-kubernetes_state.telemetry.metrics.processed.count,counter,,,,The number of metrics processed,0,kubernetes,k8s_state.telemetry.metrics.processed.count
-kubernetes_state.telemetry.metrics.input.count,counter,,,,The number of metrics received,0,kubernetes,k8s_state.telemetry.metrics.input.count
-kubernetes_state.telemetry.metrics.blacklist.count,counter,,,,The number of metrics blacklisted by the check,0,kubernetes,k8s_state.telemetry.metrics.blacklist.count
-kubernetes_state.telemetry.metrics.ignored.count,counter,,,,The number of metrics ignored by the check,0,kubernetes,k8s_state.telemetry.metrics.ignored.count
-kubernetes_state.telemetry.collector.metrics.count,counter,,,,The number of metrics by collector (kubernetes object kind) by kubernetes namespaces,0,kubernetes,k8s_state.telemetry.collector.metrics.count
+kubernetes_state.telemetry.metrics.processed.count,count,,,,The number of metrics processed,0,kubernetes,k8s_state.telemetry.metrics.processed.count
+kubernetes_state.telemetry.metrics.input.count,count,,,,The number of metrics received,0,kubernetes,k8s_state.telemetry.metrics.input.count
+kubernetes_state.telemetry.metrics.blacklist.count,count,,,,The number of metrics blacklisted by the check,0,kubernetes,k8s_state.telemetry.metrics.blacklist.count
+kubernetes_state.telemetry.metrics.ignored.count,count,,,,The number of metrics ignored by the check,0,kubernetes,k8s_state.telemetry.metrics.ignored.count
+kubernetes_state.telemetry.collector.metrics.count,count,,,,The number of metrics by collector (kubernetes object kind) by kubernetes namespaces,0,kubernetes,k8s_state.telemetry.collector.metrics.count
 kubernetes_state.vpa.lower_bound,gauge,,,,The vpa lower bound recommendation,0,kubernetes,k8s_state.vpa.lower_bound
 kubernetes_state.vpa.target,gauge,,,,The vpa target recommendation,0,kubernetes,k8s_state.vpa.target
 kubernetes_state.vpa.uncapped_target,gauge,,,,The vpa uncapped recommendation recommendation,0,kubernetes,k8s_state.vpa.uncapped_target