Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scylla new integration #5440

Merged
merged 37 commits into from
Feb 4, 2020
Merged

Scylla new integration #5440

merged 37 commits into from
Feb 4, 2020

Conversation

mgarabed
Copy link
Member

@mgarabed mgarabed commented Jan 10, 2020 •
edited
Loading

What does this PR do?

Add new integration Scylla.

Motivation

To expand integration coverage.

Additional Notes

TODO (in separate PRs):

  • Logs documentation
  • Metadata collection Done
  • Dashboard integration

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@codecov
Copy link

codecov bot commented Jan 16, 2020 •
edited
Loading

Codecov Report

Merging #5440 into master will increase coverage by 9.32%.
The diff coverage is 96.35%.

Impacted Files Coverage Δ
scylla/tests/test_scylla.py 100% <100%> (ø)
scylla/tests/conftest.py 100% <100%> (ø)
scylla/datadog_checks/scylla/metrics.py 100% <100%> (ø)
scylla/datadog_checks/scylla/__about__.py 100% <100%> (ø)
scylla/datadog_checks/scylla/scylla.py 100% <100%> (ø)
scylla/datadog_checks/scylla/__init__.py 100% <100%> (ø)
scylla/tests/common.py 100% <100%> (ø)
scylla/tests/test_e2e.py 44.44% <44.44%> (ø)
vertica/tests/metrics.py
...checks_dev/tests/plugin/test_environment_runner.py
... and 1014 more

ofek
ofek requested changes Jan 28, 2020
View reviewed changes
scylla/datadog_checks/scylla/scylla.py Outdated Show resolved Hide resolved
scylla/datadog_checks/scylla/scylla.py Outdated Show resolved Hide resolved
scylla/datadog_checks/scylla/metrics.py Outdated Show resolved Hide resolved
scylla/manifest.json Outdated Show resolved Hide resolved
ofek
ofek requested changes Jan 29, 2020
View reviewed changes
scylla/datadog_checks/scylla/scylla.py Outdated Show resolved Hide resolved
scylla/metadata.csv Outdated Show resolved Hide resolved
florimondmanca
florimondmanca reviewed Jan 30, 2020
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

A couple of comments/suggestions, mostly nits. Exciting stuff!

scylla/datadog_checks/scylla/data/conf.yaml.example Outdated Show resolved Hide resolved
scylla/datadog_checks/scylla/scylla.py Outdated Show resolved Hide resolved
scylla/datadog_checks/scylla/scylla.py Outdated Show resolved Hide resolved
scylla/README.md Outdated Show resolved Hide resolved
scylla/setup.py Outdated Show resolved Hide resolved
scylla/tests/compose/docker-compose.yaml Outdated Show resolved Hide resolved
scylla/tests/test_scylla.py Outdated Show resolved Hide resolved
ofek
ofek requested changes Jan 30, 2020
View reviewed changes
scylla/datadog_checks/scylla/scylla.py Outdated Show resolved Hide resolved
scylla/datadog_checks/scylla/scylla.py Outdated Show resolved Hide resolved
scylla/manifest.json Outdated Show resolved Hide resolved
scylla/manifest.json Outdated Show resolved Hide resolved
florimondmanca
florimondmanca previously approved these changes Jan 31, 2020
View reviewed changes
ChristineTChen
ChristineTChen previously approved these changes Jan 31, 2020
View reviewed changes
FlorianVeaux
FlorianVeaux previously approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

l0k0ms
l0k0ms reviewed Feb 3, 2020
View reviewed changes
scylla/README.md Outdated Show resolved Hide resolved
l0k0ms
l0k0ms reviewed Feb 3, 2020
View reviewed changes
scylla/README.md Outdated Show resolved Hide resolved
ofek
ofek approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@mgarabed mgarabed merged commit de080b6 into master Feb 4, 2020
@mgarabed mgarabed deleted the mgarabed/scylladb branch February 4, 2020 14:16
@mgarabed
Copy link
Member Author

mgarabed commented Feb 4, 2020

Early commit for Python 3.8, those checks are expected to be failing right now.

@florimondmanca florimondmanca mentioned this pull request Feb 26, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0k0ms l0k0ms l0k0ms left review comments

@ofek ofek ofek approved these changes

@ChristineTChen ChristineTChen ChristineTChen left review comments

@florimondmanca florimondmanca florimondmanca left review comments

@FlorianVeaux FlorianVeaux FlorianVeaux left review comments

Assignees
No one assigned
Labels
dev/testing documentation integration/scylla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mgarabed @l0k0ms @ofek @ChristineTChen @florimondmanca @FlorianVeaux