Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keytab files for kerberos #2591

Merged
merged 2 commits into from
Nov 15, 2018
Merged

Support keytab files for kerberos #2591

merged 2 commits into from
Nov 15, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Nov 15, 2018

Motivation

Customer request

Notes

keytab option doesn't exist in any wrapper libs. env var getting used directly by C lib https://web.mit.edu/kerberos/krb5-1.11

Add support for a "default client keytab". Its location is determined by the KRB5_CLIENT_KTNAME environment variable, the default_client_keytab profile relation, or a hardcoded path (TBD).

@codecov-io
Copy link

Codecov Report

Merging #2591 into master will decrease coverage by 3.61%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2591      +/-   ##
==========================================
- Coverage   83.88%   80.27%   -3.62%     
==========================================
  Files         644        6     -638     
  Lines       36406      147   -36259     
  Branches     4421       17    -4404     
==========================================
- Hits        30540      118   -30422     
+ Misses       4552       20    -4532     
+ Partials     1314        9    -1305

Copy link
Collaborator

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ofek ofek merged commit 6006452 into master Nov 15, 2018
@ofek ofek deleted the ofek/hdfs branch November 15, 2018 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants