Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kerberos auth #2823

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Support Kerberos auth #2823

merged 1 commit into from
Jan 7, 2019

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Dec 25, 2018

What does this PR do?

Copies these:

#2516
#2591

Motivation

Customer requests

@codecov-io
Copy link

codecov-io commented Dec 25, 2018

Codecov Report

Merging #2823 into master will decrease coverage by 4.59%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2823      +/-   ##
==========================================
- Coverage   84.83%   80.23%    -4.6%     
==========================================
  Files         648        6     -642     
  Lines       36078      172   -35906     
  Branches     4300       24    -4276     
==========================================
- Hits        30605      138   -30467     
+ Misses       4208       21    -4187     
+ Partials     1265       13    -1252

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! How are we testing this?

@ofek
Copy link
Contributor Author

ofek commented Dec 26, 2018

@gzussa Customer is testing

gzussa
gzussa previously approved these changes Dec 29, 2018
@ofek
Copy link
Contributor Author

ofek commented Jan 7, 2019

Working now

@ofek ofek merged commit 215f5cc into master Jan 7, 2019
@ofek ofek deleted the ofek/hdn branch January 7, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants