Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kerberos auth #2825

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Support Kerberos auth #2825

merged 1 commit into from
Jan 7, 2019

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Dec 25, 2018

What does this PR do?

Copies these:

#2516
#2591

Motivation

Customer requests

@codecov-io
Copy link

codecov-io commented Dec 25, 2018

Codecov Report

Merging #2825 into master will increase coverage by 3.97%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #2825      +/-   ##
==========================================
+ Coverage   84.67%   88.64%   +3.97%     
==========================================
  Files         655        4     -651     
  Lines       37465      784   -36681     
  Branches     4493      147    -4346     
==========================================
- Hits        31724      695   -31029     
+ Misses       4426       46    -4380     
+ Partials     1315       43    -1272

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work again! How should we test this?

@ofek
Copy link
Contributor Author

ofek commented Dec 26, 2018

@gzussa Customer is testing

@ofek
Copy link
Contributor Author

ofek commented Jan 7, 2019

Kerberos is working

@ofek ofek merged commit 8773ad0 into master Jan 7, 2019
@ofek ofek deleted the ofek/sp branch January 7, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants