-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Python win32_event_log check implementation #16108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
clarkb7
force-pushed
the
branden.clark/event-log-skip-new
branch
from
November 8, 2023 00:47
5c69cff
to
82279e9
Compare
clarkb7
changed the title
Skip newer win32_event_log configurations
Deprecate Python win32_event_log check implementation
Nov 8, 2023
10 tasks
iglendd
approved these changes
Nov 8, 2023
FlorentClarret
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecate the Python win32_event_log implementation, add
legacy_mode_v2
option to enable using it if necessary.See DataDog/datadog-agent#20701 for the new check implementation
Motivation
Part of effort to consolidate the event log collection implementations.
https://datadoghq.atlassian.net/browse/WINA-519
Additional Notes
The Python WMI implementation (
legacy_mode: true
) is still the default for backwards compatibility purposes. Thuslegacy_mode: false
must still be set (see #15907).WMI implementation:
legacy_mode: true
explicitly setPython Event Log implementation
legacy_mode_v2: true
explicitly set (it is not necessary to also explicitly setlegacy_mode: false
)Go Event Log implementation
legacy_mode: false
explicitly setReview checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.