Add legacy_mode option to init_config
#15907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
julien-lebot
requested changes
Sep 26, 2023
win32_event_log/datadog_checks/win32_event_log/data/conf.yaml.example
Outdated
Show resolved
Hide resolved
julien-lebot
previously approved these changes
Sep 26, 2023
clarkb7
force-pushed
the
branden.clark/event-log-legacy-mode-init-config
branch
from
9009665
to
59786df
Compare
ofek
requested changes
Sep 26, 2023
clarkb7
force-pushed
the
branden.clark/event-log-legacy-mode-init-config
branch
from
807ad61
to
89bcaec
Compare
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
drichards-87
previously approved these changes
Sep 26, 2023
Co-authored-by: DeForest Richards <[email protected]>
drichards-87
approved these changes
Sep 26, 2023
ofek
approved these changes
Sep 27, 2023
julien-lebot
approved these changes
Sep 27, 2023
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the
legacy_modeoption to the sharedinit_configconfiguration section.Enable
legacy_mode: falseininit_configin the config example by default.Motivation
Set the option once in
init_configrather than setting the option in every single instance.https://datadoghq.atlassian.net/browse/WINA-265
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.