-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add legacy_mode
option to init_config
#15907
Add legacy_mode
option to init_config
#15907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
win32_event_log/datadog_checks/win32_event_log/data/conf.yaml.example
Outdated
Show resolved
Hide resolved
9009665
to
59786df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is now at the shared config level, can you please use the actual proper default for the instance option since it is now commented out?
807ad61
to
89bcaec
Compare
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left you a suggestion from Docs and approved the PR.
Co-authored-by: DeForest Richards <[email protected]>
What does this PR do?
Add the
legacy_mode
option to the sharedinit_config
configuration section.Enable
legacy_mode: false
ininit_config
in the config example by default.Motivation
Set the option once in
init_config
rather than setting the option in every single instance.https://datadoghq.atlassian.net/browse/WINA-265
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.