Add exception to skip instance configurations #16012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkb7
added
changelog/no-changelog
qa/skip-qa
ghost
added
10 tasks
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
clarkb7
force-pushed
the
branden.clark/skip-check-instance
branch
from
4d543a5
to
c827ef7
Compare
clarkb7
force-pushed
the
branden.clark/skip-check-instance
branch
from
c827ef7
to
1937415
Compare
clarkb7
force-pushed
the
branden.clark/skip-check-instance
branch
from
1937415
to
ee8fcab
Compare
clarkb7
changed the title
FlorentClarret
previously approved these changes
Oct 30, 2023
julien-lebot
previously approved these changes
Oct 30, 2023
FlorentClarret
dismissed stale reviews from julien-lebot and themself
via
49189c6
FlorentClarret
previously approved these changes
Nov 6, 2023
…idate ci` command
FlorentClarret
force-pushed
the
branden.clark/skip-check-instance
branch
from
49189c6
to
9fb0594
Compare
FlorentClarret
approved these changes
Nov 6, 2023
3 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
* Add exception for skipping instance configurations * Do not validate the codecov file in marketplace when running the `validate ci` command --------- Co-authored-by: Florent Clarret <[email protected]> 3b5473e
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new
SkipInstanceErrorexception to be raised by a check to indicate it wants to skip the provided configuration. Used in the win32_event_log check #16108 to switch between the Python and Go versions of the check based on the check configuration version.See related agent PR DataDog/datadog-agent#20114
Motivation
To enable using the Go check as the new default implementation, and require setting a configuration option to use the previous version.
https://datadoghq.atlassian.net/browse/WINA-475
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.