-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exception to skip instance configurations #16012
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
4d543a5
to
c827ef7
Compare
c827ef7
to
1937415
Compare
1937415
to
ee8fcab
Compare
49189c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a changelog, I pushed it. Looks good to me :)
…idate ci` command
49189c6
to
9fb0594
Compare
* Add exception for skipping instance configurations * Do not validate the codecov file in marketplace when running the `validate ci` command --------- Co-authored-by: Florent Clarret <[email protected]> 3b5473e
What does this PR do?
Add new
SkipInstanceError
exception to be raised by a check to indicate it wants to skip the provided configuration. Used in the win32_event_log check #16108 to switch between the Python and Go versions of the check based on the check configuration version.See related agent PR DataDog/datadog-agent#20114
Motivation
To enable using the Go check as the new default implementation, and require setting a configuration option to use the previous version.
https://datadoghq.atlassian.net/browse/WINA-475
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.