Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the max_connections metric #12689

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Add the max_connections metric #12689

merged 4 commits into from
Aug 15, 2022

Conversation

FlorentClarret
Copy link
Member

What does this PR do?

Add the max_connections metric to the mcache integration.

Motivation

Resolves #12684

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ghost ghost added the integration/mcache label Aug 5, 2022
@FlorentClarret FlorentClarret marked this pull request as ready for review August 5, 2022 09:19
@FlorentClarret FlorentClarret requested a review from a team as a code owner August 5, 2022 09:19
@codecov
Copy link

codecov bot commented Aug 5, 2022 •
edited
Loading

Codecov Report

Merging #12689 (cfefad9) into master (9410e98) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Flag Coverage Δ
mcache 93.26% <66.66%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

hithwen
hithwen previously approved these changes Aug 5, 2022
View reviewed changes
@hithwen
Copy link
Contributor

hithwen commented Aug 5, 2022

Can you add aggregator.assert_metrics_using_metadata(get_metadata_metrics() to the integration and end to end tests?

@FlorentClarret FlorentClarret mentioned this pull request Aug 5, 2022
Closed
4 tasks
@FlorentClarret FlorentClarret force-pushed the florentclarret/mcache_max_connections branch from 0359706 to cfefad9 Compare August 5, 2022 13:53
@fanny-jiang fanny-jiang merged commit 9dc0514 into master Aug 15, 2022
@fanny-jiang fanny-jiang deleted the florentclarret/mcache_max_connections branch August 15, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

@hithwen hithwen Awaiting requested review from hithwen

@jose-manuel-almaza jose-manuel-almaza Awaiting requested review from jose-manuel-almaza

Assignees
No one assigned
Labels
integration/mcache
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max_connections should be included for memcached
4 participants
@FlorentClarret @hithwen @fanny-jiang @jose-manuel-almaza