New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_connections should be included for memcached #12684

Closed

ZhenLiuInstacart opened this issue Aug 4, 2022 · 1 comment · Fixed by #12689

Assignees

ZhenLiuInstacart commented Aug 4, 2022

This should only take a minute!

Memcache config include max_connections and curr_connections.
Currently only curr_connections is included. Max_connections is important as well and we do need the ratio of curr/max to make operational decisions.
So can we add max_connections to https://github.com/DataDog/integrations-core/blob/master/mcache/datadog_checks/mcache/mcache.py#L27:L37

FlorentClarret mentioned this issue

Add the max_connections metric #12689

Merged

4 tasks

Member

FlorentClarret commented Aug 5, 2022

Hi @ZhenLiuInstacart, thanks for this issue. I opened a PR to add this metric.

hithwen assigned FlorentClarret

fanny-jiang closed this as completed in #12689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment