Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rate metrics type #12704

Closed

Conversation

FlorentClarret
Copy link
Member

What does this PR do?

Update the metadata file to declare rate metrics as rates.

Motivation

We wanted to add an extra check in the tests in the PR #12689 and it showed that the metadata.csv file was incorrect. Fixing it in a separate PR.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #12704 (d7c7a20) into master (9410e98) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
mcache 93.56% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret
Copy link
Member Author

Closing the PR as this is not a bug

@FlorentClarret FlorentClarret deleted the florentclarret/memcache_assert_metadata branch August 9, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant