Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pytest integration #1741

Merged
merged 44 commits into from
Nov 13, 2020
Merged

feat: pytest integration #1741

merged 44 commits into from
Nov 13, 2020

Conversation

jirikuncar
Copy link
Contributor

@jirikuncar jirikuncar commented Oct 20, 2020 •
edited
Loading

Description

Adds support for pytest.

Checklist

  • Entry added to release notes using reno
  • Tests provided; and/or
  • Description of manual testing performed and explanation is included in the code and/or PR.
  • Library documentation is updated.
  • Corp site documentation is updated (link to the PR).

@jirikuncar jirikuncar marked this pull request as ready for review October 20, 2020 15:56
@jirikuncar jirikuncar requested a review from a team as a code owner October 20, 2020 15:56
Kyle-Verhoog
Kyle-Verhoog reviewed Oct 21, 2020
View reviewed changes
ddtrace/contrib/pytest/__init__.py Show resolved Hide resolved
ddtrace/contrib/pytest/plugin.py Outdated Show resolved Hide resolved
ddtrace/contrib/pytest/plugin.py Outdated Show resolved Hide resolved
ddtrace/ext/provider.py Outdated Show resolved Hide resolved
tests/contrib/pytest/test_pytest.py Show resolved Hide resolved
jirikuncar
jirikuncar commented Oct 22, 2020
View reviewed changes
ddtrace/ext/provider.py Outdated Show resolved Hide resolved
jirikuncar
jirikuncar commented Oct 26, 2020
View reviewed changes
ddtrace/ext/ci.py Outdated Show resolved Hide resolved
Kyle-Verhoog
Kyle-Verhoog reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions/thoughts around the tagging. Otherwise we're looking pretty good 👍 👍

ddtrace/contrib/pytest/plugin.py Outdated Show resolved Hide resolved
ddtrace/contrib/pytest/plugin.py Show resolved Hide resolved
@knusbaum knusbaum mentioned this pull request Nov 4, 2020
Closed
Kyle-Verhoog
Kyle-Verhoog previously approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 nice! Great work @jirikuncar. I just found one thing missing from the circleci config but it's an easy fix.

.circleci/config.yml Show resolved Hide resolved
@Kyle-Verhoog Kyle-Verhoog added this to the 0.45.0 milestone Nov 13, 2020
Kyle-Verhoog
Kyle-Verhoog previously approved these changes Nov 13, 2020
View reviewed changes
@Kyle-Verhoog Kyle-Verhoog merged commit 95be7d3 into master Nov 13, 2020
@Kyle-Verhoog Kyle-Verhoog deleted the jirikuncar/pytest branch November 13, 2020 20:50
@jirikuncar jirikuncar mentioned this pull request Nov 18, 2020
Merged
@coignetp coignetp mentioned this pull request Apr 9, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

@brettlangdon brettlangdon Awaiting requested review from brettlangdon

Assignees
No one assigned
Labels
integrations
Projects
None yet
Milestone
0.45.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jirikuncar @Kyle-Verhoog