-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: contrib/testing: add an integration to support tracing tests under CI systems #772
Comments
Can we clarify a bit the difference between the go1.14+ and go1.12-1.13 interface and why it's different? I'm concerned that |
@knusbaum go 1.14+ has |
What is currently stopping us from using the existing tracing package and functions as they are, in tests? What is missing? Can we have a problem definition (e.g. what we are trying to solve) ? If we can do it with the tracing package, I don't think we need helper methods. However, once we have a clear problem definition, we may be able to come up with a testing package along the lines of what @knusbaum was suggesting |
@gbbr we want consistency in span tags with other languages, so they show up correctly in UI. |
I've added a description to the issue. |
The description helps. Sounds like we need a
|
Going deeper on the second point, I'd vote against the It may already be possible to automatically add all the CI tags within |
Closing as stale. We can create a new proposal when test tracing comes back up. |
Follow https://github.com/DataDog/dd-sdk-go-testing for information about test tracing. |
Along the same lines as the Python and Ruby tracers have done in DataDog/dd-trace-py#1741 and DataDog/dd-trace-rb#1216, we want to add some basic support for tracing go tests running in a CI environment.
This mostly consists of detecting the CI environment and adding specific tags that the backend understands to spans representing the go tests.
We want to provide a simple integration that allows the user to create spans with these tags for their tests. One challenge is making sure the go tracer is started when the tests run and shut down when they finish.
Helper method for tracer configuration
Usage
main_test.go
Implementation
Helper method to test execution
project_test.go
WithContext
WithNameGenerator(f func(ctx context.Context, t *testing.T))
- this would be nice to have as tracer optionImplementation
Prior work
The text was updated successfully, but these errors were encountered: