Add --ddtrace flag #9124
Merged
Add --ddtrace flag #9124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
coignetp
force-pushed
the
paul/ddev-trace
branch
from
616d36e
to
c55a3f8
Compare
coignetp
force-pushed
the
paul/ddev-trace
branch
from
7304238
to
93da484
Compare
coignetp
commented
Apr 9, 2021
| @@ -151,6 +160,15 @@ def test( | |||
| echo_debug(f"No envs found for: `{check}`") | |||
| continue | |||
|
|
|||
| ddtrace_check = ddtrace | |||
| if ddtrace and ON_WINDOWS and any('py2' in env for env in envs): | |||
There was a problem hiding this comment.
Since all the environment are grouped in the tox command, the flag is disabled for the whole check if there is one windows-py2 env
FlorianVeaux
previously approved these changes
Apr 9, 2021
Co-authored-by: Florian Veaux <[email protected]>
ofek
previously approved these changes
Apr 9, 2021
FlorianVeaux
approved these changes
Apr 13, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
* Add --ddtrace option to tests * Fix rebase * Disable for py2 * Update datadog_checks_dev/datadog_checks/dev/tooling/commands/test.py Co-authored-by: Florian Veaux <[email protected]> * Fix typo Co-authored-by: Florian Veaux <[email protected]> 4a91567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
--ddtraceoption toddev testcommand so we can use DataDog/dd-trace-py#1741Ex:
ddev test --ddtrace hdfs_datanodeMotivation
Needed to use the CI app product for this repo
Additional Notes
In order to send the traces to datadog, an agent must be available and the environment variables must be set accordingly https://docs.datadoghq.com/tracing/setup_overview/setup/python?tab=containers
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached