aiohttp client tracing #1372
aiohttp client tracing #1372
Conversation
- only mark 400+ statuses as errors (don't mark 2xx) - attempt fixing unittests
spent waaaay too long trying to get the lambda moto test to work with aiobotocore
|
Would love to see this merged, it'll make our distributed tracing so much easier! |
|
Could we know where the status of this PR at? |
|
@thehesiod this pull request is now in conflict 😩 |
|
It would be nice to have an option to use the client tracing without patching all sessions - i.e. having an option to instrument any |
|
@mklokocka I had support for this but removed it at request of DD for a forthcoming new way of achieving the same effect that I have yet to see |
|
@thehesiod @Kyle-Verhoog Similar question as on #394, can this PR now be finished? :) |
|
Any progress on this PR? |
|
If this is not being picked up I would like to give it a try and open a new one |
|
we have been using this in production for over a year (in particular the aio-libs one), my understanding is that they're working out an async rewrite in another PR before looking at this again. I was working with @Kyle-Verhoog , just waiting on an update from him on how to proceed |
|
hey @RobinMcCorkell, @gabrielelanaro, @thehesiod! Yes, I think we've got the async work done that we wanted to (mainly #1936). I'm going to try to find the time to get these |
|
This PR would be incredibly useful 👍 |
|
Hey guys! Thank you for this work! I'm also looking forward to seeing this PR merged 👍 |
|
I'd really love to see this instrumented. |
This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. #294 and later #1372 included additional support for ClientResponse and StreamReader which are omitted here with the intention of introducing them as follow ups. Co-authored-by: Alexander Mohr <[email protected]>
|
This has been addressed in #3362! It will be included in 0.60 🙂 Thanks everyone for their patience! |
This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. #294 and later #1372 included additional support for ClientResponse and StreamReader which are omitted here with the intention of introducing them as follow ups. Co-authored-by: Alexander Mohr <[email protected]>
This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. #294 and later #1372 included additional support for ClientResponse and StreamReader which are omitted here with the intention of introducing them as follow ups. Co-authored-by: Alexander Mohr <[email protected]> Co-authored-by: Kyle Verhoog <[email protected]> Co-authored-by: Alexander Mohr <[email protected]>
Continuation of #294. This PR adds tracing support for
ClientSessionClientResponseConnectorThe following changes are also made:
async/awaitsyntax