feat(aiohttp): add client integration #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Verhoog
force-pushed
the
aiohttp_client
branch
from
a8b0d49 to
9f83f21
Compare
|
@Kyle-Verhoog this pull request is now in conflict 😩 |
Kyle-Verhoog
force-pushed
the
aiohttp_client
branch
from
9f83f21 to
a452f40
Compare
brettlangdon
reviewed
Mar 4, 2022
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_200_request.json
Outdated
Show resolved
Hide resolved
Kyle-Verhoog
force-pushed
the
aiohttp_client
branch
2 times, most recently
from
c9f3a6e to
38dff42
Compare
Kyle-Verhoog
force-pushed
the
aiohttp_client
branch
from
38dff42 to
be80036
Compare
brettlangdon
reviewed
Mar 4, 2022
brettlangdon
reviewed
Mar 4, 2022
thehesiod
reviewed
Mar 4, 2022
Kyle-Verhoog
force-pushed
the
aiohttp_client
branch
4 times, most recently
from
dab7b75 to
38ab5c9
Compare
brettlangdon
reviewed
Mar 8, 2022
Kyle-Verhoog
force-pushed
the
aiohttp_client
branch
from
38ab5c9 to
64d5d7f
Compare
brettlangdon
reviewed
Mar 8, 2022
Kyle-Verhoog
force-pushed
the
aiohttp_client
branch
from
64d5d7f to
64ee9e0
Compare
Kyle-Verhoog
force-pushed
the
aiohttp_client
branch
from
d0c8985 to
012f140
Compare
Since the integration was orignially written a bunch of things have changed including integration conventions, async support, 1.0 deprecations/removals/moves and more. The StreamReader patching is omitted for now and can be introduced later.
Kyle-Verhoog
force-pushed
the
aiohttp_client
branch
from
012f140 to
192b61e
Compare
brettlangdon
approved these changes
Mar 9, 2022
majorgreys
approved these changes
Mar 9, 2022
Codecov Report
@@ Coverage Diff @@
## 1.x #3362 +/- ##
==========================================
+ Coverage 79.46% 79.53% +0.06%
==========================================
Files 615 617 +2
Lines 46427 46609 +182
==========================================
+ Hits 36895 37069 +174
- Misses 9532 9540 +8
Continue to review full report at Codecov.
|
|
@Mergifyio backport 0.x 1.0 |
Closed
✅ Backports have been created
|
Kyle-Verhoog
added a commit
that referenced
this pull request
Mar 9, 2022
This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. #294 and later #1372 included additional support for ClientResponse and StreamReader which are omitted here with the intention of introducing them as follow ups. Co-authored-by: Alexander Mohr <[email protected]>
brettlangdon
pushed a commit
that referenced
this pull request
Mar 9, 2022
This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. Co-authored-by: Alexander Mohr <[email protected]> (cherry picked from commit 2ac1fc9)
brettlangdon
pushed a commit
that referenced
this pull request
Mar 9, 2022
This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. #294 and later #1372 included additional support for ClientResponse and StreamReader which are omitted here with the intention of introducing them as follow ups. Co-authored-by: Alexander Mohr <[email protected]> Co-authored-by: Kyle Verhoog <[email protected]> Co-authored-by: Alexander Mohr <[email protected]>
brettlangdon
added a commit
that referenced
this pull request
Mar 9, 2022
* feat(aiohttp): add client integration (#3362) This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. Co-authored-by: Alexander Mohr <[email protected]> (cherry picked from commit 2ac1fc9) * Update ddtrace/contrib/aiohttp/__init__.py Co-authored-by: Kyle Verhoog <[email protected]> Co-authored-by: Brett Langdon <[email protected]>
4 tasks
|
@Kyle-Verhoog are there links for follow-up PR or issues? |
|
hey @thehesiod! We have not followed up yet for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration
This PR adds support for
aiohttpclient.Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed.
#294 and later #1372 included additional support for
ClientResponseandStreamReaderwhich are omitted here with the intention of introducing them as follow ups.Links
Checklist
__init__.py,docs/index.rstanddocs/integrations.rst.int_serviceorext_service).ddtrace.configentry is specified.trace_utils.set_http_metato set http tagspytestfixtures found intests/conftest.pyor the test helpers onTracerTestCaseifwriting
unitteststyle test cases..circleci/config.yml).test_django_patch.pyfor an example).