aiohttp 2.x+ client tracing support #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thehesiod
commented
Jun 22, 2017
•
thehesiod
commented
- builds on aiohttp enhancements #259 and supports full circle tracing from client to server and back
- bumps minimum supported aiohttp 2.x version to 2.1, but adds 2.3 to fix unittest
- adds missing aenter/aexit to aiohttp ClientResponse class
- only mark 400+ statuses as errors (don't mark 2xx) - attempt fixing unittests
spent waaaay too long trying to get the lambda moto test to work with aiobotocore
|
not sure why celery is failing, doesn't look like there are any fixes from master |
# Conflicts: # tests/contrib/aiohttp/app/web.py # tests/contrib/aiohttp/test_request.py
|
@irabinovitch at least, this needs some love, the tests still use |
jd
reviewed
Apr 30, 2019
| exc_tb) | ||
| finally: | ||
| if self._self_have_context and self._self_trace_context: | ||
| self._self_span.finish() |
There was a problem hiding this comment.
Maybe define a _finish_span method that can be used here and in L195 to avoid repeating?
|
will get back to this PR asap, thanks for feedback |
|
Does anybody use aiohttp 2.x now? |
thehesiod
changed the title
|
it works in 3.x as well, just it's not using the new aiohttp trace endpoints since it's missing some items: aio-libs/aiohttp#3084 |
|
Thanks for remembering the missing functionality :) |
|
Any news on this? @thehesiod |
…client # Conflicts: # ddtrace/context.py # ddtrace/contrib/aiohttp/middlewares.py # ddtrace/contrib/aiohttp/patch.py # tests/contrib/aiohttp/app/web.py
unfortunately no, however we're trying to get some more traction on my PRs via a different channel |
|
Thanks so much to @thehesiod for this work! We're going to continue it in #1319 so that we can work collaboratively to get it across the finish line 😄 |
Closed
28 tasks
Kyle-Verhoog
added a commit
that referenced
this pull request
Mar 9, 2022
This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. #294 and later #1372 included additional support for ClientResponse and StreamReader which are omitted here with the intention of introducing them as follow ups. Co-authored-by: Alexander Mohr <[email protected]>
Kyle-Verhoog
added a commit
that referenced
this pull request
Mar 9, 2022
This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. #294 and later #1372 included additional support for ClientResponse and StreamReader which are omitted here with the intention of introducing them as follow ups. Co-authored-by: Alexander Mohr <[email protected]>
brettlangdon
pushed a commit
that referenced
this pull request
Mar 9, 2022
This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. Co-authored-by: Alexander Mohr <[email protected]> (cherry picked from commit 2ac1fc9)
brettlangdon
pushed a commit
that referenced
this pull request
Mar 9, 2022
This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. #294 and later #1372 included additional support for ClientResponse and StreamReader which are omitted here with the intention of introducing them as follow ups. Co-authored-by: Alexander Mohr <[email protected]> Co-authored-by: Kyle Verhoog <[email protected]> Co-authored-by: Alexander Mohr <[email protected]>
brettlangdon
added a commit
that referenced
this pull request
Mar 9, 2022
* feat(aiohttp): add client integration (#3362) This PR adds support for aiohttp client. Work was long ago started on this in (#294 (thank you @thehesiod!!!). There were a number of issues in the library that led to not being able to merge in the work such as async context management, service naming, integration configuration and more which have all since been addressed. Co-authored-by: Alexander Mohr <[email protected]> (cherry picked from commit 2ac1fc9) * Update ddtrace/contrib/aiohttp/__init__.py Co-authored-by: Kyle Verhoog <[email protected]> Co-authored-by: Brett Langdon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.