chore(crashtracker): add required backend tags #10199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
|
sanchda
added
changelog/no-changelog
sanchda
force-pushed
the
08-13-chore_crashtracker_add_required_backend_tags
branch
from
eeff9c8
to
5c436eb
Compare
auto-merge was automatically disabled
August 13, 2024 15:28
Pull request was closed
Datadog ReportBranch report: ✅ 0 Failed, 413 Passed, 3397 Skipped, 33m 8.67s Total duration (56m 14.99s time saved) |
BenchmarksBenchmark execution time: 2024-08-14 18:45:53 Comparing candidate commit 1cfe3bc in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics. |
taegyunkim
approved these changes
Aug 13, 2024
taegyunkim
force-pushed
the
08-13-chore_crashtracker_add_required_backend_tags
branch
from
5c436eb
to
ee09b27
Compare
erikayasuda
approved these changes
Aug 14, 2024
|
@sanchda Do we need to backport this to 2.10? Isn't crashtracker is only available from 2.11? |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
This adds two new tags to the crashtracker. These tags will not be required in an upcoming version of libdatadog, but that version doesn't exist yet, so here we are. There's no need to document anything in a changelog since this feature isn't customer-impacting. It just makes it easier for us to build dashboards on the backend. :) [PROF-10357] ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit a657198)
2 tasks
brettlangdon
pushed a commit
that referenced
this pull request
Aug 15, 2024
This adds two new tags to the crashtracker. These tags will not be required in an upcoming version of libdatadog, but that version doesn't exist yet, so here we are. There's no need to document anything in a changelog since this feature isn't customer-impacting. It just makes it easier for us to build dashboards on the backend. :) [PROF-10357] ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
ivoanjo
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
Aug 15, 2024
**What does this PR do?** This PR adds the "severity: crash" tag to crashtracker reports, similar to what we do in Python in DataDog/dd-trace-py#10199 . In the future, this won't be needed by libdatadog, but for now this makes it easier for us to analyze reported crashes. **Motivation:** Improve crash reports. **Additional Notes:** N/A **How to test the change?** Change includes test coverage.
sanchda
added a commit
that referenced
this pull request
Aug 15, 2024
Backport a657198 from #10199 to 2.11. This adds two new tags to the crashtracker. These tags will not be required in an upcoming version of libdatadog, but that version doesn't exist yet, so here we are. There's no need to document anything in a changelog since this feature isn't customer-impacting. It just makes it easier for us to build dashboards on the backend. :) [PROF-10357] ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) [PROF-10357]: https://datadoghq.atlassian.net/browse/PROF-10357?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: David Sanchez <[email protected]>
ivoanjo
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
Aug 15, 2024
**What does this PR do?** This PR adds the following tags to crashtracker reports: * language * severity * profiler_version Severity is similar to what we do in Python in DataDog/dd-trace-py#10199 . The other two tags seem redundant, but right now if we don't pass them as tags to libdatadog they don't get picked up correctly. In the future, this won't be needed by libdatadog, but for now this makes it easier for us to analyze reported crashes. **Motivation:** Improve crash reports. **Additional Notes:** N/A **How to test the change?** Change includes test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new tags to the crashtracker. These tags will not be required in an upcoming version of libdatadog, but that version doesn't exist yet, so here we are.
There's no need to document anything in a changelog since this feature isn't customer-impacting. It just makes it easier for us to build dashboards on the backend. :)
PROF-10357
Checklist
Reviewer Checklist