Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crashtracker): add required backend tags [backport 2.11] #10232

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport a657198 from #10199 to 2.11.

This adds two new tags to the crashtracker. These tags will not be required in an upcoming version of libdatadog, but that version doesn't exist yet, so here we are.

There's no need to document anything in a changelog since this feature isn't customer-impacting. It just makes it easier for us to build dashboards on the backend. :)

PROF-10357

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

This adds two new tags to the crashtracker. These tags will not be
required in an upcoming version of libdatadog, but that version doesn't
exist yet, so here we are.

There's no need to document anything in a changelog since this feature
isn't customer-impacting. It just makes it easier for us to build
dashboards on the backend. :)

[PROF-10357]

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit a657198)
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 14, 2024
@github-actions github-actions bot requested review from a team as code owners August 14, 2024 19:08
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 14, 2024

Datadog Report

Branch report: backport-10199-to-2.11
Commit report: 84cb523
Test service: dd-trace-py

✅ 0 Failed, 1013 Passed, 2791 Skipped, 1h 0m 0.19s Total duration (31m 58.87s time saved)

@sanchda sanchda enabled auto-merge (squash) August 14, 2024 19:28
@pr-commenter
Copy link

pr-commenter bot commented Aug 14, 2024

Benchmarks

Benchmark execution time: 2024-08-14 19:45:56

Comparing candidate commit 7ef0693 in PR branch backport-10199-to-2.11 with baseline commit 4879718 in branch 2.11.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

Copy link
Contributor Author

CODEOWNERS have been resolved as:

ddtrace/internal/datadog/profiling/dd_wrapper/include/constants.hpp     @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/include/libdatadog_helpers.hpp  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/crashtracker.cpp      @DataDog/profiling-python
tests/internal/crashtracker/test_crashtracker.py                        @DataDog/apm-core-python

@sanchda sanchda merged commit ed52211 into 2.11 Aug 15, 2024
60 of 62 checks passed
@sanchda sanchda deleted the backport-10199-to-2.11 branch August 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants