[PROF-10241] Add extra tags to crash reports #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR adds the following tags to crashtracker reports: * language * severity * profiler_version Severity is similar to what we do in Python in DataDog/dd-trace-py#10199 . The other two tags seem redundant, but right now if we don't pass them as tags to libdatadog they don't get picked up correctly. In the future, this won't be needed by libdatadog, but for now this makes it easier for us to analyze reported crashes. **Motivation:** Improve crash reports. **Additional Notes:** N/A **How to test the change?** Change includes test coverage.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3847 +/- ##
==========================================
+ Coverage 97.83% 97.85% +0.02%
==========================================
Files 1264 1269 +5
Lines 75725 75869 +144
Branches 3729 3736 +7
==========================================
+ Hits 74084 74241 +157
+ Misses 1641 1628 -13 ☔ View full report in Codecov by Sentry. |
Oops, I had missed the internal discussion that we planned to no longer use severity:crash.
This seems to work fine, and it's a much better name.
TonyCTHsu
approved these changes
Aug 15, 2024
BenchmarksBenchmark execution time: 2024-08-15 15:14:20 Comparing candidate commit 64dfc9e in PR branch Found 3 performance improvements and 1 performance regressions! Performance is the same for 19 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
scenario:profiler - stack collector
scenario:tracing - Propagation - Datadog
scenario:tracing - Propagation - Trace Context
|
ivoanjo
added
the
dev/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the following tags to crashtracker reports:
severityprofiler_versionlibrary_versionSeverity is similar to what we do in Python inUpdate: We decided to not go with this one for now.DataDog/dd-trace-py#10199 .
The other two tags seem redundant, but right now if we don't pass them as tags to libdatadog they don't get picked up correctly.
In the future, this won't be needed by libdatadog, but for now this makes it easier for us to analyze reported crashes.
Motivation:
Improve crash reports.
Additional Notes:
N/A
How to test the change?
Change includes test coverage.
For Datadog folks: With this branch, if you crash Ruby, you'll see the crash show up in the usual dashboards. Crashes were not showing up without the "language" tag being set.