Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-10241] Add extra tags to crash reports #3847

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Aug 15, 2024

What does this PR do?

This PR adds the following tags to crashtracker reports:

  • language
  • severity
  • profiler_version library_version

Severity is similar to what we do in Python in
DataDog/dd-trace-py#10199 .
Update: We decided to not go with this one for now.

The other two tags seem redundant, but right now if we don't pass them as tags to libdatadog they don't get picked up correctly.

In the future, this won't be needed by libdatadog, but for now this makes it easier for us to analyze reported crashes.

Motivation:

Improve crash reports.

Additional Notes:

N/A

How to test the change?

Change includes test coverage.

For Datadog folks: With this branch, if you crash Ruby, you'll see the crash show up in the usual dashboards. Crashes were not showing up without the "language" tag being set.

**What does this PR do?**

This PR adds the following tags to crashtracker reports:
* language
* severity
* profiler_version

Severity is similar to what we do in Python in
DataDog/dd-trace-py#10199 .

The other two tags seem redundant, but right now if we don't pass
them as tags to libdatadog they don't get picked up correctly.

In the future, this won't be needed by libdatadog, but for now this
makes it easier for us to analyze reported crashes.

**Motivation:**

Improve crash reports.

**Additional Notes:**

N/A

**How to test the change?**

Change includes test coverage.
@ivoanjo ivoanjo requested a review from a team as a code owner August 15, 2024 14:44
@github-actions github-actions bot added the core Involves Datadog core libraries label Aug 15, 2024
@ivoanjo ivoanjo requested review from AlexJF and TonyCTHsu August 15, 2024 14:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (d2498fb) to head (64dfc9e).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3847      +/-   ##
==========================================
+ Coverage   97.83%   97.85%   +0.02%     
==========================================
  Files        1264     1269       +5     
  Lines       75725    75869     +144     
  Branches     3729     3736       +7     
==========================================
+ Hits        74084    74241     +157     
+ Misses       1641     1628      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Oops, I had missed the internal discussion that we planned to no longer
use severity:crash.
This seems to work fine, and it's a much better name.
@pr-commenter
Copy link

pr-commenter bot commented Aug 15, 2024

Benchmarks

Benchmark execution time: 2024-08-15 15:14:20

Comparing candidate commit 64dfc9e in PR branch ivoanjo/prof-10241-add-extra-crashtracker-tags with baseline commit 1402a32 in branch master.

Found 3 performance improvements and 1 performance regressions! Performance is the same for 19 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.755op/s; -0.734op/s] or [-10.405%; -10.109%]

scenario:profiler - stack collector

  • 🟩 throughput [+73.299op/s; +74.953op/s] or [+2.418%; +2.473%]

scenario:tracing - Propagation - Datadog

  • 🟩 throughput [+664.027op/s; +765.327op/s] or [+2.010%; +2.317%]

scenario:tracing - Propagation - Trace Context

  • 🟩 throughput [+759.961op/s; +875.924op/s] or [+2.018%; +2.326%]

@ivoanjo ivoanjo enabled auto-merge August 15, 2024 15:15
@ivoanjo ivoanjo merged commit a534220 into master Aug 15, 2024
153 of 161 checks passed
@ivoanjo ivoanjo deleted the ivoanjo/prof-10241-add-extra-crashtracker-tags branch August 15, 2024 15:21
@github-actions github-actions bot added this to the 2.3.0 milestone Aug 15, 2024
@ivoanjo ivoanjo added the dev/internal Other internal work that does not need to be included in the changelog label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants