-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Micronaut 4 support for code origin for spans #8039
Conversation
Make Code Origin for spans feature independent from dynamic instrumentation so it could be enabled while DI is not Add in Status Logger the code origin feature status
@AutoService(InstrumenterModule.class) | ||
public class MicronautCodeOriginInstrumentation extends CodeOriginInstrumentation { | ||
|
||
public static final String IO_MICRONAUT_HTTP_ANNOTATION = "io.micronaut.http.annotation."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This instrumentation works for micronaut 2.x, 3.x and 4.x since those annotations are available in the three. I would have put that specific instrumentatation in a common module otherwise we can think that it's only concerning micronaut 4
public static final String IO_MICRONAUT_HTTP_ANNOTATION = "io.micronaut.http.annotation."; | ||
|
||
public MicronautCodeOriginInstrumentation() { | ||
super("micronaut-span-origin"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should also include (at first place imho) super("micronaut", ...)
because if folks wants to disable micronaut they want this also to be off
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (314.078 µs) : 268, 361
. : milestone, 314,
basic (312.654 µs) : 301, 324
. : milestone, 313,
loop (11.042 ms) : 11012, 11071
. : milestone, 11042,
section candidate
noprobe (313.214 µs) : 275, 352
. : milestone, 313,
basic (306.966 µs) : 295, 318
. : milestone, 307,
loop (11.015 ms) : 10988, 11042
. : milestone, 11015,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~48ccdc178f, baseline=1.44.0-SNAPSHOT~d2c8a74d9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.097 s) : 0, 1097173
Total [baseline] (8.659 s) : 0, 8659024
Agent [candidate] (1.089 s) : 0, 1089088
Total [candidate] (8.647 s) : 0, 8646741
section iast
Agent [baseline] (1.216 s) : 0, 1215778
Total [baseline] (9.193 s) : 0, 9192908
Agent [candidate] (1.226 s) : 0, 1225925
Total [candidate] (9.244 s) : 0, 9244473
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.229 s) : 0, 1228594
Total [baseline] (9.174 s) : 0, 9174165
Agent [candidate] (1.218 s) : 0, 1218449
Total [candidate] (9.151 s) : 0, 9151069
section iast_TELEMETRY_OFF
Agent [baseline] (1.22 s) : 0, 1219626
Total [baseline] (9.142 s) : 0, 9141627
Agent [candidate] (1.22 s) : 0, 1220118
Total [candidate] (9.196 s) : 0, 9195920
gantt
title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~48ccdc178f, baseline=1.44.0-SNAPSHOT~d2c8a74d9d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.783 ms) : 0, 696783
BytebuddyAgent [candidate] (694.048 ms) : 0, 694048
GlobalTracer [baseline] (318.957 ms) : 0, 318957
GlobalTracer [candidate] (316.535 ms) : 0, 316535
AppSec [baseline] (54.968 ms) : 0, 54968
AppSec [candidate] (54.887 ms) : 0, 54887
Remote Config [baseline] (683.533 µs) : 0, 684
Remote Config [candidate] (684.584 µs) : 0, 685
Telemetry [baseline] (12.102 ms) : 0, 12102
Telemetry [candidate] (9.243 ms) : 0, 9243
section iast
BytebuddyAgent [baseline] (810.181 ms) : 0, 810181
BytebuddyAgent [candidate] (817.798 ms) : 0, 817798
GlobalTracer [baseline] (304.712 ms) : 0, 304712
GlobalTracer [candidate] (307.558 ms) : 0, 307558
AppSec [baseline] (57.428 ms) : 0, 57428
AppSec [candidate] (57.044 ms) : 0, 57044
IAST [baseline] (21.67 ms) : 0, 21670
IAST [candidate] (21.573 ms) : 0, 21573
Remote Config [baseline] (634.606 µs) : 0, 635
Remote Config [candidate] (642.412 µs) : 0, 642
Telemetry [baseline] (7.512 ms) : 0, 7512
Telemetry [candidate] (7.455 ms) : 0, 7455
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (820.193 ms) : 0, 820193
BytebuddyAgent [candidate] (811.985 ms) : 0, 811985
GlobalTracer [baseline] (307.916 ms) : 0, 307916
GlobalTracer [candidate] (305.817 ms) : 0, 305817
AppSec [baseline] (56.955 ms) : 0, 56955
AppSec [candidate] (56.137 ms) : 0, 56137
IAST [baseline] (21.543 ms) : 0, 21543
IAST [candidate] (22.661 ms) : 0, 22661
Remote Config [baseline] (635.097 µs) : 0, 635
Remote Config [candidate] (630.809 µs) : 0, 631
Telemetry [baseline] (7.443 ms) : 0, 7443
Telemetry [candidate] (7.476 ms) : 0, 7476
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (814.1 ms) : 0, 814100
BytebuddyAgent [candidate] (814.159 ms) : 0, 814159
GlobalTracer [baseline] (305.266 ms) : 0, 305266
GlobalTracer [candidate] (305.645 ms) : 0, 305645
AppSec [baseline] (58.033 ms) : 0, 58033
AppSec [candidate] (57.046 ms) : 0, 57046
IAST [baseline] (20.321 ms) : 0, 20321
IAST [candidate] (21.467 ms) : 0, 21467
Remote Config [baseline] (628.722 µs) : 0, 629
Remote Config [candidate] (633.981 µs) : 0, 634
Telemetry [baseline] (7.417 ms) : 0, 7417
Telemetry [candidate] (7.357 ms) : 0, 7357
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~48ccdc178f, baseline=1.44.0-SNAPSHOT~d2c8a74d9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088222
Total [baseline] (10.506 s) : 0, 10506049
Agent [candidate] (1.095 s) : 0, 1095185
Total [candidate] (10.5 s) : 0, 10500237
section appsec
Agent [baseline] (1.227 s) : 0, 1227193
Total [baseline] (10.712 s) : 0, 10712315
Agent [candidate] (1.223 s) : 0, 1223330
Total [candidate] (10.733 s) : 0, 10732873
section iast
Agent [baseline] (1.224 s) : 0, 1224045
Total [baseline] (10.89 s) : 0, 10889789
Agent [candidate] (1.22 s) : 0, 1220088
Total [candidate] (10.936 s) : 0, 10936403
section profiling
Agent [baseline] (1.312 s) : 0, 1311886
Total [baseline] (10.728 s) : 0, 10727909
Agent [candidate] (1.33 s) : 0, 1330414
Total [candidate] (10.907 s) : 0, 10906789
gantt
title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~48ccdc178f, baseline=1.44.0-SNAPSHOT~d2c8a74d9d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.492 ms) : 0, 693492
BytebuddyAgent [candidate] (696.211 ms) : 0, 696211
GlobalTracer [baseline] (315.698 ms) : 0, 315698
GlobalTracer [candidate] (316.586 ms) : 0, 316586
AppSec [baseline] (54.714 ms) : 0, 54714
AppSec [candidate] (54.99 ms) : 0, 54990
Remote Config [baseline] (682.575 µs) : 0, 683
Remote Config [candidate] (681.988 µs) : 0, 682
Telemetry [baseline] (9.958 ms) : 0, 9958
Telemetry [candidate] (12.924 ms) : 0, 12924
section appsec
BytebuddyAgent [baseline] (713.346 ms) : 0, 713346
BytebuddyAgent [candidate] (709.904 ms) : 0, 709904
GlobalTracer [baseline] (314.545 ms) : 0, 314545
GlobalTracer [candidate] (314.132 ms) : 0, 314132
AppSec [baseline] (166.953 ms) : 0, 166953
AppSec [candidate] (167.307 ms) : 0, 167307
Remote Config [baseline] (651.124 µs) : 0, 651
Remote Config [candidate] (638.236 µs) : 0, 638
Telemetry [baseline] (8.158 ms) : 0, 8158
Telemetry [candidate] (7.802 ms) : 0, 7802
IAST [baseline] (19.663 ms) : 0, 19663
IAST [candidate] (19.698 ms) : 0, 19698
section iast
BytebuddyAgent [baseline] (817.723 ms) : 0, 817723
BytebuddyAgent [candidate] (813.535 ms) : 0, 813535
GlobalTracer [baseline] (305.523 ms) : 0, 305523
GlobalTracer [candidate] (305.942 ms) : 0, 305942
AppSec [baseline] (57.838 ms) : 0, 57838
AppSec [candidate] (57.956 ms) : 0, 57956
Remote Config [baseline] (638.233 µs) : 0, 638
Remote Config [candidate] (633.76 µs) : 0, 634
Telemetry [baseline] (7.545 ms) : 0, 7545
Telemetry [candidate] (7.461 ms) : 0, 7461
IAST [baseline] (21.001 ms) : 0, 21001
IAST [candidate] (20.8 ms) : 0, 20800
section profiling
ProfilingAgent [baseline] (93.373 ms) : 0, 93373
ProfilingAgent [candidate] (94.334 ms) : 0, 94334
BytebuddyAgent [baseline] (686.276 ms) : 0, 686276
BytebuddyAgent [candidate] (696.971 ms) : 0, 696971
GlobalTracer [baseline] (431.385 ms) : 0, 431385
GlobalTracer [candidate] (436.944 ms) : 0, 436944
AppSec [baseline] (53.573 ms) : 0, 53573
AppSec [candidate] (54.347 ms) : 0, 54347
Remote Config [baseline] (663.493 µs) : 0, 663
Remote Config [candidate] (667.722 µs) : 0, 668
Telemetry [baseline] (7.692 ms) : 0, 7692
Telemetry [candidate] (7.757 ms) : 0, 7757
Profiling [baseline] (93.396 ms) : 0, 93396
Profiling [candidate] (94.359 ms) : 0, 94359
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~48ccdc178f, baseline=1.44.0-SNAPSHOT~d2c8a74d9d
dateFormat X
axisFormat %s
section baseline
no_agent (372.142 µs) : 353, 392
. : milestone, 372,
iast (491.046 µs) : 469, 513
. : milestone, 491,
iast_FULL (656.383 µs) : 635, 678
. : milestone, 656,
iast_GLOBAL (512.243 µs) : 491, 534
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (487.042 µs) : 466, 508
. : milestone, 487,
iast_INACTIVE (450.325 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (486.913 µs) : 465, 509
. : milestone, 487,
tracing (448.448 µs) : 427, 470
. : milestone, 448,
section candidate
no_agent (382.014 µs) : 362, 402
. : milestone, 382,
iast (487.049 µs) : 466, 508
. : milestone, 487,
iast_FULL (651.687 µs) : 630, 673
. : milestone, 652,
iast_GLOBAL (522.909 µs) : 500, 546
. : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (488.429 µs) : 467, 509
. : milestone, 488,
iast_INACTIVE (453.539 µs) : 432, 475
. : milestone, 454,
iast_TELEMETRY_OFF (479.922 µs) : 459, 501
. : milestone, 480,
tracing (459.996 µs) : 438, 482
. : milestone, 460,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~48ccdc178f, baseline=1.44.0-SNAPSHOT~d2c8a74d9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.363 ms) : 1343, 1382
. : milestone, 1363,
appsec (1.745 ms) : 1720, 1769
. : milestone, 1745,
appsec_no_iast (1.76 ms) : 1736, 1785
. : milestone, 1760,
iast (1.494 ms) : 1471, 1517
. : milestone, 1494,
profiling (1.512 ms) : 1490, 1535
. : milestone, 1512,
tracing (1.494 ms) : 1470, 1518
. : milestone, 1494,
section candidate
no_agent (1.364 ms) : 1344, 1383
. : milestone, 1364,
appsec (1.747 ms) : 1722, 1772
. : milestone, 1747,
appsec_no_iast (1.767 ms) : 1743, 1791
. : milestone, 1767,
iast (1.501 ms) : 1478, 1524
. : milestone, 1501,
profiling (1.564 ms) : 1537, 1590
. : milestone, 1564,
tracing (1.489 ms) : 1465, 1514
. : milestone, 1489,
Dacapo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how hard would it be to get tests in place like what we have for grpc? I'm trying to extract out the core of that set up in the kafka tests I'm writing but it's not quite there yet.
@@ -105,6 +105,9 @@ private enum AgentFeature { | |||
DEBUGGER(propertyNameToSystemPropertyName(DebuggerConfig.DEBUGGER_ENABLED), false), | |||
EXCEPTION_DEBUGGING( | |||
propertyNameToSystemPropertyName(DebuggerConfig.EXCEPTION_REPLAY_ENABLED), false), | |||
SPAN_ORIGIN( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is feature flag. used in isFeatureEnabled
function
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#​3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#​3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#​3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#​3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#​3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#​3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#​3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#​3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#​3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#​3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#​3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#​3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#​3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#​3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#​3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#​3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#​3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#​3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#​3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#​3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#​1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#​1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#​1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#​1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#​1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#​1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#​1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#​8089](DataDog/dd-trace-java#8089) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#​7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#​8044](DataDog/dd-trace-java#8044) - [@​smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#​8038](DataDog/dd-trace-java#8038) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#​8026](DataDog/dd-trace-java#8026) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#​8013](DataDog/dd-trace-java#8013) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#​8010](DataDog/dd-trace-java#8010) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#​7920](DataDog/dd-trace-java#7920) - [@​Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#​8004](DataDog/dd-trace-java#8004) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#​8078](DataDog/dd-trace-java#8078) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#​8055](DataDog/dd-trace-java#8055) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#​8033](DataDog/dd-trace-java#8033) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#​8030](DataDog/dd-trace-java#8030) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#​8045](DataDog/dd-trace-java#8045) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#​8071](DataDog/dd-trace-java#8071) - [@​piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#​8051](DataDog/dd-trace-java#8051) - [@​kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#​7959](DataDog/dd-trace-java#7959) - [@​piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#​8039](DataDog/dd-trace-java#8039) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#​8021](DataDog/dd-trace-java#8021) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#​8016](DataDog/dd-trace-java#8016) - [@​evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#​7942](DataDog/dd-trace-java#7942) - [@​evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#​8065](DataDog/dd-trace-java#8065) - [@​MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#​8036](DataDog/dd-trace-java#8036) - [@​mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#​8012](DataDog/dd-trace-java#8012) - [@​mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#​8058](DataDog/dd-trace-java#8058) - [@​mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#​8064](DataDog/dd-trace-java#8064) - [@​amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#​8061](DataDog/dd-trace-java#8061) - [@​amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#​8040](DataDog/dd-trace-java#8040) - [@​cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#​8028](DataDog/dd-trace-java#8028) - [@​mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#​7973](DataDog/dd-trace-java#7973) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#​7946](DataDog/dd-trace-java#7946) - [@​smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#​7920](DataDog/dd-trace-java#7920) - [@​Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#​8043](DataDog/dd-trace-java#8043) - [@​amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#​7940](DataDog/dd-trace-java#7940) - [@​nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#​8062](DataDog/dd-trace-java#8062) - [@​amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#​7959](DataDog/dd-trace-java#7959) - [@​piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#​8019](DataDog/dd-trace-java#8019) - [@​mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#​8012](DataDog/dd-trace-java#8012) - [@​mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#​8005](DataDog/dd-trace-java#8005) - [@​amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#​8025](DataDog/dd-trace-java#8025) - [@​amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#​7981](DataDog/dd-trace-java#7981) - [@​amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c
What Does This Do
Make Code Origin for spans feature independent from dynamic instrumentation so it could be enabled while DI is not Add in Status Logger the code origin feature status
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-3162