Support using OpenTelemetry Event API inside `@WithSpan` annotated method #8019

mcculls · 2024-11-26T12:09:06Z

What Does This Do

Adds OtelSpanEvent to the helpers injected when interacting with the OpenTelemetry Context API.

Motivation

This helper is needed to support Event API calls made inside contexts produced by @WithSpan before the main OpenTelemetry API is touched.

Additional Notes

One workaround is to add a static reference to GlobalOpenTelemetry in your application:

  static {
    GlobalOpenTelemetry.get();
  }

which will trigger injection of OtelSpanEvent via OpenTelemetryInstrumentation

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

…thSpan annotated method

...rc/main/java/datadog/trace/instrumentation/opentelemetry14/OpenTelemetryInstrumentation.java

pr-commenter · 2024-11-26T12:44:38Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/fix-missing-event-type-when-instrumenting-otel-withspan
git_commit_date	1732608616	1732622515
git_commit_sha	`92e8023`	`5f76fd2`
release_version	1.44.0-SNAPSHOT~92e8023155	1.44.0-SNAPSHOT~5f76fd249f

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732625013	1732625013
ci_job_id	720427114	720427114
ci_pipeline_id	49957030	49957030
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~5f76fd249f, baseline=1.44.0-SNAPSHOT~92e8023155

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1092747
Total [baseline] (8.643 s) : 0, 8643131
Agent [candidate] (1.098 s) : 0, 1097980
Total [candidate] (8.647 s) : 0, 8647420
section iast
Agent [baseline] (1.222 s) : 0, 1221903
Total [baseline] (9.204 s) : 0, 9203761
Agent [candidate] (1.22 s) : 0, 1219711
Total [candidate] (9.191 s) : 0, 9191397
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.216 s) : 0, 1215645
Total [baseline] (9.147 s) : 0, 9146685
Agent [candidate] (1.221 s) : 0, 1220516
Total [candidate] (9.157 s) : 0, 9157003
section iast_TELEMETRY_OFF
Agent [baseline] (1.231 s) : 0, 1230850
Total [baseline] (9.232 s) : 0, 9231847
Agent [candidate] (1.215 s) : 0, 1215151
Total [candidate] (9.192 s) : 0, 9191751

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.093 s	-
Agent	iast	1.222 s	129.156 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.216 s	122.898 ms (11.2%)
Agent	iast_TELEMETRY_OFF	1.231 s	138.103 ms (12.6%)
Total	tracing	8.643 s	-
Total	iast	9.204 s	560.629 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.147 s	503.554 ms (5.8%)
Total	iast_TELEMETRY_OFF	9.232 s	588.716 ms (6.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.098 s	-
Agent	iast	1.22 s	121.731 ms (11.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.221 s	122.536 ms (11.2%)
Agent	iast_TELEMETRY_OFF	1.215 s	117.171 ms (10.7%)
Total	tracing	8.647 s	-
Total	iast	9.191 s	543.977 ms (6.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.157 s	509.583 ms (5.9%)
Total	iast_TELEMETRY_OFF	9.192 s	544.332 ms (6.3%)

gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~5f76fd249f, baseline=1.44.0-SNAPSHOT~92e8023155

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.97 ms) : 0, 694970
BytebuddyAgent [candidate] (699.158 ms) : 0, 699158
GlobalTracer [baseline] (317.978 ms) : 0, 317978
GlobalTracer [candidate] (319.647 ms) : 0, 319647
AppSec [baseline] (54.706 ms) : 0, 54706
AppSec [candidate] (54.678 ms) : 0, 54678
Remote Config [baseline] (673.694 µs) : 0, 674
Remote Config [candidate] (688.148 µs) : 0, 688
Telemetry [baseline] (10.68 ms) : 0, 10680
Telemetry [candidate] (9.98 ms) : 0, 9980
section iast
BytebuddyAgent [baseline] (813.407 ms) : 0, 813407
BytebuddyAgent [candidate] (812.347 ms) : 0, 812347
GlobalTracer [baseline] (307.518 ms) : 0, 307518
GlobalTracer [candidate] (306.86 ms) : 0, 306860
AppSec [baseline] (58.188 ms) : 0, 58188
AppSec [candidate] (57.77 ms) : 0, 57770
IAST [baseline] (20.799 ms) : 0, 20799
IAST [candidate] (20.816 ms) : 0, 20816
Remote Config [baseline] (627.45 µs) : 0, 627
Remote Config [candidate] (623.634 µs) : 0, 624
Telemetry [baseline] (7.569 ms) : 0, 7569
Telemetry [candidate] (7.509 ms) : 0, 7509
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.401 ms) : 0, 809401
BytebuddyAgent [candidate] (812.356 ms) : 0, 812356
GlobalTracer [baseline] (305.753 ms) : 0, 305753
GlobalTracer [candidate] (307.448 ms) : 0, 307448
AppSec [baseline] (57.724 ms) : 0, 57724
AppSec [candidate] (57.009 ms) : 0, 57009
IAST [baseline] (20.881 ms) : 0, 20881
IAST [candidate] (21.686 ms) : 0, 21686
Remote Config [baseline] (614.931 µs) : 0, 615
Remote Config [candidate] (648.706 µs) : 0, 649
Telemetry [baseline] (7.565 ms) : 0, 7565
Telemetry [candidate] (7.566 ms) : 0, 7566
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (819.662 ms) : 0, 819662
BytebuddyAgent [candidate] (808.802 ms) : 0, 808802
GlobalTracer [baseline] (309.605 ms) : 0, 309605
GlobalTracer [candidate] (306.093 ms) : 0, 306093
AppSec [baseline] (56.316 ms) : 0, 56316
AppSec [candidate] (57.992 ms) : 0, 57992
IAST [baseline] (23.208 ms) : 0, 23208
IAST [candidate] (20.499 ms) : 0, 20499
Remote Config [baseline] (645.796 µs) : 0, 646
Remote Config [candidate] (629.24 µs) : 0, 629
Telemetry [baseline] (7.521 ms) : 0, 7521
Telemetry [candidate] (7.397 ms) : 0, 7397

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~5f76fd249f, baseline=1.44.0-SNAPSHOT~92e8023155

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1095369
Total [baseline] (10.498 s) : 0, 10498249
Agent [candidate] (1.09 s) : 0, 1089901
Total [candidate] (10.418 s) : 0, 10418383
section appsec
Agent [baseline] (1.225 s) : 0, 1224601
Total [baseline] (10.739 s) : 0, 10738765
Agent [candidate] (1.226 s) : 0, 1226208
Total [candidate] (10.711 s) : 0, 10710784
section iast
Agent [baseline] (1.225 s) : 0, 1225154
Total [baseline] (10.931 s) : 0, 10931340
Agent [candidate] (1.215 s) : 0, 1214887
Total [candidate] (10.946 s) : 0, 10946209
section profiling
Agent [baseline] (1.348 s) : 0, 1348486
Total [baseline] (10.934 s) : 0, 10933944
Agent [candidate] (1.313 s) : 0, 1313232
Total [candidate] (10.842 s) : 0, 10841734

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	appsec	1.225 s	129.232 ms (11.8%)
Agent	iast	1.225 s	129.785 ms (11.8%)
Agent	profiling	1.348 s	253.117 ms (23.1%)
Total	tracing	10.498 s	-
Total	appsec	10.739 s	240.516 ms (2.3%)
Total	iast	10.931 s	433.091 ms (4.1%)
Total	profiling	10.934 s	435.695 ms (4.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.09 s	-
Agent	appsec	1.226 s	136.307 ms (12.5%)
Agent	iast	1.215 s	124.986 ms (11.5%)
Agent	profiling	1.313 s	223.331 ms (20.5%)
Total	tracing	10.418 s	-
Total	appsec	10.711 s	292.401 ms (2.8%)
Total	iast	10.946 s	527.826 ms (5.1%)
Total	profiling	10.842 s	423.351 ms (4.1%)

gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~5f76fd249f, baseline=1.44.0-SNAPSHOT~92e8023155

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.271 ms) : 0, 696271
BytebuddyAgent [candidate] (693.99 ms) : 0, 693990
GlobalTracer [baseline] (319.267 ms) : 0, 319267
GlobalTracer [candidate] (317.72 ms) : 0, 317720
AppSec [baseline] (54.686 ms) : 0, 54686
AppSec [candidate] (54.7 ms) : 0, 54700
Remote Config [baseline] (681.619 µs) : 0, 682
Remote Config [candidate] (682.898 µs) : 0, 683
Telemetry [baseline] (10.642 ms) : 0, 10642
Telemetry [candidate] (9.082 ms) : 0, 9082
section appsec
BytebuddyAgent [baseline] (711.772 ms) : 0, 711772
BytebuddyAgent [candidate] (711.868 ms) : 0, 711868
GlobalTracer [baseline] (313.777 ms) : 0, 313777
GlobalTracer [candidate] (315.028 ms) : 0, 315028
AppSec [baseline] (167.671 ms) : 0, 167671
AppSec [candidate] (166.932 ms) : 0, 166932
IAST [baseline] (19.053 ms) : 0, 19053
IAST [candidate] (21.243 ms) : 0, 21243
Remote Config [baseline] (645.896 µs) : 0, 646
Remote Config [candidate] (638.232 µs) : 0, 638
Telemetry [baseline] (7.465 ms) : 0, 7465
Telemetry [candidate] (7.419 ms) : 0, 7419
section iast
BytebuddyAgent [baseline] (817.153 ms) : 0, 817153
BytebuddyAgent [candidate] (809.203 ms) : 0, 809203
GlobalTracer [baseline] (307.553 ms) : 0, 307553
GlobalTracer [candidate] (305.051 ms) : 0, 305051
AppSec [baseline] (57.01 ms) : 0, 57010
AppSec [candidate] (57.678 ms) : 0, 57678
IAST [baseline] (21.484 ms) : 0, 21484
IAST [candidate] (21.059 ms) : 0, 21059
Remote Config [baseline] (602.048 µs) : 0, 602
Remote Config [candidate] (614.153 µs) : 0, 614
Telemetry [baseline] (7.494 ms) : 0, 7494
Telemetry [candidate] (7.579 ms) : 0, 7579
section profiling
BytebuddyAgent [baseline] (706.343 ms) : 0, 706343
BytebuddyAgent [candidate] (688.286 ms) : 0, 688286
GlobalTracer [baseline] (442.749 ms) : 0, 442749
GlobalTracer [candidate] (431.15 ms) : 0, 431150
AppSec [baseline] (54.485 ms) : 0, 54485
AppSec [candidate] (53.539 ms) : 0, 53539
Remote Config [baseline] (676.916 µs) : 0, 677
Remote Config [candidate] (659.578 µs) : 0, 660
Telemetry [baseline] (8.023 ms) : 0, 8023
Telemetry [candidate] (7.652 ms) : 0, 7652
ProfilingAgent [baseline] (96.006 ms) : 0, 96006
ProfilingAgent [candidate] (92.914 ms) : 0, 92914
Profiling [baseline] (96.03 ms) : 0, 96030
Profiling [candidate] (92.938 ms) : 0, 92938

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-26T12:13:43	2024-11-26T12:20:41
git_branch	master	mcculls/fix-missing-event-type-when-instrumenting-otel-withspan
git_commit_date	1732608616	1732622515
git_commit_sha	`92e8023`	`5f76fd2`
release_version	1.44.0-SNAPSHOT~92e8023155	1.44.0-SNAPSHOT~5f76fd249f
start_time	2024-11-26T12:13:29	2024-11-26T12:20:27

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732623997	1732623997
ci_job_id	720427115	720427115
ci_pipeline_id	49957030	49957030
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~5f76fd249f, baseline=1.44.0-SNAPSHOT~92e8023155
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.358 ms) : 1339, 1377
.   : milestone, 1358,
appsec (1.758 ms) : 1734, 1783
.   : milestone, 1758,
appsec_no_iast (1.733 ms) : 1708, 1758
.   : milestone, 1733,
iast (1.489 ms) : 1466, 1512
.   : milestone, 1489,
profiling (1.512 ms) : 1489, 1534
.   : milestone, 1512,
tracing (1.508 ms) : 1484, 1532
.   : milestone, 1508,
section candidate
no_agent (1.361 ms) : 1341, 1381
.   : milestone, 1361,
appsec (1.776 ms) : 1752, 1800
.   : milestone, 1776,
appsec_no_iast (1.769 ms) : 1744, 1793
.   : milestone, 1769,
iast (1.519 ms) : 1496, 1542
.   : milestone, 1519,
profiling (1.551 ms) : 1527, 1576
.   : milestone, 1551,
tracing (1.494 ms) : 1469, 1519
.   : milestone, 1494,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.358 ms [1.339 ms, 1.377 ms]	-
appsec	1.758 ms [1.734 ms, 1.783 ms]	400.461 µs (29.5%)
appsec_no_iast	1.733 ms [1.708 ms, 1.758 ms]	375.149 µs (27.6%)
iast	1.489 ms [1.466 ms, 1.512 ms]	130.89 µs (9.6%)
profiling	1.512 ms [1.489 ms, 1.534 ms]	153.493 µs (11.3%)
tracing	1.508 ms [1.484 ms, 1.532 ms]	150.248 µs (11.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.361 ms [1.341 ms, 1.381 ms]	-
appsec	1.776 ms [1.752 ms, 1.8 ms]	415.252 µs (30.5%)
appsec_no_iast	1.769 ms [1.744 ms, 1.793 ms]	407.703 µs (30.0%)
iast	1.519 ms [1.496 ms, 1.542 ms]	158.064 µs (11.6%)
profiling	1.551 ms [1.527 ms, 1.576 ms]	190.312 µs (14.0%)
tracing	1.494 ms [1.469 ms, 1.519 ms]	132.99 µs (9.8%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~5f76fd249f, baseline=1.44.0-SNAPSHOT~92e8023155
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.114 µs) : 363, 403
.   : milestone, 383,
iast (494.695 µs) : 473, 516
.   : milestone, 495,
iast_FULL (654.305 µs) : 633, 676
.   : milestone, 654,
iast_GLOBAL (525.294 µs) : 503, 547
.   : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (493.421 µs) : 472, 515
.   : milestone, 493,
iast_INACTIVE (449.967 µs) : 429, 470
.   : milestone, 450,
iast_TELEMETRY_OFF (483.173 µs) : 462, 505
.   : milestone, 483,
tracing (457.105 µs) : 436, 478
.   : milestone, 457,
section candidate
no_agent (379.11 µs) : 359, 399
.   : milestone, 379,
iast (492.691 µs) : 471, 514
.   : milestone, 493,
iast_FULL (655.327 µs) : 634, 677
.   : milestone, 655,
iast_GLOBAL (528.17 µs) : 506, 550
.   : milestone, 528,
iast_HARDCODED_SECRET_DISABLED (499.711 µs) : 478, 521
.   : milestone, 500,
iast_INACTIVE (459.885 µs) : 438, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (485.927 µs) : 465, 507
.   : milestone, 486,
tracing (453.195 µs) : 432, 475
.   : milestone, 453,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.114 µs [363.239 µs, 402.989 µs]	-
iast	494.695 µs [473.084 µs, 516.306 µs]	111.581 µs (29.1%)
iast_FULL	654.305 µs [632.763 µs, 675.847 µs]	271.191 µs (70.8%)
iast_GLOBAL	525.294 µs [503.232 µs, 547.356 µs]	142.18 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED	493.421 µs [472.128 µs, 514.713 µs]	110.307 µs (28.8%)
iast_INACTIVE	449.967 µs [429.497 µs, 470.437 µs]	66.853 µs (17.4%)
iast_TELEMETRY_OFF	483.173 µs [461.656 µs, 504.689 µs]	100.059 µs (26.1%)
tracing	457.105 µs [435.942 µs, 478.268 µs]	73.991 µs (19.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.11 µs [358.818 µs, 399.401 µs]	-
iast	492.691 µs [471.413 µs, 513.97 µs]	113.582 µs (30.0%)
iast_FULL	655.327 µs [633.892 µs, 676.761 µs]	276.217 µs (72.9%)
iast_GLOBAL	528.17 µs [505.945 µs, 550.396 µs]	149.061 µs (39.3%)
iast_HARDCODED_SECRET_DISABLED	499.711 µs [478.275 µs, 521.147 µs]	120.602 µs (31.8%)
iast_INACTIVE	459.885 µs [438.401 µs, 481.368 µs]	80.775 µs (21.3%)
iast_TELEMETRY_OFF	485.927 µs [464.683 µs, 507.171 µs]	106.818 µs (28.2%)
tracing	453.195 µs [431.884 µs, 474.505 µs]	74.085 µs (19.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/fix-missing-event-type-when-instrumenting-otel-withspan
git_commit_date	1732608616	1732622515
git_commit_sha	`92e8023`	`5f76fd2`
release_version	1.44.0-SNAPSHOT~92e8023155	1.44.0-SNAPSHOT~5f76fd249f

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1732624556	1732624556
ci_job_id	720427116	720427116
ci_pipeline_id	49957030	49957030
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~5f76fd249f, baseline=1.44.0-SNAPSHOT~92e8023155
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.343 ms) : 2301, 2384
.   : milestone, 2343,
iast (2.094 ms) : 2042, 2147
.   : milestone, 2094,
iast_GLOBAL (2.142 ms) : 2088, 2195
.   : milestone, 2142,
profiling (2.445 ms) : 2259, 2630
.   : milestone, 2445,
tracing (1.942 ms) : 1901, 1982
.   : milestone, 1942,
section candidate
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.342 ms) : 2300, 2383
.   : milestone, 2342,
iast (2.078 ms) : 2025, 2130
.   : milestone, 2078,
iast_GLOBAL (2.133 ms) : 2081, 2186
.   : milestone, 2133,
profiling (1.967 ms) : 1924, 2010
.   : milestone, 1967,
tracing (1.928 ms) : 1887, 1968
.   : milestone, 1928,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.468 ms [1.456 ms, 1.479 ms]	-
appsec	2.343 ms [2.301 ms, 2.384 ms]	874.981 µs (59.6%)
iast	2.094 ms [2.042 ms, 2.147 ms]	626.478 µs (42.7%)
iast_GLOBAL	2.142 ms [2.088 ms, 2.195 ms]	673.7 µs (45.9%)
profiling	2.445 ms [2.259 ms, 2.63 ms]	976.715 µs (66.5%)
tracing	1.942 ms [1.901 ms, 1.982 ms]	474.098 µs (32.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.468 ms [1.457 ms, 1.48 ms]	-
appsec	2.342 ms [2.3 ms, 2.383 ms]	873.671 µs (59.5%)
iast	2.078 ms [2.025 ms, 2.13 ms]	609.47 µs (41.5%)
iast_GLOBAL	2.133 ms [2.081 ms, 2.186 ms]	665.332 µs (45.3%)
profiling	1.967 ms [1.924 ms, 2.01 ms]	498.994 µs (34.0%)
tracing	1.928 ms [1.887 ms, 1.968 ms]	459.541 µs (31.3%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~5f76fd249f, baseline=1.44.0-SNAPSHOT~92e8023155
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.104 s) : 15104000, 15104000
.   : milestone, 15104000,
appsec (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
iast (18.598 s) : 18598000, 18598000
.   : milestone, 18598000,
iast_GLOBAL (18.31 s) : 18310000, 18310000
.   : milestone, 18310000,
profiling (15.177 s) : 15177000, 15177000
.   : milestone, 15177000,
tracing (14.743 s) : 14743000, 14743000
.   : milestone, 14743000,
section candidate
no_agent (14.934 s) : 14934000, 14934000
.   : milestone, 14934000,
appsec (15.076 s) : 15076000, 15076000
.   : milestone, 15076000,
iast (18.828 s) : 18828000, 18828000
.   : milestone, 18828000,
iast_GLOBAL (17.678 s) : 17678000, 17678000
.   : milestone, 17678000,
profiling (15.013 s) : 15013000, 15013000
.   : milestone, 15013000,
tracing (14.992 s) : 14992000, 14992000
.   : milestone, 14992000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.104 s [15.104 s, 15.104 s]	-
appsec	15.009 s [15.009 s, 15.009 s]	-95.0 ms (-0.6%)
iast	18.598 s [18.598 s, 18.598 s]	3.494 s (23.1%)
iast_GLOBAL	18.31 s [18.31 s, 18.31 s]	3.206 s (21.2%)
profiling	15.177 s [15.177 s, 15.177 s]	73.0 ms (0.5%)
tracing	14.743 s [14.743 s, 14.743 s]	-361.0 ms (-2.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.934 s [14.934 s, 14.934 s]	-
appsec	15.076 s [15.076 s, 15.076 s]	142.0 ms (1.0%)
iast	18.828 s [18.828 s, 18.828 s]	3.894 s (26.1%)
iast_GLOBAL	17.678 s [17.678 s, 17.678 s]	2.744 s (18.4%)
profiling	15.013 s [15.013 s, 15.013 s]	79.0 ms (0.5%)
tracing	14.992 s [14.992 s, 14.992 s]	58.0 ms (0.4%)

…thSpan annotated method (#8019)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#8089](DataDog/dd-trace-java#8089) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#8044](DataDog/dd-trace-java#8044) - [@smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#8038](DataDog/dd-trace-java#8038) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#8026](DataDog/dd-trace-java#8026) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#8013](DataDog/dd-trace-java#8013) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#8010](DataDog/dd-trace-java#8010) - [@Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#8004](DataDog/dd-trace-java#8004) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#8078](DataDog/dd-trace-java#8078) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#8055](DataDog/dd-trace-java#8055) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#8033](DataDog/dd-trace-java#8033) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#8030](DataDog/dd-trace-java#8030) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#8045](DataDog/dd-trace-java#8045) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#8071](DataDog/dd-trace-java#8071) - [@piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#8051](DataDog/dd-trace-java#8051) - [@kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#8039](DataDog/dd-trace-java#8039) - [@jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#8021](DataDog/dd-trace-java#8021) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#8016](DataDog/dd-trace-java#8016) - [@evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#7942](DataDog/dd-trace-java#7942) - [@evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#8065](DataDog/dd-trace-java#8065) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#8036](DataDog/dd-trace-java#8036) - [@mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#8058](DataDog/dd-trace-java#8058) - [@mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#8064](DataDog/dd-trace-java#8064) - [@amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#8061](DataDog/dd-trace-java#8061) - [@amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#8040](DataDog/dd-trace-java#8040) - [@cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#8028](DataDog/dd-trace-java#8028) - [@mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#7973](DataDog/dd-trace-java#7973) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#7946](DataDog/dd-trace-java#7946) - [@smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#8043](DataDog/dd-trace-java#8043) - [@amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#7940](DataDog/dd-trace-java#7940) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#8062](DataDog/dd-trace-java#8062) - [@amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#8019](DataDog/dd-trace-java#8019) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#8005](DataDog/dd-trace-java#8005) - [@amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#8025](DataDog/dd-trace-java#8025) - [@amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#7981](DataDog/dd-trace-java#7981) - [@amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c

Fix missing OtelSpanEvent helper when using Event API from inside @Wi…

5f76fd2

…thSpan annotated method

mcculls added type: bug inst: opentelemetry OpenTelemetry instrumentation labels Nov 26, 2024

PerfectSlayer approved these changes Nov 26, 2024

View reviewed changes

mcculls marked this pull request as ready for review November 26, 2024 12:18

mcculls requested review from a team as code owners November 26, 2024 12:18

mcculls requested a review from nayeem-kamal November 26, 2024 12:18

amarziali reviewed Nov 26, 2024

View reviewed changes

...rc/main/java/datadog/trace/instrumentation/opentelemetry14/OpenTelemetryInstrumentation.java Show resolved Hide resolved

amarziali approved these changes Nov 26, 2024

View reviewed changes

mcculls merged commit b0bc9ed into master Nov 26, 2024
108 checks passed

mcculls deleted the mcculls/fix-missing-event-type-when-instrumenting-otel-withspan branch November 26, 2024 12:51

github-actions bot added this to the 1.44.0 milestone Nov 26, 2024

mcculls mentioned this pull request Nov 26, 2024

java.lang.NoClassDefFoundError: datadog/opentelemetry/shim/trace/OtelSpanEvent #8017

Closed

PerfectSlayer pushed a commit that referenced this pull request Nov 28, 2024

Fix missing OtelSpanEvent helper when using Event API from inside @Wi…

057c48b

…thSpan annotated method (#8019)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support using OpenTelemetry Event API inside `@WithSpan` annotated method #8019

Support using OpenTelemetry Event API inside `@WithSpan` annotated method #8019

mcculls commented Nov 26, 2024 •

edited

Loading

pr-commenter bot commented Nov 26, 2024

Support using OpenTelemetry Event API inside @WithSpan annotated method #8019

Support using OpenTelemetry Event API inside @WithSpan annotated method #8019

Conversation

mcculls commented Nov 26, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Nov 26, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Support using OpenTelemetry Event API inside `@WithSpan` annotated method #8019

Support using OpenTelemetry Event API inside `@WithSpan` annotated method #8019

mcculls commented Nov 26, 2024 •

edited

Loading