Instrument self hosted Kafka connectors #7959

piochelepiotr · 2024-11-14T17:40:37Z

What Does This Do

Instrument kafka-connect to update the service name to the connector name.
This can't be done by using DD_SERVICE because multiple connectors are run on the same work instance.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-11-18T22:36:18Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr-wolski/instrument-kafka-connectors
git_commit_date	1733862195	1733937302
git_commit_sha	`7afe313`	`67e1e7b`
release_version	1.44.0-SNAPSHOT~7afe313007	1.44.0-SNAPSHOT~67e1e7bce6

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1733939785	1733939785
ci_job_id	735263684	735263684
ci_pipeline_id	50860962	50860962
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~67e1e7bce6, baseline=1.44.0-SNAPSHOT~7afe313007

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.099 s) : 0, 1098943
Total [baseline] (8.662 s) : 0, 8662368
Agent [candidate] (1.092 s) : 0, 1092441
Total [candidate] (8.657 s) : 0, 8657056
section iast
Agent [baseline] (1.221 s) : 0, 1220674
Total [baseline] (9.179 s) : 0, 9179017
Agent [candidate] (1.221 s) : 0, 1221431
Total [candidate] (9.258 s) : 0, 9257967
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.219 s) : 0, 1219072
Total [baseline] (9.155 s) : 0, 9154613
Agent [candidate] (1.231 s) : 0, 1230813
Total [candidate] (9.16 s) : 0, 9159799
section iast_TELEMETRY_OFF
Agent [baseline] (1.213 s) : 0, 1213419
Total [baseline] (9.206 s) : 0, 9205502
Agent [candidate] (1.214 s) : 0, 1213891
Total [candidate] (9.164 s) : 0, 9164177

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.099 s	-
Agent	iast	1.221 s	121.731 ms (11.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.219 s	120.128 ms (10.9%)
Agent	iast_TELEMETRY_OFF	1.213 s	114.475 ms (10.4%)
Total	tracing	8.662 s	-
Total	iast	9.179 s	516.65 ms (6.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.155 s	492.246 ms (5.7%)
Total	iast_TELEMETRY_OFF	9.206 s	543.134 ms (6.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.092 s	-
Agent	iast	1.221 s	128.99 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.231 s	138.372 ms (12.7%)
Agent	iast_TELEMETRY_OFF	1.214 s	121.45 ms (11.1%)
Total	tracing	8.657 s	-
Total	iast	9.258 s	600.911 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.16 s	502.743 ms (5.8%)
Total	iast_TELEMETRY_OFF	9.164 s	507.12 ms (5.9%)

gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~67e1e7bce6, baseline=1.44.0-SNAPSHOT~7afe313007

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (702.376 ms) : 0, 702376
BytebuddyAgent [candidate] (696.094 ms) : 0, 696094
GlobalTracer [baseline] (317.476 ms) : 0, 317476
GlobalTracer [candidate] (317.397 ms) : 0, 317397
AppSec [baseline] (54.685 ms) : 0, 54685
AppSec [candidate] (54.554 ms) : 0, 54554
Remote Config [baseline] (690.364 µs) : 0, 690
Remote Config [candidate] (681.457 µs) : 0, 681
Telemetry [baseline] (9.79 ms) : 0, 9790
Telemetry [candidate] (9.929 ms) : 0, 9929
section iast
BytebuddyAgent [baseline] (814.461 ms) : 0, 814461
BytebuddyAgent [candidate] (813.934 ms) : 0, 813934
GlobalTracer [baseline] (305.331 ms) : 0, 305331
GlobalTracer [candidate] (306.017 ms) : 0, 306017
AppSec [baseline] (57.879 ms) : 0, 57879
AppSec [candidate] (55.802 ms) : 0, 55802
Remote Config [baseline] (645.227 µs) : 0, 645
Remote Config [candidate] (645.411 µs) : 0, 645
Telemetry [baseline] (7.556 ms) : 0, 7556
Telemetry [candidate] (7.554 ms) : 0, 7554
IAST [baseline] (21.05 ms) : 0, 21050
IAST [candidate] (23.664 ms) : 0, 23664
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (812.196 ms) : 0, 812196
BytebuddyAgent [candidate] (820.76 ms) : 0, 820760
GlobalTracer [baseline] (305.726 ms) : 0, 305726
GlobalTracer [candidate] (307.725 ms) : 0, 307725
AppSec [baseline] (56.549 ms) : 0, 56549
AppSec [candidate] (57.934 ms) : 0, 57934
Remote Config [baseline] (632.36 µs) : 0, 632
Remote Config [candidate] (642.015 µs) : 0, 642
Telemetry [baseline] (7.584 ms) : 0, 7584
Telemetry [candidate] (7.59 ms) : 0, 7590
IAST [baseline] (22.629 ms) : 0, 22629
IAST [candidate] (22.288 ms) : 0, 22288
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.486 ms) : 0, 807486
BytebuddyAgent [candidate] (808.238 ms) : 0, 808238
GlobalTracer [baseline] (305.036 ms) : 0, 305036
GlobalTracer [candidate] (305.084 ms) : 0, 305084
AppSec [baseline] (57.537 ms) : 0, 57537
AppSec [candidate] (58.237 ms) : 0, 58237
Remote Config [baseline] (642.509 µs) : 0, 643
Remote Config [candidate] (647.693 µs) : 0, 648
Telemetry [baseline] (7.574 ms) : 0, 7574
Telemetry [candidate] (7.46 ms) : 0, 7460
IAST [baseline] (21.419 ms) : 0, 21419
IAST [candidate] (20.459 ms) : 0, 20459

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~67e1e7bce6, baseline=1.44.0-SNAPSHOT~7afe313007

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.099 s) : 0, 1098914
Total [baseline] (10.423 s) : 0, 10422505
Agent [candidate] (1.092 s) : 0, 1092313
Total [candidate] (10.49 s) : 0, 10489941
section appsec
Agent [baseline] (1.227 s) : 0, 1227231
Total [baseline] (10.722 s) : 0, 10722136
Agent [candidate] (1.238 s) : 0, 1237922
Total [candidate] (10.723 s) : 0, 10723398
section iast
Agent [baseline] (1.218 s) : 0, 1217950
Total [baseline] (10.901 s) : 0, 10901230
Agent [candidate] (1.231 s) : 0, 1231042
Total [candidate] (10.954 s) : 0, 10954223
section profiling
Agent [baseline] (1.318 s) : 0, 1318169
Total [baseline] (10.764 s) : 0, 10763896
Agent [candidate] (1.325 s) : 0, 1324725
Total [candidate] (10.824 s) : 0, 10823650

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.099 s	-
Agent	appsec	1.227 s	128.317 ms (11.7%)
Agent	iast	1.218 s	119.036 ms (10.8%)
Agent	profiling	1.318 s	219.255 ms (20.0%)
Total	tracing	10.423 s	-
Total	appsec	10.722 s	299.631 ms (2.9%)
Total	iast	10.901 s	478.725 ms (4.6%)
Total	profiling	10.764 s	341.391 ms (3.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.092 s	-
Agent	appsec	1.238 s	145.609 ms (13.3%)
Agent	iast	1.231 s	138.729 ms (12.7%)
Agent	profiling	1.325 s	232.412 ms (21.3%)
Total	tracing	10.49 s	-
Total	appsec	10.723 s	233.457 ms (2.2%)
Total	iast	10.954 s	464.282 ms (4.4%)
Total	profiling	10.824 s	333.709 ms (3.2%)

gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~67e1e7bce6, baseline=1.44.0-SNAPSHOT~7afe313007

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (699.374 ms) : 0, 699374
BytebuddyAgent [candidate] (694.514 ms) : 0, 694514
GlobalTracer [baseline] (318.993 ms) : 0, 318993
GlobalTracer [candidate] (316.944 ms) : 0, 316944
AppSec [baseline] (55.257 ms) : 0, 55257
AppSec [candidate] (55.118 ms) : 0, 55118
Remote Config [baseline] (687.91 µs) : 0, 688
Remote Config [candidate] (690.164 µs) : 0, 690
Telemetry [baseline] (10.784 ms) : 0, 10784
Telemetry [candidate] (11.32 ms) : 0, 11320
section appsec
BytebuddyAgent [baseline] (712.485 ms) : 0, 712485
BytebuddyAgent [candidate] (719.904 ms) : 0, 719904
GlobalTracer [baseline] (314.938 ms) : 0, 314938
GlobalTracer [candidate] (317.064 ms) : 0, 317064
AppSec [baseline] (167.645 ms) : 0, 167645
AppSec [candidate] (168.09 ms) : 0, 168090
IAST [baseline] (19.904 ms) : 0, 19904
IAST [candidate] (20.16 ms) : 0, 20160
Remote Config [baseline] (657.201 µs) : 0, 657
Remote Config [candidate] (674.627 µs) : 0, 675
Telemetry [baseline] (7.794 ms) : 0, 7794
Telemetry [candidate] (8.241 ms) : 0, 8241
section iast
BytebuddyAgent [baseline] (811.736 ms) : 0, 811736
BytebuddyAgent [candidate] (819.941 ms) : 0, 819941
GlobalTracer [baseline] (305.493 ms) : 0, 305493
GlobalTracer [candidate] (309.034 ms) : 0, 309034
AppSec [baseline] (57.053 ms) : 0, 57053
AppSec [candidate] (58.645 ms) : 0, 58645
IAST [baseline] (21.815 ms) : 0, 21815
IAST [candidate] (21.254 ms) : 0, 21254
Remote Config [baseline] (621.102 µs) : 0, 621
Remote Config [candidate] (650.642 µs) : 0, 651
Telemetry [baseline] (7.513 ms) : 0, 7513
Telemetry [candidate] (7.657 ms) : 0, 7657
section profiling
BytebuddyAgent [baseline] (689.477 ms) : 0, 689477
BytebuddyAgent [candidate] (693.149 ms) : 0, 693149
GlobalTracer [baseline] (433.578 ms) : 0, 433578
GlobalTracer [candidate] (435.536 ms) : 0, 435536
AppSec [baseline] (53.744 ms) : 0, 53744
AppSec [candidate] (54.063 ms) : 0, 54063
Remote Config [baseline] (666.997 µs) : 0, 667
Remote Config [candidate] (661.466 µs) : 0, 661
Telemetry [baseline] (7.83 ms) : 0, 7830
Telemetry [candidate] (7.727 ms) : 0, 7727
ProfilingAgent [baseline] (93.774 ms) : 0, 93774
ProfilingAgent [candidate] (94.239 ms) : 0, 94239
Profiling [baseline] (93.798 ms) : 0, 93798
Profiling [candidate] (94.262 ms) : 0, 94262

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-11T17:26:35	2024-12-11T17:33:35
git_branch	master	piotr-wolski/instrument-kafka-connectors
git_commit_date	1733862195	1733937302
git_commit_sha	`7afe313`	`67e1e7b`
release_version	1.44.0-SNAPSHOT~7afe313007	1.44.0-SNAPSHOT~67e1e7bce6
start_time	2024-12-11T17:26:22	2024-12-11T17:33:21

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1733938767	1733938767
ci_job_id	735263685	735263685
ci_pipeline_id	50860962	50860962
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~67e1e7bce6, baseline=1.44.0-SNAPSHOT~7afe313007
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1369
.   : milestone, 1349,
appsec (1.773 ms) : 1749, 1797
.   : milestone, 1773,
appsec_no_iast (1.759 ms) : 1734, 1784
.   : milestone, 1759,
iast (1.493 ms) : 1470, 1516
.   : milestone, 1493,
profiling (1.503 ms) : 1480, 1527
.   : milestone, 1503,
tracing (1.46 ms) : 1434, 1486
.   : milestone, 1460,
section candidate
no_agent (1.348 ms) : 1328, 1367
.   : milestone, 1348,
appsec (1.741 ms) : 1718, 1764
.   : milestone, 1741,
appsec_no_iast (1.762 ms) : 1735, 1789
.   : milestone, 1762,
iast (1.497 ms) : 1475, 1520
.   : milestone, 1497,
profiling (1.522 ms) : 1498, 1547
.   : milestone, 1522,
tracing (1.488 ms) : 1464, 1513
.   : milestone, 1488,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.349 ms [1.329 ms, 1.369 ms]	-
appsec	1.773 ms [1.749 ms, 1.797 ms]	424.354 µs (31.5%)
appsec_no_iast	1.759 ms [1.734 ms, 1.784 ms]	410.222 µs (30.4%)
iast	1.493 ms [1.47 ms, 1.516 ms]	144.062 µs (10.7%)
profiling	1.503 ms [1.48 ms, 1.527 ms]	154.176 µs (11.4%)
tracing	1.46 ms [1.434 ms, 1.486 ms]	111.41 µs (8.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.348 ms [1.328 ms, 1.367 ms]	-
appsec	1.741 ms [1.718 ms, 1.764 ms]	393.464 µs (29.2%)
appsec_no_iast	1.762 ms [1.735 ms, 1.789 ms]	414.092 µs (30.7%)
iast	1.497 ms [1.475 ms, 1.52 ms]	149.721 µs (11.1%)
profiling	1.522 ms [1.498 ms, 1.547 ms]	174.763 µs (13.0%)
tracing	1.488 ms [1.464 ms, 1.513 ms]	140.941 µs (10.5%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~67e1e7bce6, baseline=1.44.0-SNAPSHOT~7afe313007
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.038 µs) : 350, 390
.   : milestone, 370,
iast (492.593 µs) : 471, 514
.   : milestone, 493,
iast_FULL (656.388 µs) : 635, 678
.   : milestone, 656,
iast_GLOBAL (521.544 µs) : 500, 543
.   : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (493.901 µs) : 473, 515
.   : milestone, 494,
iast_INACTIVE (457.384 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (483.49 µs) : 462, 505
.   : milestone, 483,
tracing (451.133 µs) : 430, 472
.   : milestone, 451,
section candidate
no_agent (379.803 µs) : 360, 400
.   : milestone, 380,
iast (492.977 µs) : 471, 515
.   : milestone, 493,
iast_FULL (653.912 µs) : 632, 675
.   : milestone, 654,
iast_GLOBAL (515.5 µs) : 494, 537
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (492.048 µs) : 471, 513
.   : milestone, 492,
iast_INACTIVE (449.961 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (486.565 µs) : 465, 508
.   : milestone, 487,
tracing (451.819 µs) : 431, 473
.   : milestone, 452,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	370.038 µs [349.898 µs, 390.178 µs]	-
iast	492.593 µs [470.964 µs, 514.222 µs]	122.555 µs (33.1%)
iast_FULL	656.388 µs [634.766 µs, 678.01 µs]	286.35 µs (77.4%)
iast_GLOBAL	521.544 µs [500.059 µs, 543.029 µs]	151.505 µs (40.9%)
iast_HARDCODED_SECRET_DISABLED	493.901 µs [472.793 µs, 515.009 µs]	123.863 µs (33.5%)
iast_INACTIVE	457.384 µs [436.453 µs, 478.315 µs]	87.346 µs (23.6%)
iast_TELEMETRY_OFF	483.49 µs [461.732 µs, 505.247 µs]	113.451 µs (30.7%)
tracing	451.133 µs [430.171 µs, 472.095 µs]	81.094 µs (21.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.803 µs [359.947 µs, 399.66 µs]	-
iast	492.977 µs [471.1 µs, 514.854 µs]	113.173 µs (29.8%)
iast_FULL	653.912 µs [632.376 µs, 675.448 µs]	274.108 µs (72.2%)
iast_GLOBAL	515.5 µs [493.904 µs, 537.096 µs]	135.697 µs (35.7%)
iast_HARDCODED_SECRET_DISABLED	492.048 µs [470.738 µs, 513.357 µs]	112.244 µs (29.6%)
iast_INACTIVE	449.961 µs [429.138 µs, 470.784 µs]	70.158 µs (18.5%)
iast_TELEMETRY_OFF	486.565 µs [464.814 µs, 508.316 µs]	106.762 µs (28.1%)
tracing	451.819 µs [430.907 µs, 472.731 µs]	72.015 µs (19.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr-wolski/instrument-kafka-connectors
git_commit_date	1733862195	1733937302
git_commit_sha	`7afe313`	`67e1e7b`
release_version	1.44.0-SNAPSHOT~7afe313007	1.44.0-SNAPSHOT~67e1e7bce6

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1733939204	1733939204
ci_job_id	735263686	735263686
ci_pipeline_id	50860962	50860962
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~67e1e7bce6, baseline=1.44.0-SNAPSHOT~7afe313007
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (2.351 ms) : 2309, 2392
.   : milestone, 2351,
iast (2.101 ms) : 2048, 2154
.   : milestone, 2101,
iast_GLOBAL (2.145 ms) : 2091, 2198
.   : milestone, 2145,
profiling (1.982 ms) : 1939, 2026
.   : milestone, 1982,
tracing (1.94 ms) : 1899, 1981
.   : milestone, 1940,
section candidate
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.348 ms) : 2307, 2390
.   : milestone, 2348,
iast (2.109 ms) : 2056, 2162
.   : milestone, 2109,
iast_GLOBAL (2.149 ms) : 2095, 2203
.   : milestone, 2149,
profiling (2.471 ms) : 2281, 2662
.   : milestone, 2471,
tracing (1.941 ms) : 1900, 1982
.   : milestone, 1941,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.477 ms [1.465 ms, 1.488 ms]	-
appsec	2.351 ms [2.309 ms, 2.392 ms]	874.066 µs (59.2%)
iast	2.101 ms [2.048 ms, 2.154 ms]	624.251 µs (42.3%)
iast_GLOBAL	2.145 ms [2.091 ms, 2.198 ms]	668.306 µs (45.3%)
profiling	1.982 ms [1.939 ms, 2.026 ms]	505.469 µs (34.2%)
tracing	1.94 ms [1.899 ms, 1.981 ms]	463.466 µs (31.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	2.348 ms [2.307 ms, 2.39 ms]	877.803 µs (59.7%)
iast	2.109 ms [2.056 ms, 2.162 ms]	638.508 µs (43.4%)
iast_GLOBAL	2.149 ms [2.095 ms, 2.203 ms]	678.634 µs (46.2%)
profiling	2.471 ms [2.281 ms, 2.662 ms]	1.001 ms (68.1%)
tracing	1.941 ms [1.9 ms, 1.982 ms]	470.648 µs (32.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~67e1e7bce6, baseline=1.44.0-SNAPSHOT~7afe313007
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.895 s) : 14895000, 14895000
.   : milestone, 14895000,
appsec (15.061 s) : 15061000, 15061000
.   : milestone, 15061000,
iast (18.881 s) : 18881000, 18881000
.   : milestone, 18881000,
iast_GLOBAL (17.851 s) : 17851000, 17851000
.   : milestone, 17851000,
profiling (15.15 s) : 15150000, 15150000
.   : milestone, 15150000,
tracing (15.161 s) : 15161000, 15161000
.   : milestone, 15161000,
section candidate
no_agent (15.453 s) : 15453000, 15453000
.   : milestone, 15453000,
appsec (14.934 s) : 14934000, 14934000
.   : milestone, 14934000,
iast (19.204 s) : 19204000, 19204000
.   : milestone, 19204000,
iast_GLOBAL (17.99 s) : 17990000, 17990000
.   : milestone, 17990000,
profiling (14.805 s) : 14805000, 14805000
.   : milestone, 14805000,
tracing (14.977 s) : 14977000, 14977000
.   : milestone, 14977000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.895 s [14.895 s, 14.895 s]	-
appsec	15.061 s [15.061 s, 15.061 s]	166.0 ms (1.1%)
iast	18.881 s [18.881 s, 18.881 s]	3.986 s (26.8%)
iast_GLOBAL	17.851 s [17.851 s, 17.851 s]	2.956 s (19.8%)
profiling	15.15 s [15.15 s, 15.15 s]	255.0 ms (1.7%)
tracing	15.161 s [15.161 s, 15.161 s]	266.0 ms (1.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.453 s [15.453 s, 15.453 s]	-
appsec	14.934 s [14.934 s, 14.934 s]	-519.0 ms (-3.4%)
iast	19.204 s [19.204 s, 19.204 s]	3.751 s (24.3%)
iast_GLOBAL	17.99 s [17.99 s, 17.99 s]	2.537 s (16.4%)
profiling	14.805 s [14.805 s, 14.805 s]	-648.0 ms (-4.2%)
tracing	14.977 s [14.977 s, 14.977 s]	-476.0 ms (-3.1%)

pr-commenter · 2024-12-11T01:18:06Z

Kafka / producer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr-wolski/instrument-kafka-connectors
git_commit_date	1733862195	1733937302
git_commit_sha	`7afe313`	`67e1e7b`

See matching parameters

	Baseline	Candidate
ci_job_date	1733938397	1733938397
ci_job_id	735263688	735263688
ci_pipeline_id	50860962	50860962
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce	same

pr-commenter · 2024-12-11T01:33:24Z

Kafka / consumer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	piotr-wolski/instrument-kafka-connectors
git_commit_date	1733862195	1733937302
git_commit_sha	`7afe313`	`67e1e7b`

See matching parameters

	Baseline	Candidate
ci_job_date	1733938424	1733938424
ci_job_id	735263689	735263689
ci_pipeline_id	50860962	50860962
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same

vandonr · 2024-12-11T15:56:58Z

...fka-connect-0.11/src/main/java/datadog/trace/instrumentation/kafka_connect/TaskListener.java

+    delegate.onResume(connectorTaskId);
+    AgentTracer.get().getDataStreamsMonitoring().setThreadServiceName(connectorTaskId.connector());


shouldn't those two lines be swapped to match the onStartup callback that makes sure the thread service name is set for the original delegate call ?

Makes sense! Updated.

PerfectSlayer · 2024-12-11T16:16:32Z

settings.gradle

@@ -349,6 +349,7 @@ include ':dd-java-agent:instrumentation:kafka-clients-0.11'
 include 'dd-java-agent:instrumentation:kafka-clients-3.8'
 include ':dd-java-agent:instrumentation:kafka-streams-0.11'
 include ':dd-java-agent:instrumentation:kafka-streams-1.0'
+include ':dd-java-agent:instrumentation:kafka-connect-0.11'


Nitpick: can you keep them sorted alphabetically?

And fix include 'dd-java-agent:instrumentation:kafka-clients-3.8' into include ':dd-java-agent:instrumentation:kafka-clients-3.8' while you're updating it 😇

Sure!
I sorted the Java includes & fixed kafka-clients-3.8

amarziali · 2024-12-11T16:29:16Z

...fka-connect-0.11/src/main/java/datadog/trace/instrumentation/kafka_connect/TaskListener.java

+  @Override
+  public void onPause(ConnectorTaskId connectorTaskId) {
+    delegate.onPause(connectorTaskId);
+    AgentTracer.get().getDataStreamsMonitoring().clearThreadServiceName();


those should perhaps be in a try-finally block to ensure the clear is always called. (same for the other onXXX below. Example:

try { delegate.onPause(connectorTaskId); } finally { AgentTracer.get().getDataStreamsMonitoring().clearThreadServiceName(); }```

Makes sense. I updated them

amarziali · 2024-12-11T16:31:19Z

dd-java-agent/instrumentation/kafka-connect-0.11/build.gradle

+  testImplementation 'org.apache.kafka:kafka-clients:2.7.0'
+  // Spring Kafka Test library
+  testImplementation 'org.springframework.kafka:spring-kafka-test:2.7.9'  // Version compatible with Kafka 2.7.x
+  testRuntimeOnly project(':dd-java-agent:instrumentation:kafka-clients-0.11')


could you please also add testRuntimeOnly project(':dd-java-agent:instrumentation:kafka-clients-3.8') ?

Same for kafka-streams-0.11 and kafka-streams-1.0 just in case to test interactions

I added them here. They should not be applied. Is that OK?

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#8089](DataDog/dd-trace-java#8089) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#8044](DataDog/dd-trace-java#8044) - [@smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#8038](DataDog/dd-trace-java#8038) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#8026](DataDog/dd-trace-java#8026) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#8013](DataDog/dd-trace-java#8013) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#8010](DataDog/dd-trace-java#8010) - [@Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#8004](DataDog/dd-trace-java#8004) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#8078](DataDog/dd-trace-java#8078) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#8055](DataDog/dd-trace-java#8055) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#8033](DataDog/dd-trace-java#8033) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#8030](DataDog/dd-trace-java#8030) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#8045](DataDog/dd-trace-java#8045) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#8071](DataDog/dd-trace-java#8071) - [@piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#8051](DataDog/dd-trace-java#8051) - [@kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#8039](DataDog/dd-trace-java#8039) - [@jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#8021](DataDog/dd-trace-java#8021) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#8016](DataDog/dd-trace-java#8016) - [@evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#7942](DataDog/dd-trace-java#7942) - [@evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#8065](DataDog/dd-trace-java#8065) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#8036](DataDog/dd-trace-java#8036) - [@mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#8058](DataDog/dd-trace-java#8058) - [@mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#8064](DataDog/dd-trace-java#8064) - [@amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#8061](DataDog/dd-trace-java#8061) - [@amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#8040](DataDog/dd-trace-java#8040) - [@cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#8028](DataDog/dd-trace-java#8028) - [@mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#7973](DataDog/dd-trace-java#7973) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#7946](DataDog/dd-trace-java#7946) - [@smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#8043](DataDog/dd-trace-java#8043) - [@amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#7940](DataDog/dd-trace-java#7940) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#8062](DataDog/dd-trace-java#8062) - [@amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#8019](DataDog/dd-trace-java#8019) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#8005](DataDog/dd-trace-java#8005) - [@amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#8025](DataDog/dd-trace-java#8025) - [@amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#7981](DataDog/dd-trace-java#7981) - [@amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c

piochelepiotr force-pushed the piotr-wolski/instrument-kafka-connectors branch 2 times, most recently from ff9bbf2 to 0127246 Compare November 18, 2024 21:53

piochelepiotr force-pushed the piotr-wolski/instrument-kafka-connectors branch 3 times, most recently from dbde642 to 7f4de37 Compare December 11, 2024 00:42

Add kafka connect instrumentation

e64755b

piochelepiotr force-pushed the piotr-wolski/instrument-kafka-connectors branch from 7f4de37 to e64755b Compare December 11, 2024 00:42

piochelepiotr added the comp: data streams Data Streams Monitoring label Dec 11, 2024

piochelepiotr added this to the 1.44.0 milestone Dec 11, 2024

piochelepiotr added inst: kafka Kafka instrumentation type: feature request labels Dec 11, 2024

piochelepiotr changed the title ~~Piotr wolski/instrument kafka connectors~~ Instrument self hosted Kafka connectors Dec 11, 2024

piochelepiotr marked this pull request as ready for review December 11, 2024 00:45

piochelepiotr requested review from a team as code owners December 11, 2024 00:45

piochelepiotr requested a review from nayeem-kamal December 11, 2024 00:45

muzzle instrumentation before 0.11

d043275

vandonr reviewed Dec 11, 2024

View reviewed changes

update service name in right order

65c3925

piochelepiotr requested a review from vandonr December 11, 2024 16:10

PerfectSlayer reviewed Dec 11, 2024

View reviewed changes

sort gradle includes

63200d6

piochelepiotr requested a review from PerfectSlayer December 11, 2024 16:24

amarziali reviewed Dec 11, 2024

View reviewed changes

Put delegate calls in try / finally

67e1e7b

vandonr approved these changes Dec 11, 2024

View reviewed changes

piochelepiotr merged commit aa7092b into master Dec 11, 2024
152 checks passed

piochelepiotr deleted the piotr-wolski/instrument-kafka-connectors branch December 11, 2024 19:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Instrument self hosted Kafka connectors #7959

Instrument self hosted Kafka connectors #7959

piochelepiotr commented Nov 14, 2024 •

edited

Loading

pr-commenter bot commented Nov 18, 2024 •

edited

Loading

pr-commenter bot commented Dec 11, 2024 •

edited

Loading

pr-commenter bot commented Dec 11, 2024 •

edited

Loading

vandonr Dec 11, 2024

piochelepiotr Dec 11, 2024

PerfectSlayer Dec 11, 2024

piochelepiotr Dec 11, 2024

amarziali Dec 11, 2024

piochelepiotr Dec 11, 2024

amarziali Dec 11, 2024

amarziali Dec 11, 2024

piochelepiotr Dec 11, 2024

		delegate.onResume(connectorTaskId);
		AgentTracer.get().getDataStreamsMonitoring().setThreadServiceName(connectorTaskId.connector());

Instrument self hosted Kafka connectors #7959

Instrument self hosted Kafka connectors #7959

Conversation

piochelepiotr commented Nov 14, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Nov 18, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

pr-commenter bot commented Dec 11, 2024 • edited Loading

Kafka / producer-benchmark

Parameters

Summary

pr-commenter bot commented Dec 11, 2024 • edited Loading

Kafka / consumer-benchmark

Parameters

Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

piochelepiotr commented Nov 14, 2024 •

edited

Loading

pr-commenter bot commented Nov 18, 2024 •

edited

Loading

pr-commenter bot commented Dec 11, 2024 •

edited

Loading

pr-commenter bot commented Dec 11, 2024 •

edited

Loading