-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appsec: update the security event rules to v1.8.0 #2312
Conversation
9a503db
to
a53c8c8
Compare
BenchmarksBenchmark execution time: 2023-10-30 17:22:37 Comparing candidate commit 589e224 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Nit: I'm not sure about the import aliasing. The package is bound to export more functions that are not related to rules. A simple internal
may reduce future confusion. Thoughts?
Also, here is a system-tests run with this PR and the system-tests one combined: https://github.com/DataDog/dd-trace-go/actions/runs/6695124720
Signed-off-by: Eliott Bouhana <[email protected]>
a53c8c8
to
589e224
Compare
Pull Request is not mergeable
What does this PR do?
This PR follows up on DataDog/appsec-internal-go#8 to upgrade the recommended appsec ruleset to all location where it is used.
Moreover this PR removes the previous ruleset location which was directly in
internal/appsec/
in favor of the one in appsec-internal-goMotivation
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!