Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec: update the security event rules to v1.8.0 #2312

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

eliottness
Copy link
Contributor

What does this PR do?

This PR follows up on DataDog/appsec-internal-go#8 to upgrade the recommended appsec ruleset to all location where it is used.

Moreover this PR removes the previous ruleset location which was directly in internal/appsec/ in favor of the one in appsec-internal-go

Motivation

  1. ASM customers can benefit from the up-to-date the datadog recommended ruleset.
  2. Having the ruleset at 2 locations is unnecessary.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@eliottness eliottness requested review from a team as code owners October 30, 2023 14:30
internal/appsec/rules_manager.go Show resolved Hide resolved
internal/appsec/rules_manager.go Show resolved Hide resolved
internal/appsec/rules_manager.go Show resolved Hide resolved
internal/appsec/config_test.go Show resolved Hide resolved
internal/appsec/config_test.go Show resolved Hide resolved
internal/appsec/rules_manager.go Show resolved Hide resolved
internal/appsec/config_test.go Show resolved Hide resolved
internal/appsec/config_test.go Show resolved Hide resolved
internal/appsec/rules_manager.go Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2023

Benchmarks

Benchmark execution time: 2023-10-30 17:22:37

Comparing candidate commit 589e224 in PR branch eliott.bouhana/APPSEC-11819 with baseline commit 1e7a3e0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

Copy link
Contributor

@Hellzy Hellzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Nit: I'm not sure about the import aliasing. The package is bound to export more functions that are not related to rules. A simple internal may reduce future confusion. Thoughts?

Also, here is a system-tests run with this PR and the system-tests one combined: https://github.com/DataDog/dd-trace-go/actions/runs/6695124720

@eliottness eliottness enabled auto-merge (squash) October 30, 2023 17:07
@eliottness eliottness force-pushed the eliott.bouhana/APPSEC-11819 branch from a53c8c8 to 589e224 Compare October 30, 2023 17:08
auto-merge was automatically disabled October 30, 2023 17:15

Pull Request is not mergeable

@Julio-Guerra Julio-Guerra merged commit 7f31c76 into main Oct 30, 2023
341 of 342 checks passed
@Julio-Guerra Julio-Guerra deleted the eliott.bouhana/APPSEC-11819 branch October 30, 2023 19:22
@darccio darccio restored the eliott.bouhana/APPSEC-11819 branch November 16, 2023 09:55
@darccio darccio deleted the eliott.bouhana/APPSEC-11819 branch November 16, 2023 09:58
@Julio-Guerra Julio-Guerra changed the title appsec: upgrade appsec-internal-go 1.0.0 -> 1.0.1 appsec: update the security event rules to v1.8.0 Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants