build: go: switch rules location #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recommended ruleset was moved from dd-trace-go/internal/appsec/rules.json to appsec-internal-go/appsec/rules.json. Since this script references the rules location to extract its version, we need to modify it
|
Linking the system-tests run of this change plus the dd-trace-go one combined here as well: https://github.com/DataDog/dd-trace-go/actions/runs/6695124720 |
Julio-Guerra
approved these changes
Oct 30, 2023
|
is it working when the rules is specified threw env var ? |
No it doesn't - how do you do it in other libs? |
|
nevermind, it's handled after the script modified in this PR. As long as the file SYSTEM_TESTS_APPSEC_EVENT_RULES_VERSION is present it's ok. Though, for later PR that modify weblogs, it's a good habit to run all scenarios ( |
DDJavierSantos
pushed a commit
that referenced
this pull request
Nov 2, 2023
* build: go: switch rules location The recommended ruleset was moved from dd-trace-go/internal/appsec/rules.json to appsec-internal-go/appsec/rules.json. Since this script references the rules location to extract its version, we need to modify it * add appsec-internal-go as contigent when the ruleset is not available in dd-trace-go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recommended ruleset was moved from dd-trace-go/internal/appsec/rules.json to appsec-internal-go/appsec/rules.json (blocked by DataDog/dd-trace-go#2312). Since this script references the rules location to extract its version so we need to modify it.
Motivation
We are moving the recommended ruleset from dd-trace-go to appsec-internal-go to centralize some code between the datadog-agent repo and the dd-trace-go repo.
Workflow
Once your PR is reviewed, you can merge it! ❤️
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...). If this PR modifies any system-tests internal, then add therun-all-scenarioslabel (more info).build-some-imagelabel is present