Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1871: Create 1.1.1 beta v9 release candidate #1872

Merged
merged 122 commits into from
Jul 18, 2022
Merged

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Jul 18, 2022

fixes #1871

This brings all the recent changes from develop into main.

cz4rs added 30 commits May 30, 2022 10:45
- use single proxy underneath
- use proxy bits to create proxy
Jakub Strzebonski and others added 17 commits July 4, 2022 10:32
I have not tested this as the compiler is failing
on a different .o file each run. I will set up the
changes needed in the vt-ci as well, but I don't
expect I will get it tested before leaving for vacation.
Note that use of a ctest script might  have been
a better pattern, but both are claimed to work in
the documentation.
Despite the documentation, the inclusion of ctest
calls in the cmake script was doing the build and
test, but not submitting anything to CDash. This moves
to a ctest script called using the -S flag. I am still
seeing test failures due to overloading, but it seems to
be caused by the test definitions itself. All the example
scripts use the macro add_test_for_example_vt which does
set the PROCESSORS property, but other tests use the add_test
macro directly and do not set the number of processors.
I found this by looking at the generated CTestTestfile.cmake
files.
Hopefully this will keep us from overloading the
nodes as badly as we currently are.
#1856: This adds a script to run the build and test using cmake
…itlab-ci-build-fails

1869 Avoid testing when gitlab CI build fails
@cz4rs cz4rs linked an issue Jul 18, 2022 that may be closed by this pull request
@cz4rs cz4rs marked this pull request as ready for review July 18, 2022 08:55
@github-actions
Copy link

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for 41a66fb

Compilation - successful

Testing - passed

Build log


Copy link
Collaborator

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nlslatt nlslatt merged commit 8edc7d3 into main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port #1851 to a release
7 participants