-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1871: Create 1.1.1 beta v9
release candidate
#1872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use single proxy underneath - use proxy bits to create proxy
#1763 build only ready prs
I have not tested this as the compiler is failing on a different .o file each run. I will set up the changes needed in the vt-ci as well, but I don't expect I will get it tested before leaving for vacation. Note that use of a ctest script might have been a better pattern, but both are claimed to work in the documentation.
Despite the documentation, the inclusion of ctest calls in the cmake script was doing the build and test, but not submitting anything to CDash. This moves to a ctest script called using the -S flag. I am still seeing test failures due to overloading, but it seems to be caused by the test definitions itself. All the example scripts use the macro add_test_for_example_vt which does set the PROCESSORS property, but other tests use the add_test macro directly and do not set the number of processors. I found this by looking at the generated CTestTestfile.cmake files.
Hopefully this will keep us from overloading the nodes as badly as we currently are.
#1856: This adds a script to run the build and test using cmake
…itlab-ci-build-fails 1869 Avoid testing when gitlab CI build fails
cz4rs
requested review from
nlslatt,
jstrzebonski,
JacobDomagala,
lifflander,
nmm0,
PhilMiller,
stmcgovern and
thearusable
July 18, 2022 08:55
nlslatt
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1871
This brings all the recent changes from
develop
intomain
.