Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run CI automatically when PR is not in draft mode #1763

Closed
lifflander opened this issue May 4, 2022 · 0 comments · Fixed by #1785
Closed

Only run CI automatically when PR is not in draft mode #1763

lifflander opened this issue May 4, 2022 · 0 comments · Fixed by #1785
Assignees
@jstrzebonski
Labels
type: task

Comments

@lifflander
Copy link
Collaborator

What Needs to be Done?

  • Instead of always running on a push, only run if not in draft mode.
  • Make sure we are cancelling workflows when new code is pushed
  • Maybe allow an override comment for PRs in draft mode
jstrzebonski pushed a commit that referenced this issue May 9, 2022
#1763 unsure build auto-cancel is turned on
87a9e32
jstrzebonski pushed a commit that referenced this issue May 9, 2022
#1763 don't build PR drafts
2f4af90
@jstrzebonski jstrzebonski mentioned this issue May 9, 2022
Merged
6 tasks
jstrzebonski pushed a commit that referenced this issue May 9, 2022
#1763 ensure build auto-cancel is turned on
ae41e12
jstrzebonski pushed a commit that referenced this issue May 9, 2022
#1763 don't build PR drafts
f9a83d3
jstrzebonski pushed a commit that referenced this issue May 9, 2022
#1763 run gcc-12 pipeline for PR drafts
5c907a6
jstrzebonski pushed a commit that referenced this issue May 9, 2022
#1763 ensure build auto-cancel is turned on
461419e
jstrzebonski pushed a commit that referenced this issue May 9, 2022
#1763 don't build PR drafts
6df6ab6
jstrzebonski pushed a commit that referenced this issue May 9, 2022
#1763 run gcc-12 pipeline for PR drafts
72a978a
@lifflander lifflander mentioned this issue May 10, 2022
Open
jstrzebonski pushed a commit that referenced this issue May 11, 2022
#1763 ensure build auto-cancel is turned on
3606967
jstrzebonski pushed a commit that referenced this issue May 11, 2022
#1763 don't build PR drafts
f24d205
jstrzebonski pushed a commit that referenced this issue May 11, 2022
#1763 run gcc-12 pipeline for PR drafts
85aa69d
jstrzebonski pushed a commit that referenced this issue May 11, 2022
#1763 don't run macOS build if PR is not ready for review
ab06be3
jstrzebonski pushed a commit that referenced this issue May 11, 2022
#1763 add label that forces building a PR even in draft mode
947823c
jstrzebonski pushed a commit that referenced this issue May 11, 2022
#1763 add label that forces building a PR even in draft mode
0e2ee1e
jstrzebonski pushed a commit that referenced this issue May 17, 2022
#1763 ensure build auto-cancel is turned on
a09279e
jstrzebonski pushed a commit that referenced this issue May 17, 2022
#1763 don't build PR drafts
c33246c
jstrzebonski pushed a commit that referenced this issue May 17, 2022
#1763 run gcc-12 pipeline for PR drafts
8bcb450
jstrzebonski pushed a commit that referenced this issue May 17, 2022
#1763 don't run macOS build if PR is not ready for review
6c1bccb
jstrzebonski pushed a commit that referenced this issue May 17, 2022
#1763 add label that forces building a PR even in draft mode
1e15705
jstrzebonski pushed a commit that referenced this issue May 20, 2022
#1763 ensure build auto-cancel is turned on
2e02ecd
jstrzebonski pushed a commit that referenced this issue May 20, 2022
#1763 don't build PR drafts
26a7fef
jstrzebonski pushed a commit that referenced this issue May 20, 2022
#1763 run gcc-12 pipeline for PR drafts
266e85f
jstrzebonski pushed a commit that referenced this issue May 20, 2022
#1763 don't run macOS build if PR is not ready for review
16d757f
jstrzebonski pushed a commit that referenced this issue May 20, 2022
#1763 add label that forces building a PR even in draft mode
3738808
jstrzebonski pushed a commit that referenced this issue May 20, 2022
#1763 update Azure auth token
f6f8629
jstrzebonski pushed a commit that referenced this issue May 20, 2022
#1763 fix indentation
f29c338
jstrzebonski pushed a commit that referenced this issue Jun 24, 2022
#1763 echo all PR labels
5f3a731
jstrzebonski pushed a commit that referenced this issue Jun 24, 2022
#1763 echo all PR labels
e54e251
jstrzebonski pushed a commit that referenced this issue Jun 24, 2022
#1763 echo all PR labels
c9769fe
jstrzebonski pushed a commit that referenced this issue Jun 24, 2022
#1763 echo all PR labels
d59aec7
jstrzebonski pushed a commit that referenced this issue Jun 24, 2022
#1763 echo all PR labels
9d50c71
jstrzebonski pushed a commit that referenced this issue Jun 24, 2022
#1763 echo all PR labels
aba2739
jstrzebonski pushed a commit that referenced this issue Jun 24, 2022
#1763 echo all PR labels
b9aa04e
jstrzebonski pushed a commit that referenced this issue Jun 24, 2022
#1763 echo all PR labels
d5988ca
jstrzebonski pushed a commit that referenced this issue Jun 24, 2022
#1763 echo all PR labels
47a6d99
jstrzebonski pushed a commit that referenced this issue Jun 24, 2022
#1763 echo all PR labels
a8a7a93
jstrzebonski pushed a commit that referenced this issue Jun 24, 2022
#1763 allow merging only if spec label exists
f8ccfd0
jstrzebonski pushed a commit that referenced this issue Jun 28, 2022
#1763 allow merging only if spec label exists
4bd7cb6
jstrzebonski pushed a commit that referenced this issue Jun 28, 2022
#1763 allow merging only if spec label exists
67daa5e
jstrzebonski pushed a commit that referenced this issue Jun 28, 2022
#1763 allow merging only if spec label exists
7ddd04e
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 ensure build auto-cancel is turned on
bd330f8
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 don't build PR drafts
ec93944
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 run gcc-12 pipeline for PR drafts
7bd722a
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 don't run macOS build if PR is not ready for review
254e4ea
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 add label that forces building a PR even in draft mode
9a534ff
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 update Azure auth token
7eb7cf1
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 fix indentation
46b367a
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 remove force-build label
d2abadc
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 rerun macOS build on marking PR as draft or ready for review
50e180a
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 cancel old macOS builds when newer changes are pushed
71e5d63
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 regenerate oneAPI yml
39f6477
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 fix macOS yml
2f55834
jstrzebonski pushed a commit that referenced this issue Jul 4, 2022
#1763 change concurrency group name for comment-on-pr
30d8f65
jstrzebonski pushed a commit that referenced this issue Jul 5, 2022
#1763 change concurrency group name for comment-on-pr
baa8413
nlslatt added a commit that referenced this issue Jul 8, 2022
@nlslatt
Merge pull request #1785 from DARMA-tasking/1763-build-only-ready-prs
edebf58 
#1763 build only ready prs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jstrzebonski jstrzebonski

Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1763 build only ready prs DARMA-tasking/vt
2 participants
@lifflander @jstrzebonski