Skip to content

Commit

Permalink
#1570: LB: remove comm aware flags
Browse files Browse the repository at this point in the history
  • Loading branch information
lifflander committed Oct 13, 2021
1 parent 4a0e532 commit 19b3641
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 13 deletions.
10 changes: 1 addition & 9 deletions src/vt/vrt/collection/balance/baselb/baselb.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,7 @@ struct BaseLB {
using QuantityType = std::map<lb::StatisticQuantity, double>;
using StatisticMapType = std::unordered_map<lb::Statistic, QuantityType>;

explicit BaseLB(
bool in_comm_aware = false,
bool in_comm_collectives = false
) : comm_aware_(in_comm_aware),
comm_collectives_(in_comm_collectives)
{ }

BaseLB() = default;
BaseLB(BaseLB const &) = delete;
BaseLB(BaseLB &&) noexcept = default;
BaseLB &operator=(BaseLB const &) = delete;
Expand Down Expand Up @@ -139,8 +133,6 @@ struct BaseLB {
ElementCommType const* comm_data = nullptr;
objgroup::proxy::Proxy<BaseLB> proxy_ = {};
PhaseType phase_ = 0;
bool comm_aware_ = false;
bool comm_collectives_ = false;
std::unique_ptr<balance::SpecEntry> spec_entry_ = nullptr;
// Observer only - LBManager owns the instance
balance::LoadModel* load_model_ = nullptr;
Expand Down
5 changes: 1 addition & 4 deletions src/vt/vrt/collection/balance/baselb/load_sampler.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,8 @@ struct LoadSamplerBaseLB : BaseLB {
using ObjSampleType = std::map<ObjBinType, ObjBinListType>;

explicit LoadSamplerBaseLB(
bool in_comm_aware = false,
bool in_comm_collectives = false,
int32_t in_bin_size = default_bin_size
) : BaseLB(in_comm_aware, in_comm_collectives),
bin_size_(in_bin_size)
) : bin_size_(in_bin_size)
{ }

public:
Expand Down

0 comments on commit 19b3641

Please sign in to comment.