-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
argv is missing nullptr at the end in TestParallelHarness #1199
Comments
Lines 62 to 83 in 43f4f21
edit: |
cz4rs
added a commit
that referenced
this issue
Dec 30, 2020
cz4rs
added a commit
that referenced
this issue
Dec 30, 2020
cz4rs
added a commit
that referenced
this issue
Dec 30, 2020
cz4rs
added a commit
that referenced
this issue
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
For strict standards compliance (i.e. if the parser in
cli11
relies on it now or in the future),nullptr
should be pushed on the end of a vector storingargv
.TestParallelHarness
usesadditional_args_
to store arguments, which lacksnullptr
atargv[argc]
.vt/tests/unit/test_parallel_harness.h
Lines 152 to 184 in 3f7d761
Expected behavior
Add
nullptr
as required by the standard. See 1ce0310 for reference.The text was updated successfully, but these errors were encountered: