#1199: tests: end argv vector with nullptr

DARMA-tasking · Dec 30, 2020 · 02d77c3 · 02d77c3
1 parent 8a81163
commit 02d77c3
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/tests/unit/test_parallel_harness.h b/tests/unit/test_parallel_harness.h
@@ -110,6 +110,10 @@ struct TestParallelHarnessAny : TestHarnessAny<TestBase> {
     auto const new_args = injectAdditionalArgs(test_argc, test_argv);
     auto custom_argc = new_args.first;
     auto custom_argv = new_args.second;
+    vtAssert(
+      custom_argv[custom_argc] == nullptr,
+      "The value of argv[argc] should always be 0"
+    );
     CollectiveOps::initialize(custom_argc, custom_argv, no_workers, true, &comm);
 
 #if DEBUG_TEST_HARNESS_PRINT
@@ -157,7 +161,8 @@ struct TestParallelHarnessAny : TestHarnessAny<TestBase> {
 
     addAdditionalArgs();
 
-    int custom_argc = additional_args_.size();
+    additional_args_.emplace_back(nullptr);
+    int custom_argc = additional_args_.size() - 1;
     char** custom_argv = additional_args_.data();
 
     return std::make_pair(custom_argc, custom_argv);