Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1199: argv is missing nullptr at the end in TestParallelHarness #1200

Merged
merged 4 commits into from
Jan 4, 2021
Merged

1199: argv is missing nullptr at the end in TestParallelHarness #1200

merged 4 commits into from
Jan 4, 2021

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Dec 30, 2020

fixes #1199

@codecov
Copy link

codecov bot commented Dec 30, 2020 •
edited
Loading

Codecov Report

Merging #1200 (cf40f40) into develop (43f4f21) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1200      +/-   ##
===========================================
- Coverage    81.00%   80.99%   -0.01%     
===========================================
  Files          730      730              
  Lines        28056    28046      -10     
===========================================
- Hits         22726    22716      -10     
  Misses        5330     5330
Impacted Files Coverage Δ
tests/unit/active/test_active_send_large.cc 93.02% <ø> (ø)
tests/unit/test_harness.h 100.00% <ø> (ø)
tests/unit/test_parallel_harness.h 100.00% <100.00%> (ø)

@cz4rs cz4rs marked this pull request as ready for review December 31, 2020 00:10
jstrzebonski
jstrzebonski approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@jstrzebonski jstrzebonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@PhilMiller PhilMiller merged commit 64c3be4 into develop Jan 4, 2021
@cz4rs cz4rs mentioned this pull request Jun 15, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstrzebonski jstrzebonski jstrzebonski approved these changes

@PhilMiller PhilMiller PhilMiller approved these changes

@lifflander lifflander Awaiting requested review from lifflander

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@nlslatt nlslatt Awaiting requested review from nlslatt

@nmm0 nmm0 Awaiting requested review from nmm0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

argv is missing nullptr at the end in TestParallelHarness
3 participants
@cz4rs @PhilMiller @jstrzebonski