#2 add additional punctuation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstrzebonski
commented
Sep 22, 2020
src/helpers.js
Outdated
| @@ -4,12 +4,12 @@ function checkPrBranch(prBranch) { | |||
| } | |||
|
|
|||
| function checkPrTitle(prTitle) { | |||
| let prTitleRegexp = /^#?\d+\s+.+$/; | |||
| let prTitleRegexp = /^#?\d+[:;,/&]?\s+.+$/; | |||
There was a problem hiding this comment.
Honestly, I still don't like it. While : makes perfect sense, I'm not that convinced about other characters. Also, GitHub supports only Fixes: #123 in PR description, so I would opt to only allow the additional colon in PR title to mimic that behavior.
There was a problem hiding this comment.
As discussed on a weekly - I'm adding only optional colon here.
jstrzebonski
requested review from
lifflander,
cz4rs,
JacobDomagala,
PhilMiller and
pnstickne
JacobDomagala
approved these changes
Sep 22, 2020
lifflander
approved these changes
Sep 22, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
jstrzebonski
pushed a commit
that referenced
this pull request
Sep 23, 2020
lifflander
added a commit
that referenced
this pull request
Sep 24, 2020
#3 fix usage of colon in PR title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2