Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept optional punctuation separating words from issue numbers #2

Closed
PhilMiller opened this issue Sep 21, 2020 · 3 comments · Fixed by #3
Closed

Accept optional punctuation separating words from issue numbers #2

PhilMiller opened this issue Sep 21, 2020 · 3 comments · Fixed by #3
Assignees

Comments

@PhilMiller
Copy link
Member

PhilMiller commented Sep 21, 2020

Right now, a title #1056: Do stuff is not accepted because the regex looks for a space immediately following the issue number.

I the the regex should be something more like ^#?\d+([:;,/&]?|\s).+$

Similarly, in the body, Fixes: #1056 is not accepted by the check (though it is picked up by Github) because of the :

@jstrzebonski
Copy link
Contributor

I just wonder if [;/&] make sense? I mean, I can imagine
#1056: Do stuff
#1056, Do stuff
#1056 - Do stuff

but not really
#1056& Do stuff
or is it more like #1055 & #965: ... ?

@PhilMiller
Copy link
Member Author

Yeah. Really, I think we should be quite a bit looser, as long as there's something that looks like an issue number separated from any other text at the beginning.

@jstrzebonski
Copy link
Contributor

Sure, I can fix it tomorrow.

@jstrzebonski jstrzebonski self-assigned this Sep 22, 2020
jstrzebonski pushed a commit that referenced this issue Sep 22, 2020
lifflander added a commit that referenced this issue Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants