-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept optional punctuation separating words from issue numbers #2
Comments
I just wonder if but not really |
Yeah. Really, I think we should be quite a bit looser, as long as there's something that looks like an issue number separated from any other text at the beginning. |
Sure, I can fix it tomorrow. |
jstrzebonski
pushed a commit
that referenced
this issue
Sep 22, 2020
jstrzebonski
pushed a commit
that referenced
this issue
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, a title
#1056: Do stuff
is not accepted because the regex looks for a space immediately following the issue number.I the the regex should be something more like
^#?\d+([:;,/&]?|\s).+$
Similarly, in the body,
Fixes: #1056
is not accepted by the check (though it is picked up by Github) because of the:
The text was updated successfully, but these errors were encountered: