Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 fix usage of colon in PR title #5

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Conversation

jstrzebonski
Copy link
Contributor

@jstrzebonski jstrzebonski commented Sep 23, 2020

Fixes #3

First of all it wasn't working, because I forgot to generate dist/index.js, my bad :- |
There was a problem in regex checking PR description - now it's fix.
I've also added more logs to see what's happening.
Last but not least - I've added some more unit tests cases.

@jstrzebonski jstrzebonski self-assigned this Sep 23, 2020
@jstrzebonski jstrzebonski marked this pull request as ready for review September 23, 2020 13:26
@jstrzebonski jstrzebonski force-pushed the 3-fix-colon-in-pr-title-bug branch 13 times, most recently from 34e5c14 to 2f3665d Compare September 23, 2020 17:38
@lifflander lifflander merged commit 4b20d20 into master Sep 24, 2020
@lifflander lifflander deleted the 3-fix-colon-in-pr-title-bug branch September 24, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants