Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#464: Improve efficiency of cluster swap stage of clustering transfer strategy #451

Closed
wants to merge 23 commits into from
Closed

#464: Improve efficiency of cluster swap stage of clustering transfer strategy #451

wants to merge 23 commits into from

Conversation

ppebay
Copy link
Contributor

@ppebay ppebay commented Sep 30, 2023 •
edited
Loading

Resolves #464

Related to #446

@ppebay ppebay self-assigned this Sep 30, 2023
cwschilly and others added 21 commits October 5, 2023 12:50
@cwschilly
#453: change to relative path (#454)
9c5929e
@cwschilly
#421: make lbsVTDataWriter at parity with the lbsVTDataReader for use…
75758d0 
…r-defined data (#452)

* #421: add user_defined data to jsonwriter

* #421: return to original config
@ppebay
#446: get swap info messages out of the way in non-debug mode
a8d7362
@pierrepebay @cwschilly
#447: Fix Pypi release pipeline (#448)
22967e7 
* #447: Try removing authentication

* #447: fix classifiers

* #447: update development status

* #447: try publishing to PyPi

* #447: clean up

* #447: add condition back to pypi pipeline

* #447: add newline

---------

Co-authored-by: Caleb Schilly <[email protected]>
@ppebay
Merge branch '446-mprove-efficiency-of-sub-clustering-stage-of-cluste…
b398f17 
…ring-transfer-strategy' of github.com:DARMA-tasking/LB-analysis-framework into 446-mprove-efficiency-of-sub-clustering-stage-of-clustering-transfer-strategy
@ppebay
#446: improved performance by removing one spurious phase instantiation
d2e77b2
@ppebay
#446: retaining one debug statement as information message
710d1be
@ppebay
#446: added pass statement to ABC for good form
178a4a6
@ppebay
#416: improved documentation and style to clarify code
1127ea6
@ppebay
#446: improved instrumentation to better understand cluster swaps
743d98e
@ppebay
#446: fix incorrect instrumentation of transfers
88c373e
@ppebay
#446: get swap info messages out of the way in non-debug mode
7140119
@ppebay
#446: improved performance by removing one spurious phase instantiation
e334eb0
@ppebay
#446: retaining one debug statement as information message
8202f11
@ppebay
#446: added pass statement to ABC for good form
ddd4341
@ppebay
#416: improved documentation and style to clarify code
02ed979
@ppebay
#446: improved instrumentation to better understand cluster swaps
d70f7ed
@ppebay
#446: fix incorrect instrumentation of transfers
de1b31c
@ppebay
#446: fixed incorrectly entered newline
394ab2b
@ppebay
#446: reduced number of cluster recomputes to improve swap stage perf…
38cf78b 
…ormance
@ppebay
#446: Merge branch '446-mprove-efficiency-of-sub-clustering-stage-of-…
d6b9a5a 
…clustering-transfer-strategy' of github.com:DARMA-tasking/LB-analysis-framework into 446-mprove-efficiency-of-sub-clustering-stage-of-clustering-transfer-strategy
@ppebay
Copy link
Contributor Author

ppebay commented Oct 10, 2023

@nlslatt if you get a chance (and time), this branch contains performance improvements to the swapping stage of the clustering transfer strategy. I added some stats (and fixed some that turned out to be incorrect regarding rejection rates), so any feedback as to whether execution speed is improved with your data sets would be appreciated.

Meanwhile I am continuing to work on the sub-clustering stage. Thanks

@ppebay ppebay requested a review from nlslatt October 10, 2023 08:25
@ppebay ppebay mentioned this pull request Oct 11, 2023
Merged
@ppebay
Copy link
Contributor Author

ppebay commented Oct 12, 2023

As discussed with @nlslatt and @lifflander this is ready to be reviewed

@ppebay ppebay marked this pull request as ready for review October 12, 2023 19:12
@ppebay ppebay mentioned this pull request Oct 12, 2023
Merged
@ppebay ppebay changed the title #446: Improve efficiency of sub-clustering stage of clustering transfer strategy #446: Improve efficiency of cluster swap stage of clustering transfer strategy Oct 12, 2023
@nlslatt
Copy link
Contributor

nlslatt commented Oct 12, 2023 •
edited
Loading

@ppebay You should open an issue that motivates your changes and link it to that issue instead of the one that you don't want closed.

@nlslatt
Copy link
Contributor

nlslatt commented Oct 12, 2023

@ppebay It also looks like you have commits from other PRs on this branch. Please rebase and make sure the branch is clean.

@ppebay
Copy link
Contributor Author

ppebay commented Oct 13, 2023

Thanks @nlslatt this is now fixing #464

Regarding the commits from other branches, this is because this branch was rebased on develop twice in order to incorporate other changes along the way.

@nlslatt nlslatt changed the title #446: Improve efficiency of cluster swap stage of clustering transfer strategy #464: Improve efficiency of cluster swap stage of clustering transfer strategy Oct 13, 2023
@ppebay ppebay mentioned this pull request Oct 13, 2023
Merged
@ppebay
Copy link
Contributor Author

ppebay commented Oct 13, 2023

This is now superseded by new PR #465

@ppebay ppebay closed this Oct 13, 2023
@ppebay ppebay deleted the 446-mprove-efficiency-of-sub-clustering-stage-of-clustering-transfer-strategy branch October 16, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlslatt nlslatt Awaiting requested review from nlslatt

Assignees

@ppebay ppebay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve execution speed of cluster swap stage in clustering algorithm
4 participants
@ppebay @nlslatt @cwschilly @pierrepebay