Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#453: Fix FileNotFoundError in lbaf v1.0.0 package #454

Merged
merged 1 commit into from
Oct 5, 2023
Merged

#453: Fix FileNotFoundError in lbaf v1.0.0 package #454

merged 1 commit into from
Oct 5, 2023

Conversation

cwschilly
Copy link
Contributor

Fixes #453

@cwschilly cwschilly linked an issue Oct 5, 2023 that may be closed by this pull request
Fix FileNotFoundError in lbaf v1.0.0 package #453
Closed
@cwschilly cwschilly self-assigned this Oct 5, 2023
@cwschilly
Copy link
Contributor Author

This PR changes the target_dir in __print_QOI() to use the relative path (../Model) instead of the absolute path (PROJECT_PATH/src/lbaf/Model); this should resolve the issue with the PyPi package

@cwschilly cwschilly requested a review from ppebay October 5, 2023 14:54
@cwschilly cwschilly marked this pull request as draft October 5, 2023 14:55
@cwschilly cwschilly marked this pull request as ready for review October 5, 2023 15:05
@cwschilly
Copy link
Contributor Author

cwschilly commented Oct 5, 2023 •
edited
Loading

I've tested this code by uploading to TestPyPi and running the pip install command. It works as expected. Since PyPi does not allow rewriting releases, if we were to publish this fix to PyPi this may have be released as v1.0.1

ppebay
ppebay approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ppebay ppebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@cwschilly cwschilly merged commit 9c5929e into develop Oct 5, 2023
7 of 8 checks passed
@cwschilly cwschilly deleted the 453-fix-filenotfounderror-in-lbaf-v100-package branch October 5, 2023 16:50
@cwschilly cwschilly mentioned this pull request Oct 9, 2023
Closed
@ppebay ppebay mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppebay ppebay ppebay approved these changes

Assignees

@cwschilly cwschilly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix FileNotFoundError in lbaf v1.0.0 package
2 participants
@cwschilly @ppebay