-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#447: Fix Pypi release pipeline #448
Conversation
@ppebay @pierrepebay @lifflander I believe I have resolved the issue by fixing the incorrect Classifiers in setup.cfg--I was able to successfully upload the package to the TestPyPi index here. I am not sure of the ramifications of changing the line I also updated the development status from For reference, here's the list of accepted classifiers. |
586e99b
to
5667bfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please @pierrepebay verify that it's also working for you as well
@ppebay This PR is ready for review/merge; the PyPi package has been published here. After discussing with @pierrepebay , I removed the "tag condition" from the github workflow so that we could publish it straight from this PR, published the package, and then added the condition back so that future releases will be published as expected. Also, it seems that the Python3.9 acceptance test failure has returned. |
@pierrepebay review needed thanks |
The fix for PyPi looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving following also @pierrepebay 's comment
Fixes: #447