Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#447: Fix Pypi release pipeline #448

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Conversation

pierrepebay
Copy link
Contributor

Fixes: #447

@pierrepebay pierrepebay added the bug Something isn't working label Sep 29, 2023
@pierrepebay pierrepebay self-assigned this Sep 29, 2023
@pierrepebay pierrepebay linked an issue Sep 29, 2023 that may be closed by this pull request
@cwschilly
Copy link
Contributor

cwschilly commented Oct 3, 2023

@ppebay @pierrepebay @lifflander I believe I have resolved the issue by fixing the incorrect Classifiers in setup.cfg--I was able to successfully upload the package to the TestPyPi index here.

I am not sure of the ramifications of changing the line License :: OSI Approved :: Modified BSD License to License :: OSI Approved :: BSD License, but if we think it's okay then this should be ready to ship.

I also updated the development status from Beta to Production/Stable.

For reference, here's the list of accepted classifiers.

@cwschilly cwschilly force-pushed the 447-fix-pypi-release-pipeline branch from 586e99b to 5667bfd Compare October 3, 2023 20:22
@cwschilly cwschilly changed the title #447: Try removing authentication #447: Fix Pypi release pipeline Oct 3, 2023
@cwschilly cwschilly requested review from ppebay and lifflander October 3, 2023 20:25
@cwschilly cwschilly marked this pull request as ready for review October 3, 2023 20:41
@cwschilly cwschilly self-assigned this Oct 3, 2023
Copy link
Contributor

@ppebay ppebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please @pierrepebay verify that it's also working for you as well

@cwschilly
Copy link
Contributor

@ppebay This PR is ready for review/merge; the PyPi package has been published here.

After discussing with @pierrepebay , I removed the "tag condition" from the github workflow so that we could publish it straight from this PR, published the package, and then added the condition back so that future releases will be published as expected.

Also, it seems that the Python3.9 acceptance test failure has returned.

@ppebay
Copy link
Contributor

ppebay commented Oct 5, 2023

@pierrepebay review needed thanks

@pierrepebay pierrepebay removed their assignment Oct 6, 2023
@pierrepebay
Copy link
Contributor Author

The fix for PyPi looks good to me.

@ppebay ppebay self-requested a review October 6, 2023 11:41
Copy link
Contributor

@ppebay ppebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving following also @pierrepebay 's comment

@cwschilly cwschilly merged commit 22967e7 into develop Oct 6, 2023
7 of 8 checks passed
@cwschilly cwschilly deleted the 447-fix-pypi-release-pipeline branch October 6, 2023 12:48
@ppebay ppebay mentioned this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Pypi release pipeline
3 participants