[BUGFIX] State Transitions panel is crashing with "RPC Terminated" er… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror (#31) **User-Facing Changes** The default layout of ADP was not functioning correctly. The "State Transitions" panel was crashing due to a re-render problem, causing an RPC to be created and closed twice with the same ID. This led to a message being sent during the process, resulting in the exception "RPC terminated." **Description** A complete solution for the problem was not identified, suggesting the issue might stem from a deeper component such as the LayoutManager. Instead of resolving the root cause, the error has been suppressed. A lost message to a closed RPC is not critical since the new RPC operates correctly. However, this issue should be revisited in the future for a more thorough fix. **Checklist** - [x] The web version was tested and it is running ok - [x] The desktop version was tested and it is running ok - [ ] I've updated/created the storybook file(s) - [x] The release version was updated on package.json files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ror (Lichtblick-Suite#31)
User-Facing Changes
The default layout of ADP was not functioning correctly. The "State Transitions" panel was crashing due to a re-render problem, causing an RPC to be created and closed twice with the same ID. This led to a message being sent during the process, resulting in the exception "RPC terminated."
Description
A complete solution for the problem was not identified, suggesting the issue might stem from a deeper component such as the LayoutManager. Instead of resolving the root cause, the error has been suppressed. A lost message to a closed RPC is not critical since the new RPC operates correctly. However, this issue should be revisited in the future for a more thorough fix.
Checklist
User-Facing Changes
Description
Checklist