Merge pull request #1 from bmw-software-engineering/main

[BUGFIX] State Transitions panel is crashing with "RPC Terminated" er…
Corvus-Labs · Jun 23, 2024 · 04f6f97 · 04f6f97
2 parents 36abb8b + 0f83366
commit 04f6f97
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "foxbox",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "license": "MPL-2.0",
   "private": true,
   "productName": "Foxbox",

diff --git a/packages/studio-base/src/components/Chart/index.tsx b/packages/studio-base/src/components/Chart/index.tsx
@@ -351,10 +351,12 @@ function Chart(props: Props): JSX.Element {
       return;
     }
 
+    // Temporarily remove setUpdateError to avoid displaying the error caused by re-rendering,
+    // which results in the component crashing. The crash happens because a message is sent to a
+    // closed RPC, causing some panels to become unusable. This approach ignores the error to
+    // keep the component functional. Revisit this once the underlying issue is resolved.
     updateChart(newUpdate).catch((err: Error) => {
-      if (isMounted()) {
-        setUpdateError(err);
-      }
+      console.error(err);
     });
   }, [getNewUpdateMessage, isMounted, updateChart]);
 

diff --git a/packages/studio/package.json b/packages/studio/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@foxglove/studio",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "license": "MPL-2.0",
   "repository": {
     "type": "git",