Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] State Transitions panel is crashing with "RPC Terminated" error #31

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

aneuwald-ctw
Copy link
Contributor

User-Facing Changes
The default layout of ADP was not functioning correctly. The "State Transitions" panel was crashing due to a re-render problem, causing an RPC to be created and closed twice with the same ID. This led to a message being sent during the process, resulting in the exception "RPC terminated."

Description
A complete solution for the problem was not identified, suggesting the issue might stem from a deeper component such as the LayoutManager. Instead of resolving the root cause, the error has been suppressed. A lost message to a closed RPC is not critical since the new RPC operates correctly. However, this issue should be revisited in the future for a more thorough fix.

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • I've updated/created the storybook file(s)
  • The release version was updated on package.json files

Copy link
Contributor

@laisspportugal laisspportugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to do it since it's preventing the user to use the tool. Please take notes for us to take deeper look on that in the future.

@aneuwald-ctw aneuwald-ctw merged commit 0f83366 into main Jun 7, 2024
8 checks passed
@aneuwald-ctw aneuwald-ctw deleted the bugfix/state-transitions-panel-crashing branch June 7, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants