Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace lodash #62

Merged
merged 8 commits into from
Feb 16, 2023
Merged

replace lodash #62

merged 8 commits into from
Feb 16, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Feb 3, 2023

📦 Published PR as canary version: 0.0.2--canary.62.4a3b146.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

Version

Published prerelease version: v0.0.2-next.9

Changelog

🐛 Bug Fix

⚠️ Pushed to next

🔩 Dependency Updates

Authors: 12

@ndelangen ndelangen requested a review from shilman February 3, 2023 14:49
@ndelangen ndelangen self-assigned this Feb 3, 2023
@ndelangen ndelangen added the enhancement New feature or request label Feb 3, 2023
@ndelangen
Copy link
Member Author

This PR makes this package dependency-less (runtime)

package.json Outdated Show resolved Hide resolved
src/includeConditionalArg.ts Show resolved Hide resolved
src/toStartCaseStr.ts Show resolved Hide resolved
src/toStartCaseStr.ts Show resolved Hide resolved
@ndelangen
Copy link
Member Author

@shilman if you're ok with this change, should we merge this?

@ndelangen
Copy link
Member Author

@shilman WDYT?

Copy link
Contributor

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOOOOOVE THIS ❤️ ❤️ ❤️ Minor nit

src/toStartCaseStr.test.ts Show resolved Hide resolved
@ndelangen ndelangen requested a review from shilman February 14, 2023 13:02
@ndelangen
Copy link
Member Author

@shilman good to merge?

Copy link
Contributor

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shilman
Copy link
Contributor

shilman commented Apr 3, 2023

🚀 PR was released in v0.1.0 🚀

@shilman shilman removed the prerelease label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants