Makes name argument for 'toId' optional #17
Conversation
src/index.ts
Outdated
| `${sanitizeSafe(kind, 'kind')}--${sanitizeSafe(name, 'name')}`; | ||
| export const toId = (kind: string, name?: string) => | ||
| `${sanitizeSafe(kind, 'kind')}${ | ||
| typeof name === 'string' ? `--${sanitizeSafe(name, 'name')}` : '' |
There was a problem hiding this comment.
I think it's enough to check if name exists here. You can skip typecheking here. WDYT?
name ? `--${sanitizeSafe(name, 'name')}` : ''There was a problem hiding this comment.
Yeah, I thought so too, but there's a test case for throwing an exception should the argument (name) be empty string. Without typecheking, an empty string would never be passed to sanitizeSafe and the function will not throw. Wasn't sure, if I should keep this behavior (throwing an exception)... Then again, the whole issue here is making the name arg optional...
There was a problem hiding this comment.
I went ahead and allowed '' as story. We're intentionally adding support for this, so the test had to change.
|
Will this be merged soon? We need this update to fix the related Storybook bug in our implementation. |
|
🚀 PR was released in |
This PR allows generating storybook ID only from a component/kind and would help getting this fixed.