Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conditional arg types and metadata #36

Merged
merged 31 commits into from
Oct 22, 2022
Merged

Add conditional arg types and metadata #36

merged 31 commits into from
Oct 22, 2022

Conversation

shilman
Copy link
Contributor

@shilman shilman commented Feb 18, 2022 •
edited
Loading

📦 Published PR as canary version: 0.0.2--canary.36.ecfc79e.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@shilman shilman mentioned this pull request Apr 5, 2022
Merged
tmeasday
tmeasday approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IanVS IanVS mentioned this pull request Apr 8, 2022
Closed
tmeasday and others added 19 commits April 12, 2022 17:21
@tmeasday
Re-apply TArgs to CSF render type
4566f4d
@shilman
Add no arg/global specified test
1e215f6
@tmeasday
Add step to play context and runStep to project annotations
d3836e7
@tmeasday
Update re: @ghengeveld
80f2fb8
@tmeasday
Need to parameterize runStep
0899bb7
@tmeasday
Step functions are allowed to be async of course
f3e3044
@shilman
Merge branch '6-4-new-types' into feat/conditional-args
ecfc79e
@shilman
Merge branch 'feat/conditional-args' into 41-tighten-render-type
a3d8c69
@shilman
Merge branch '41-tighten-render-type' into add-step
3bd2bd7
@kasperpeulen
SB-738: Sound arg types
3049387
@kasperpeulen
Use HKT's instead
2e05407
@kasperpeulen
update the test
9a29dd4
@kasperpeulen
explain usage for higher kinded T
fbf3c7a
@kasperpeulen
make T optional
9d84710
@kasperpeulen
rename TArgsAnnotations -> TRequiredArgs
b089ae5
@kasperpeulen
fix subcomponents regression
258942b
@kasperpeulen
ArgsFromMeta utility and generic ArgsStoryFn RT
768ca23
@kasperpeulen
use tsup and upgrade dependencies
23af5af
@kasperpeulen
add type test for ArgsFromMeta
26e6539
@shilman
Merge pull request #51 from ComponentDriven/kasper/csf-3-improvements
084d9eb 
ArgsFromMeta utility and generic ArgsStoryFn RT
@shilman
Merge pull request #49 from ComponentDriven/kasper/sb-738/csf-3
65292c2 
Sound arg types for CSF3
@shilman
Merge pull request #48 from ComponentDriven/add-step
47fcdb1 
Add step to play context and `runStep` to project annotations
@shilman
Merge pull request #43 from ComponentDriven/41-tighten-render-type
5edcaf6 
Re-apply `TArgs` to CSF `render` type
@shilman shilman marked this pull request as ready for review October 22, 2022 08:39
@shilman shilman merged commit e31af55 into 6-4-new-types Oct 22, 2022
@shilman shilman deleted the feat/conditional-args branch October 22, 2022 08:40
This was referenced Oct 22, 2022
Merged
Merged
This was referenced Nov 4, 2022
Merged
Merged
Merged
This was referenced Nov 11, 2022
Merged
Merged
Merged
@shilman shilman mentioned this pull request Dec 8, 2022
Merged
This was referenced Feb 16, 2023
Merged
Merged
@shilman shilman mentioned this pull request Mar 31, 2023
Merged
@shilman
Copy link
Contributor Author

shilman commented Apr 3, 2023

🚀 PR was released in v0.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shilman @tmeasday @kasperpeulen